From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4F643BBA08 for ; Thu, 28 May 2026 10:40:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779964858; cv=none; b=UNgKF41TTLjZ55GGynrX8LJpP025S3Rp/qpXpWJ0UH/aCNXucPAuO5qCFrU/EwpxCZF/pRcoO31Dg+ZHR8Yu1Z9FBvWTmWZF/mjWFGnJsfHpnYe6AgstL9Hjlf6drxvGYzY2UgB9Sa2lUzlKEJR3qVlsGH6tGA1C2vEz0GJq/LM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779964858; c=relaxed/simple; bh=Jwkj7158czrheThyT3gvtKTcpFQnoZihewC5ZY+b9zQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BRcIpdm/DJXo1dCtRYiZkrhawKNzbAW5m5VwctO5NIT0l78GYl+b8Iq65X0ITLtNfmDeSa4LnkCw0fAH4D2biVR8xkNdTsMz3ACM1QZHAgvn5qtGJpa6jJQPbPbflgdscVxDNoYG0+hOoMy+1/j9clKVWzkUKJdhDcyM23M4EGA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Vdfp1AQ7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=erRBMDHy; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Vdfp1AQ7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="erRBMDHy" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64S8wN1I382549 for ; Thu, 28 May 2026 10:40:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= DoPyR1h87JFTyIOs+EVznBYVFvi1bbJRD7VDh6vzS7U=; b=Vdfp1AQ7dby9FMsw 3b4QURfYyaZgBden7CCAd4G4LgUoKv65MIDAtXwszE/JTvJKXCoEqh6vU8Jt37pb P6+i+/UmaO5OCxvCIg9THmOhRYcrvCzCuTISIkKRzbYRNC1jEeInOiY976XU4VqX FhBThB9qnLUeXL9/9ajbDOcYrd+EpKioSpvnmPUZykmpC3aTVan7DKE3h2cqjYAx 05O2Ga5NsvtMkygAG0oqz1OK1MsDiI7FtVVag3Phx8VAN8u3cp6D3U1ZThOZw9vm bqCRL56hsNlXDtL40sllxy41VC14hl733z/ePjafnh6Kh9vCcOuPwrkbRbKP2grU AnEWlg== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ee7yrje51-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 28 May 2026 10:40:51 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-90f5248b209so1171507485a.2 for ; Thu, 28 May 2026 03:40:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779964851; x=1780569651; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=DoPyR1h87JFTyIOs+EVznBYVFvi1bbJRD7VDh6vzS7U=; b=erRBMDHy9VKdlFvwk35LIy7XBjQTQbNHzru3fIDXuWodgVCLExm7byj9Mtt9iJdis4 1e233DkWI2+knGRQXQnZuKT+HJiDT4Aht8vVeCP1edf1aGbT4MkSyXq7zthWh6R2PmG2 ey0utampotD/iA+0ZQyT2GjLygVOzbY7hXJbeL584WbtfuYAjLx15tIn+lUP2fdxbmC9 qYSWmjVzR+QJJqL5A62fjSttPbzLGiVWCSgylDs5Y4WD+rGrG3R3WSgoMqajR4Wr/GYP Nv2umhr4oTSzEDRpj42IOHVgCkPb2E42AZR4XqHl7DEjF+Eif8EZEmTajx6JOoqQl/R6 Tt/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779964851; x=1780569651; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=DoPyR1h87JFTyIOs+EVznBYVFvi1bbJRD7VDh6vzS7U=; b=IzxZGhIMIWUwj/kHTiHrFjz38EC/Bu2qqDfp95yWBikcvnuCP/qRYoN7HDjP4eTn7n F6QIHKvm2ibx1OU2TOANyDZ4/Uj9CIw8W3teP7791bB7G3tdLSVJW0YLffA6SsnDO4sA B1U7T7C+MlmR/W7d3XKC3CeVBC6srLNzSW15+a4x/lyjdkurF8WVZ1EaTrcEnOOPhgNN 19j/3RXmy/QdMadMScrT6f2uJOMZT7yX1zqA4MB9GNFmLl3Hs79m8TuMJsAITBHftg13 qYVF4+PmvVCF2CUBevBiLxJksc+4+Bfxr0ZFqSACHShZ+Sn4+6XBRVA1MKQKAdYft1Kl 5Nug== X-Forwarded-Encrypted: i=1; AFNElJ885TcM97LR4CHSobSouQqoxiCFGGHH2C5owkdyU0LFV0G9JHw2gAZjr2nFS2ZvrL48bIjpOPey/0U1kmk=@vger.kernel.org X-Gm-Message-State: AOJu0YzYYwu0PGmV1/gQypIDck/qTr7U8dQXiGJ0YULII1pMSOHoasSO zbrFkq/tQz3nkFlmJBjLX8iLYSpoyn09kewOEwbzulMr3Wk8ulYCBiOuPd19PRPZYbF2MT6nV/r PA5JS6eAdFqAgs64J7XH0cG/CF2h8IO/k0emmJvWlk/w4WkRcR3drwQtvSOEPDLXTcfs= X-Gm-Gg: Acq92OEuhpazYp+r/Ge241dH3wza6p6VXu+hwVyGJUmFA3pVoqEm/Dzrf1biQlgIZA4 mpX6rnS/Alws0sqD90M7IbPb6LEHJK4VgdSgjvH+yH4B9T3UqKEKDMXzTKTDZLvQj+lSasoaNgd 42DzmFZnAjKVR7jSaVoUeliSi77I3hJ4N3TRk5B52cT8k9/7WNA+dSF1Xm3l+Rbh3LlL6Honahh 6W/XAmgT9+/rPJwfhqqjE7JosNDASVGqOG1XWveKv++QqnkPN1vtBtcPAQlnoyjc3CG2x2O5u0m KbFcjyibmHrXO4w/SX1DETUWqa3pc08g3tq4h0Mi29oMe11SVNUM4rj1OzFBDdXQP44FFOScJlW kycUaWoUZgiKs5Vq3LMxCE/Hw4TVTBgpwl68t6wsMP7t0wECbwB5OeI+HU5lIkVaboXsLvfWPfs HIXbt87HjsKOosth9jDg== X-Received: by 2002:a05:620a:3199:b0:909:fbf2:52bf with SMTP id af79cd13be357-914b499f6d9mr3689904785a.36.1779964850753; Thu, 28 May 2026 03:40:50 -0700 (PDT) X-Received: by 2002:a05:620a:3199:b0:909:fbf2:52bf with SMTP id af79cd13be357-914b499f6d9mr3689901385a.36.1779964850302; Thu, 28 May 2026 03:40:50 -0700 (PDT) Received: from yongmou2.ap.qualcomm.com (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id af79cd13be357-914f86fffddsm755148485a.12.2026.05.28.03.40.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2026 03:40:49 -0700 (PDT) From: Yongxing Mou Date: Thu, 28 May 2026 18:40:24 +0800 Subject: [PATCH v5 03/15] drm/msm/dp: move mode setup into msm_dp_panel_init_panel_info() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260528-dp_mstclean-v5-3-a9221c1f1f3b@oss.qualcomm.com> References: <20260528-dp_mstclean-v5-0-a9221c1f1f3b@oss.qualcomm.com> In-Reply-To: <20260528-dp_mstclean-v5-0-a9221c1f1f3b@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou , Dmitry Baryshkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1779964831; l=4019; i=yongxing.mou@oss.qualcomm.com; s=20250910; h=from:subject:message-id; bh=Jwkj7158czrheThyT3gvtKTcpFQnoZihewC5ZY+b9zQ=; b=hVBOWnwS4GPtlOV/sdh48SQ5BJbvkZZ1sI8HBcpte896kE6d+6eRaQMnTN3v6XJeR8WBsPIQ/ i79/qiTxDY8B5YE9VmuGgkLwZAJ9RaZJju1bNhPdGT4UAU8N+QEZFUW X-Developer-Key: i=yongxing.mou@oss.qualcomm.com; a=ed25519; pk=rAy5J1eP+V7OXqH5FJ7ngMCtUrnHhut30ZTldOj52UM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI4MDEwNiBTYWx0ZWRfX47Hr2TxeVkC7 ddMWZqeuL2SuBELsXiDzfeZp//s8e6DSyOh0/y+gtnXrwQbT5C3GBGcaimYImFh9IBGIb7cyNPg HTATz4MgI02Y9iIZvOEGRdD5y/LpaCSXdvnEgnwyIQ99WGFLGqQ7FS3DQ6YUSm7Ur+h4c/LJWkd SecWmr0TYqPLb5VWwKIthOe2Bb//XpdiIQXNBV5Trea7p4Cin0bn1LOZHbrvBvMzc10B/efyhhs p7wQkkLxIwDZ1it9UIPR05g2zpXqGFqC0Ie/KBhah+P5aCPAK/0RN4Bu2lUFTiw+kkxFVxBBIJY fhDrSUEgBLlfuINP116uZdlDnH0iS3DZCuNqT93VKyPFV4dB6d/2uvCXbSCm916Of3ONPIcM7rG zAFPIFMaLYaSwMgjDU/S1sRzBArYwraxMAgCGLxnhYW7zrX6L7Wlh1li3b5EXsfsm4slmbcPTCU 8a89yLzeDBeAN4u0omQ== X-Authority-Analysis: v=2.4 cv=PLo/P/qC c=1 sm=1 tr=0 ts=6a181bb3 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=RRF978PcF5p4qF5CYGQA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: Vw8mhSC4EJbJmegwqJs-jemxu3E6jaxm X-Proofpoint-ORIG-GUID: Vw8mhSC4EJbJmegwqJs-jemxu3E6jaxm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-28_03,2026-05-26_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1015 malwarescore=0 spamscore=0 bulkscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605280106 The display layer directly assigns msm_dp_panel mode fields (bpp, sync polarity, yuv420 flag) instead of letting the panel manage its own state. Pass adjusted_mode and bpp as parameters to msm_dp_panel_init_panel_info() and move the assignments inside it. Suggested-by: Dmitry Baryshkov Signed-off-by: Yongxing Mou --- drivers/gpu/drm/msm/dp/dp_display.c | 11 +---------- drivers/gpu/drm/msm/dp/dp_panel.c | 18 +++++++++++++++--- drivers/gpu/drm/msm/dp/dp_panel.h | 4 +++- 3 files changed, 19 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 181d238addfc..f33c754b83c3 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -604,21 +604,12 @@ static int msm_dp_display_set_mode(struct msm_dp *msm_dp_display, dp = container_of(msm_dp_display, struct msm_dp_display_private, msm_dp_display); - drm_mode_copy(&msm_dp_panel->msm_dp_mode.drm_mode, adjusted_mode); if (msm_dp_display_check_video_test(msm_dp_display)) bpp = msm_dp_display_get_test_bpp(msm_dp_display); else bpp = msm_dp_panel->connector->display_info.bpc * 3; - msm_dp_panel->msm_dp_mode.bpp = bpp ? bpp : 24; /* Default bpp */ - msm_dp_panel->msm_dp_mode.v_active_low = - !!(adjusted_mode->flags & DRM_MODE_FLAG_NVSYNC); - msm_dp_panel->msm_dp_mode.h_active_low = - !!(adjusted_mode->flags & DRM_MODE_FLAG_NHSYNC); - msm_dp_panel->msm_dp_mode.out_fmt_is_yuv_420 = - drm_mode_is_420_only(&msm_dp_panel->connector->display_info, adjusted_mode) && - msm_dp_panel->vsc_sdp_supported; - msm_dp_panel_init_panel_info(msm_dp_panel); + msm_dp_panel_init_panel_info(msm_dp_panel, adjusted_mode, bpp ? bpp : 24); /* populate wide_bus_support to different layers */ dp->ctrl->wide_bus_en = diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c index bde4a772d22c..e76dad0f6663 100644 --- a/drivers/gpu/drm/msm/dp/dp_panel.c +++ b/drivers/gpu/drm/msm/dp/dp_panel.c @@ -647,15 +647,27 @@ int msm_dp_panel_timing_cfg(struct msm_dp_panel *msm_dp_panel, bool wide_bus_en) return 0; } -int msm_dp_panel_init_panel_info(struct msm_dp_panel *msm_dp_panel) +int msm_dp_panel_init_panel_info(struct msm_dp_panel *msm_dp_panel, + const struct drm_display_mode *adjusted_mode, + u32 bpp) { struct drm_display_mode *drm_mode; struct msm_dp_panel_private *panel; - drm_mode = &msm_dp_panel->msm_dp_mode.drm_mode; - panel = container_of(msm_dp_panel, struct msm_dp_panel_private, msm_dp_panel); + drm_mode_copy(&msm_dp_panel->msm_dp_mode.drm_mode, adjusted_mode); + msm_dp_panel->msm_dp_mode.bpp = bpp; + msm_dp_panel->msm_dp_mode.v_active_low = + !!(adjusted_mode->flags & DRM_MODE_FLAG_NVSYNC); + msm_dp_panel->msm_dp_mode.h_active_low = + !!(adjusted_mode->flags & DRM_MODE_FLAG_NHSYNC); + msm_dp_panel->msm_dp_mode.out_fmt_is_yuv_420 = + drm_mode_is_420_only(&msm_dp_panel->connector->display_info, adjusted_mode) && + msm_dp_panel->vsc_sdp_supported; + + drm_mode = &msm_dp_panel->msm_dp_mode.drm_mode; + /* * print resolution info as this is a result * of user initiated action of cable connection diff --git a/drivers/gpu/drm/msm/dp/dp_panel.h b/drivers/gpu/drm/msm/dp/dp_panel.h index 53b7b4463551..4519ac374220 100644 --- a/drivers/gpu/drm/msm/dp/dp_panel.h +++ b/drivers/gpu/drm/msm/dp/dp_panel.h @@ -43,7 +43,9 @@ struct msm_dp_panel { u32 max_bw_code; }; -int msm_dp_panel_init_panel_info(struct msm_dp_panel *msm_dp_panel); +int msm_dp_panel_init_panel_info(struct msm_dp_panel *msm_dp_panel, + const struct drm_display_mode *adjusted_mode, + u32 bpp); int msm_dp_panel_deinit(struct msm_dp_panel *msm_dp_panel); int msm_dp_panel_timing_cfg(struct msm_dp_panel *msm_dp_panel, bool wide_bus_en); int msm_dp_panel_read_link_caps(struct msm_dp_panel *msm_dp_panel, -- 2.43.0