From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DDCD3B9601 for ; Thu, 28 May 2026 10:41:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779964864; cv=none; b=XyLl+vE7K0+XfOoGdJ6mH4mP1wPkeLLa/lvcQ0aZb8S3hc9zAX24OgdCHpuhW2NpBT92GO5UaI4/9Zsv6YpnLVR56P3pJGhBpuycd/i5OOP89iX8YQeubdDkTZ0R+Tr3GrDeAPMFFAASF8xAvWuVF/6SmZpDr6L8NcLpgadlQiw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779964864; c=relaxed/simple; bh=cG/LGNCcQTa4kjEHUBEM5XHcqi1wHebQYuwINqyWaz4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=L3X8WpPF1odriDKDSjF93EOfpcOFciE+RMqTAK9L3oXer01xcvsB/ce11AvCsTm9fd5VoQTA5sB9Gk5bGO5SLLpcAqTntzsOOl6tEGpRpDojB+lgWI96tKuFHcA587YbEIITlCXoevkUexRQr0cHTrUW5Cw6539mkO0bDj4MYMk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HF9RTp/f; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gaasbFqx; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HF9RTp/f"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gaasbFqx" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64S8vmTd1698013 for ; Thu, 28 May 2026 10:41:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Lj1ey6ImyO3i3vMmCJMMvm8iJ4e0EDN26FxKqAvXcRQ=; b=HF9RTp/f3RpbIIrd qA5SVCJLvnyO7HAkP482gjg3dQ7aI2zSSPkdMZue/JcU18fbEH580OX/qnJv07Ra dBDX9VaFIamvhapWHMtC3BQARp6L3gksyTpoxTAOOyVgrUJc6Fw/IytAqvIx4YoM fcevawvjX84omOfMXZtuE3Wv5M8hveo93nMXk5Z2upzz72UXIdr3aZBVW9LyJdR5 H0u+qQRCHvCdH71Z0r3X9MGcrOY2P8WthJTq66FrYFLJsMJEUYbbczF+9SAHSZGB TnNmkxv83D5BOAEszC+fDkN4s7Z7joU9OPQ22adHS6M2Zg48S0qC4enNbM2deLVQ 5DdTtw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ee7yaje58-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 28 May 2026 10:41:00 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-914bd251f5cso632969085a.3 for ; Thu, 28 May 2026 03:41:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779964860; x=1780569660; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Lj1ey6ImyO3i3vMmCJMMvm8iJ4e0EDN26FxKqAvXcRQ=; b=gaasbFqxMm4zK91AVtNjLDyi6abGnjnCPknBuMDwI1XeX9B4gRriydTB63oBxSURzH JX6XufwlDD4xZSXvG7scSzUSStVfBtKGuJkmqEclKVO8IKOn0cUjYhS7jyn8yEZlXECq 8XyMIcLNpvnOyVYmT7StMikEK6qSkAyqfqSOViDZwPn/Vypb9vmQgYHCmJ4j7mMx/1ft MHJ0HckanPaHvkH8N0lRfuoRPdHytfbEFRrw8XNqS3Eqq4N8CONKpPvYSogB5IgtmLrC YgNJ0l7xG0gxCo56KWblsQElgHnyfQtT+hjPJTd4mCTKPMgqFqpOCcOrSNdYPcLrSo7O UDDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779964860; x=1780569660; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Lj1ey6ImyO3i3vMmCJMMvm8iJ4e0EDN26FxKqAvXcRQ=; b=iRr54yGtuHQpYbMWBVJIDD7yYF5E9XCRWZ0EOIHBHNuQ5kJNSS5u4QMmwsOt168E0x 39O4XvLUTv46NwYPTKcxk0o8GnWpxx3LFmm7jC+2iVEdv2U277M5gWvXRehBtJfaHzvL zf94b5iY3zDk7InWTsMcrpjWvloKdPfH4h133HCYCCL6M9c0aj93/AZAMr2Wm+ghjcxd j5xgKkNTYR8ALO3eJo4ruVMussvL45YZCY/dc7h7HdrKzHFQVR4cjV49X1EqzN/sBC8M 2WMy9My0BCrgVHiePqf98yQOBJljs8IG4eoV73QQtmZ/SicGdNdB5LE66f+OILM/vVYs ZdCw== X-Forwarded-Encrypted: i=1; AFNElJ/ISNM9Npvw2vmvOOw9bCvt0goapPHnOSdMqgf6OjrGki3vxz7wEtR52VwxTK3WLK9b/NCJLEB811F34pQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyDtO53Sak2QXqzTj/AWylZxk0pAy7IeOeFjlKsbx8crfOiTh4T 9tnVSEQEg9G4mPu2iTpXysK8JI62bwaWW8Bp2nVaxJK1m954RQTSO+oNqMIy0k4PsC22T4cVXo9 rASMr5WcVqcv7VvqRWGpoQZbRuCkvbb6uu1TnDgLbVtoCa41aN7q9N9EIboHGf/mUgKk= X-Gm-Gg: Acq92OF21P0TfEmcub5ofKD3QNrb/qtZQ8gkrWGej47NRw4FuyVJ34AkwY4Dp7yahaG 44uYTYu7bIWmaJrBGhaXDj0P5YQwKAonUnrlyt0M2u6hbAZxprnPduaLg3xwQ/F5t1SGO4cPhTf vRHViffr3tYQmWGqMYCV8qOA4UHDSvF1Dc3tpAioer6EBW5zrhtM26AB48+mVNdM8KT9qGyn5Kl yZo/WUoJWlzEMDgD9c2Qkjg1d9kjRvmnDHGVnWyNp2Qzjkg1QdhBJzxZOXOV/1toyq7SyPAeodd 51G7imhStLUCH+DMG+A+qWsuqMqdKBED5aBenRxrUN3iigweZa6p9ynb6hBlWsZ8U4RBkWlbUhq XjhTL1riAtqINeAE2VaPY7ehjtmu9mUx74h88iBKdjvPNCUN42tzOr2bwwMp3TAg1THi/bYwv3i zAI4bmaOz+E/YTh4m1Zg== X-Received: by 2002:a05:620a:1995:b0:915:f9d:5c30 with SMTP id af79cd13be357-9150f9d5ec2mr741388685a.58.1779964859959; Thu, 28 May 2026 03:40:59 -0700 (PDT) X-Received: by 2002:a05:620a:1995:b0:915:f9d:5c30 with SMTP id af79cd13be357-9150f9d5ec2mr741384585a.58.1779964859468; Thu, 28 May 2026 03:40:59 -0700 (PDT) Received: from yongmou2.ap.qualcomm.com (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id af79cd13be357-914f86fffddsm755148485a.12.2026.05.28.03.40.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2026 03:40:59 -0700 (PDT) From: Yongxing Mou Date: Thu, 28 May 2026 18:40:26 +0800 Subject: [PATCH v5 05/15] drm/msm/dp: extract MISC1_MISC0 configuration into a separate function Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260528-dp_mstclean-v5-5-a9221c1f1f3b@oss.qualcomm.com> References: <20260528-dp_mstclean-v5-0-a9221c1f1f3b@oss.qualcomm.com> In-Reply-To: <20260528-dp_mstclean-v5-0-a9221c1f1f3b@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou , Dmitry Baryshkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1779964831; l=2097; i=yongxing.mou@oss.qualcomm.com; s=20250910; h=from:subject:message-id; bh=cG/LGNCcQTa4kjEHUBEM5XHcqi1wHebQYuwINqyWaz4=; b=1MPEuzi7QI8Owj0RNyKbbmcyjAce09Crte4j3X2MKDzzDN0sL29ULlXfzr41meYxeD4Fh8RNM dibPlaMG0jOCNpG53r4TT3zajMzZxZrARUj+ezY31VJW91Lsehf7N2a X-Developer-Key: i=yongxing.mou@oss.qualcomm.com; a=ed25519; pk=rAy5J1eP+V7OXqH5FJ7ngMCtUrnHhut30ZTldOj52UM= X-Proofpoint-ORIG-GUID: CRhkgRzdkfkoAnt0MUWSbeAllV07uCcv X-Proofpoint-GUID: CRhkgRzdkfkoAnt0MUWSbeAllV07uCcv X-Authority-Analysis: v=2.4 cv=E/r9Y6dl c=1 sm=1 tr=0 ts=6a181bbc cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=TC1OlXllJ9dbkp4NpB8A:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI4MDEwNiBTYWx0ZWRfX2vXq3/bKc1fg U7NiqdC1kHTq8hEBmJAxdOkpfZYXjeWzCF2T8Hl6vgCemG3/xO5cL0kjZwtfQJyqRJ+IcAeLcOf 9tmWWZMnQdNPRUYXesCuqXpxUZHueAqb07nLDsxtht0Ul0iIINgtovuDGLnakXuw9Vi90PXTO0g t59fzc4fp7gbHDJEOeDAaRtbpBZEioqjArN+wMmf1U+w2xb9j2ATfhk7A4FrmURy05/sTeMR4Ch PFzFXSOQmDYopNAooO9Erkg0ZNnFabLW4toYtOgzRp1Ja3uPqqcocEdtHwFVOY3AiRNG9Mhn8L5 X/a22YzUO7NV0lkydNB78ybzQ6PRhJNWcr6VWaZS+jstOt2VSZfzkIZOBB7GinzmZHgw0/QuaGA WIZzOJeD4Un2IYAxhEr8Nm97VxKcUgu/YW+aj+VshIUYRvP1Lmo+x45rk1sCzIeZLOi3Rx/dTNr My9+sPpZatVJHQ5GuDQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-28_03,2026-05-26_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 adultscore=0 priorityscore=1501 phishscore=0 impostorscore=0 bulkscore=0 malwarescore=0 suspectscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605280106 Refactor the MISC1_MISC0 register configuration into a standalone helper function to support MST. Signed-off-by: Yongxing Mou Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c index cc00e8d2d6c7..d4f48669541a 100644 --- a/drivers/gpu/drm/msm/dp/dp_ctrl.c +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c @@ -459,17 +459,13 @@ static void msm_dp_ctrl_lane_mapping(struct msm_dp_ctrl_private *ctrl) ln_mapping); } -static void msm_dp_ctrl_configure_source_params(struct msm_dp_ctrl_private *ctrl) +static void msm_dp_ctrl_config_misc1_misc0(struct msm_dp_ctrl_private *ctrl, + struct msm_dp_panel *msm_dp_panel) { u32 colorimetry_cfg, test_bits_depth, misc_val; - msm_dp_ctrl_lane_mapping(ctrl); - msm_dp_setup_peripheral_flush(ctrl); - - msm_dp_ctrl_config_ctrl_link(ctrl); - msm_dp_ctrl_config_ctrl_streams(ctrl, ctrl->panel); - - test_bits_depth = msm_dp_link_get_test_bits_depth(ctrl->link, ctrl->panel->msm_dp_mode.bpp); + test_bits_depth = msm_dp_link_get_test_bits_depth(ctrl->link, + msm_dp_panel->msm_dp_mode.bpp); colorimetry_cfg = msm_dp_link_get_colorimetry_config(ctrl->link); misc_val = msm_dp_read_link(ctrl, REG_DP_MISC1_MISC0); @@ -483,6 +479,17 @@ static void msm_dp_ctrl_configure_source_params(struct msm_dp_ctrl_private *ctrl drm_dbg_dp(ctrl->drm_dev, "misc settings = 0x%x\n", misc_val); msm_dp_write_link(ctrl, REG_DP_MISC1_MISC0, misc_val); +} + +static void msm_dp_ctrl_configure_source_params(struct msm_dp_ctrl_private *ctrl) +{ + msm_dp_ctrl_lane_mapping(ctrl); + msm_dp_setup_peripheral_flush(ctrl); + + msm_dp_ctrl_config_ctrl_link(ctrl); + msm_dp_ctrl_config_ctrl_streams(ctrl, ctrl->panel); + + msm_dp_ctrl_config_misc1_misc0(ctrl, ctrl->panel); msm_dp_panel_timing_cfg(ctrl->panel, ctrl->msm_dp_ctrl.wide_bus_en); } -- 2.43.0