From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91E7B3BFAEB for ; Thu, 28 May 2026 10:41:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779964870; cv=none; b=hzpvYSCIWvFz3ScdbZfSd1DYYdKsr1bYsiiOXW5gsDZe7Fm8s9kr3xI5xlNNrLYUO4ris+84Sy2XvF32ocvO8oInCg1yIR26l0c7+9Vp3hqxusV0FpHfsSJKGqFKE+BF6QaJq5jDK45qIhALnAv+XPuxqiecPOt29rrDikK196g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779964870; c=relaxed/simple; bh=S+ko8gfgb1mb/Dv+kOg6axgerBOVHS4WNYhG4rO68xk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Kbs1TnTRZR5mQMMisOptfihSya6mq7Z3CBW2Up8lM5IIKLkzn/26byCekUpTkmghorN7YfT4yql3cjNkYRatIwZEJnisf+f9pPEHW34Sf8nUuMhvvcSVUF1aqPj284de1FVgiJjEuzPrMM+BCR9Y82DuvUZ1Gmr0rifrJgtFxUc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=n1WR8qZt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PlsbdQhN; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="n1WR8qZt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PlsbdQhN" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64S8vVhY3203279 for ; Thu, 28 May 2026 10:41:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7wI6jvNGSR98bo2DUVRgJiWXmNW0I3KbQXB15AxathA=; b=n1WR8qZtX+7708X6 U9e/PjhbdIZgeerGiCZpRpWQ522uL+jlqznwgZBVknNkCcs7D5gWddWppH6tHtgS IsZ4sDRhjCO8oitoX6yJeQ8Q7Mh6yluCyu7PxW8B+9bJEfX4up39rGsXAaLmMTve dlgnmxJ2cgDQwX4i10BfZHr92kJMfysMa+QpEDMScIGnSlFMIieWYT1DPBiKMtDw XRh5Y4V8XLws99eLf07IpDhOnOi4nHOU188TN08aZUs6zJ2OobUoyyAW/W5DUr4J K4GKIVHrpVaRC/9nmkgDmPJ+fAmzwXJYK//EC+XZ6Wr5CUBNe8NX2TYhbHGkvyYQ fmfP6w== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ee7ynje45-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 28 May 2026 10:41:05 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-90fc0ca47f4so1274187785a.3 for ; Thu, 28 May 2026 03:41:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779964865; x=1780569665; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=7wI6jvNGSR98bo2DUVRgJiWXmNW0I3KbQXB15AxathA=; b=PlsbdQhNuGsEZrkp9sOhKE02hQWUlJ0Vb3NqQZFDSyns+EEWl1hQA0qMgVT+5oaIVW V/VKDgQk2uTerP7H8GW4CzFYmA1AykJNUr5jQEVThFrvpEsJv2ltVfcoQiqvjHjAwgPB mkSgDUP5DpgfxLwjW5IyvYCQLncb7pu5oJCPVbkPENBemI6nsRqrrny7ks4DWj3OEJMs NcFneNcRvftK6I2ai4ShlbnxALIKrxgNg5vIDUrBJ2c617iyCqfRRF+J6BV7ndOHi0dH tcdG4Dh3G1wAqyjDejSdx7VET3Ynv6m17QtQOVKT/jzzCt4BATcX6yWBvJYz4LZWJXdq FYtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779964865; x=1780569665; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=7wI6jvNGSR98bo2DUVRgJiWXmNW0I3KbQXB15AxathA=; b=o5e3g9MnhcnJKRSQnW37fx/PIwYJd/nfvwTVICpGxiWmJwIENiva6b9wERMVihxFfy ItUAXor2q0tsC7jFj+FIhb/T174Bqbr3rH3BM3eraRgfHhcbT4HrKwdnz1ahvOnUTFVH 6bW9dBOB3KEiJUX5newMfPJZHD8EA4lQbCEcKpd7uScdZWesa2f22XsrtoU9YmXjIJEq gt4cyjrcHguI/a30AMjdX/HTPZaP4tMue7QsibTkpixlO0LMOO1jCIWE4nmXYf3Ikkbc gCiNoVSV2zPBkzpbXvl/62tG7blo7DvBZJHKvLiJX9hlQ7mPQcJ1+MSDh7AWiHaQ9hqu qBOA== X-Forwarded-Encrypted: i=1; AFNElJ/yG7suNipfZS3rVhgi9kV/kClKXmpTmDnPKVYLvuLYxy8CM/ynIThhzq0ArlAWus0K+H3axaWRElAQB2A=@vger.kernel.org X-Gm-Message-State: AOJu0YzvVv9kh/OWUvr1pUeIuPxeWo9mkZKrcWahgZ7t0paqjw1E1Z84 8uFndKHHmlQWhMD2UMpCyV8XKUjTapHLSpxxd3ldOkKlPENrCQKOio/u9MRP5eaM5jbr9XZQiOg uH4K6vU6ROhxAw8k5knINv7tnGbXZRw/jKXHNHAbVOuuJDy7MGUbtWRwP9Tz0/9sXCRo= X-Gm-Gg: Acq92OEu77Vp0xqRl8l20zkLhB1VYRkO95ZX3gMnxWJok+n13nCepMvyI6UeJCmND3u t8v+Me3rVWEGtTHZxmvkQyUs5uidN/HBxqBnA/WINvUZIQ6XhnfSOgD1Gz541n6Fh9Hbms18Xzw 0JusYjINHNMraRS0aI30o/t158oM0btM2VOulfTVY3wSRLXPtk6/drRpHT1Dw4QQUaPZrympYP+ PFjgzNnCP6q1K6ifEfzQYtcLV/45mv/RR39a8uy4mFaqiju3Qlk//fkg2W4bbZ3rKtE8JWGKDQq 1enkESEZsmNRFB5bRPN27ZozdLCd0d2FWXFgEBWB3NSybwbtDTq9f3vQISnnn8K2U/DYvvGuJaw mZQHezm0eUcCzSfujnTdaTd/q1+3RDfbXRFWrs4Sj57vvAKAizug1hxSQZVvQKFQmoR4CNnIgH8 QyzMiKoiw7l6DgzIl5iA== X-Received: by 2002:a05:620a:448e:b0:914:7b4f:cf6b with SMTP id af79cd13be357-914b49d868cmr3771422485a.44.1779964864638; Thu, 28 May 2026 03:41:04 -0700 (PDT) X-Received: by 2002:a05:620a:448e:b0:914:7b4f:cf6b with SMTP id af79cd13be357-914b49d868cmr3771419485a.44.1779964864203; Thu, 28 May 2026 03:41:04 -0700 (PDT) Received: from yongmou2.ap.qualcomm.com (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id af79cd13be357-914f86fffddsm755148485a.12.2026.05.28.03.40.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2026 03:41:03 -0700 (PDT) From: Yongxing Mou Date: Thu, 28 May 2026 18:40:27 +0800 Subject: [PATCH v5 06/15] drm/msm/dp: split link setup from source params Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260528-dp_mstclean-v5-6-a9221c1f1f3b@oss.qualcomm.com> References: <20260528-dp_mstclean-v5-0-a9221c1f1f3b@oss.qualcomm.com> In-Reply-To: <20260528-dp_mstclean-v5-0-a9221c1f1f3b@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou , Dmitry Baryshkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1779964831; l=1402; i=yongxing.mou@oss.qualcomm.com; s=20250910; h=from:subject:message-id; bh=S+ko8gfgb1mb/Dv+kOg6axgerBOVHS4WNYhG4rO68xk=; b=nj8DZNQBAG8Yv1jLvE8uPR2T+66yfBe2XIg8TCJ0m7qaMRXMPXthbOtz8NdPcHoR5bBRo44OX FXMYyUE+l4qCi2Bi0FgC9yWHqP+bT3ujFg8MSoJZ1JdxEGNxFSHYrLa X-Developer-Key: i=yongxing.mou@oss.qualcomm.com; a=ed25519; pk=rAy5J1eP+V7OXqH5FJ7ngMCtUrnHhut30ZTldOj52UM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI4MDEwNiBTYWx0ZWRfX83p29niQhq58 wkUwKoFS9DLqko3mutUzdVgcL4FNJaG05Z1NObykMyTrDhu2k7+AMp/DkeGZZwo0yjxZsg62m/4 qqF5PR5PLmIAaxNDJk2SLuu7flr1PGbp9yN+7aQg7zysPcqbnNW8J55diAxI8+Qk/JE1eTsMq/F s9siYdkNpHGyFXeylvF3CLA4ux3ZPVjVQnfnPzo8vmDd+4cx5w5VwUnH+wd0NtGt5orhXm7O+NB YO23j4fiBuzJTqk36VB/KBcvkGuv/UsiLyvgZaj8wF1Lvvg4JXqK9ubvLZGe4C/odU46+eufakh N5IJZ+WgL8OfkVqDCJWvCuHo+VZdVGosBjSAhvmlp6/FwSYxjPcuSUDHncfZyTyI/bFKlEtxfHp eYDA/ru2F/x7LGjPGzHkIQ5IdcPfx/9SfLO8Rs4rigHa2HveR8KId3F03qIkIJigG1Yjjiky+eH M6vUzAefmnmv0leuc9A== X-Proofpoint-ORIG-GUID: ftDFcwIeGm890zuivQc9UmcQducHPGI- X-Proofpoint-GUID: ftDFcwIeGm890zuivQc9UmcQducHPGI- X-Authority-Analysis: v=2.4 cv=EdL4hvmC c=1 sm=1 tr=0 ts=6a181bc1 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=saXSvH3Ee-fMY4W8qR0A:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-28_03,2026-05-26_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 phishscore=0 clxscore=1015 bulkscore=0 spamscore=0 adultscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605280106 msm_dp_ctrl_configure_source_params() should only handle stream-related configuration. Move the link setup out of it so MST can program link and stream settings separately. Signed-off-by: Yongxing Mou Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c index d4f48669541a..b22b3a0df313 100644 --- a/drivers/gpu/drm/msm/dp/dp_ctrl.c +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c @@ -483,10 +483,6 @@ static void msm_dp_ctrl_config_misc1_misc0(struct msm_dp_ctrl_private *ctrl, static void msm_dp_ctrl_configure_source_params(struct msm_dp_ctrl_private *ctrl) { - msm_dp_ctrl_lane_mapping(ctrl); - msm_dp_setup_peripheral_flush(ctrl); - - msm_dp_ctrl_config_ctrl_link(ctrl); msm_dp_ctrl_config_ctrl_streams(ctrl, ctrl->panel); msm_dp_ctrl_config_misc1_misc0(ctrl, ctrl->panel); @@ -2552,6 +2548,10 @@ int msm_dp_ctrl_on_stream(struct msm_dp_ctrl *msm_dp_ctrl, bool force_link_train */ reinit_completion(&ctrl->video_comp); + msm_dp_ctrl_lane_mapping(ctrl); + msm_dp_setup_peripheral_flush(ctrl); + msm_dp_ctrl_config_ctrl_link(ctrl); + msm_dp_ctrl_configure_source_params(ctrl); msm_dp_ctrl_config_msa(ctrl, -- 2.43.0