From: Wei Yang <richard.weiyang@gmail.com>
To: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Lorenzo Stoakes <ljs@kernel.org>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Oscar Salvador <osalvador@suse.de>,
Wei Yang <richard.weiyang@gmail.com>,
linux-s390@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mm/page_vma_mapped_walk: Use ptep_get_lockless() for lockless access
Date: Thu, 28 May 2026 09:09:45 +0000 [thread overview]
Message-ID: <20260528090945.xjnj5hmyox7sahhg@master> (raw)
In-Reply-To: <20260528075507.1821939-1-agordeev@linux.ibm.com>
On Thu, May 28, 2026 at 09:55:07AM +0200, Alexander Gordeev wrote:
>Switch from ptep_get() to ptep_get_lockless() accessor for
>PTE reads when no lock is taken.
>
>Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
>---
> mm/page_vma_mapped.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
>diff --git a/mm/page_vma_mapped.c b/mm/page_vma_mapped.c
>index a4d52fdb3056..2ccbabfb2cc1 100644
>--- a/mm/page_vma_mapped.c
>+++ b/mm/page_vma_mapped.c
>@@ -41,7 +41,7 @@ static bool map_pte(struct page_vma_mapped_walk *pvmw, pmd_t *pmdvalp,
> if (!pvmw->pte)
> return false;
>
>- ptent = ptep_get(pvmw->pte);
>+ ptent = ptep_get_lockless(pvmw->pte);
>
> if (pte_none(ptent)) {
> return false;
>@@ -183,6 +183,7 @@ bool page_vma_mapped_walk(struct page_vma_mapped_walk *pvmw)
> struct mm_struct *mm = vma->vm_mm;
> unsigned long end;
> spinlock_t *ptl;
>+ pte_t pteval;
> pgd_t *pgd;
> p4d_t *p4d;
> pud_t *pud;
>@@ -310,7 +311,11 @@ bool page_vma_mapped_walk(struct page_vma_mapped_walk *pvmw)
> goto restart;
> }
> pvmw->pte++;
>- } while (pte_none(ptep_get(pvmw->pte)));
>+ if (!pvmw->ptl)
>+ pteval = ptep_get_lockless(pvmw->pte);
>+ else
>+ pteval = ptep_get(pvmw->pte);
>+ } while (pte_none(pteval));
Use ptep_get_lockless() when lock is not taken.
LGTM, thanks
Reviewed-by: Wei Yang <richard.weiyang@gmail.com>
>
> if (!pvmw->ptl) {
> spin_lock(ptl);
>--
>2.51.0
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2026-05-28 9:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 7:55 Alexander Gordeev
2026-05-28 9:09 ` Wei Yang [this message]
2026-05-28 11:24 ` Lorenzo Stoakes
2026-05-28 14:14 ` Oscar Salvador (SUSE)
2026-05-28 14:30 ` Alexander Gordeev
2026-06-01 9:36 ` Lorenzo Stoakes
2026-05-29 17:34 ` Oscar Salvador (SUSE)
2026-06-01 12:10 ` David Hildenbrand (Arm)
2026-06-01 12:15 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260528090945.xjnj5hmyox7sahhg@master \
--to=richard.weiyang@gmail.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=ljs@kernel.org \
--cc=osalvador@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®