From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A6333E3C76 for ; Thu, 28 May 2026 13:09:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779973783; cv=none; b=Q1Yfkk1D8ZsOKcbcyLE72MSQjG7nTwB5al67OQ+P/ZZSD14yby5l6HNZxHKaf5Gl67hBpF14erJMcHx9PG+L9u86l7dpuDOdUQ6TPOusxkq0zL5CzSbRpzNZntuNU8hbSpQd4G8RIaQ8/wiSsRAP8WfYgVODBrt/dFuzxnXT0zI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779973783; c=relaxed/simple; bh=n4HVP6oE85/rJA1fLV+SQPFp877w/RCZuh8W1eNyI9A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AQVlLLVZb92QPt/mIEDVxus8SWVAYGMmipXqxXgLAYA/R64HPYg3TT25OFAYCDBRgUeo2Jsbdez5+swtaxMCTXJ2Z5AFF0WCUkybdglwAAU9SNzgrD/AKSNDFz7w+AVWp/4tX64C/1YNUaL0mc1oTjrRXHUrqmOFw21aLMJaydI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=Y5ItgSzD; arc=none smtp.client-ip=209.85.222.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="Y5ItgSzD" Received: by mail-qk1-f179.google.com with SMTP id af79cd13be357-914bb8e95c2so348159285a.1 for ; Thu, 28 May 2026 06:09:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1779973781; x=1780578581; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=n4HVP6oE85/rJA1fLV+SQPFp877w/RCZuh8W1eNyI9A=; b=Y5ItgSzDCxb6xRYv+yahy4VHAOILuRZsviVEyLbU6Sc1Szm+SZO2A8O6EQG2+g//+v lPLwMBtoT3LhlMVmJrMNT5+2O6H0U5HDrnKM/DvA2BbAP2O39buMt1KlIrVTV0JMvBCT XX1/czD8lqBHK9xMo9K6hSsF63l04N1C47JBU3ztMp64unCEMAPuA3vo+sirpBZng7om te+69mrAoehJ0kWLd57SMZQBmvyfemkNnGeO3WUShU5DtwumZitzZLrfV620CNPt6Sy8 yotb7ZrXDQ7G5JU6UpWcvTVsXoUL2nkx2nlMdKp3rFnyRvECwTJ1HYtPGCc32/6Ta63V 4AIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779973781; x=1780578581; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n4HVP6oE85/rJA1fLV+SQPFp877w/RCZuh8W1eNyI9A=; b=sQBo9+Zu8c0PVsiLODKQzs9O+JPHKtF8I/zT/ClX06dbAjR4TO/cwseQP/W8C+cnot SYxzuHqsN0bQWD7wwRGLgC67nqjhld/V4xJQg8JassArrImro8j67Q9GE9JhrzoCgnMW YVYGcDKtqeb8eTZ5b60TCOT4CLq/K2eQFivOqmG98zMeWV5+cQE9mTbRxxAeOkl8odA0 1SJ8f0hK2xR21fJLR8ZwgPWSPXvFuq83pmG3GwD3n1ARyWMKb+i+c4PFGP551pdxX2I3 TBXU7vxhwq/n+q6wUzV3kj6wAG4F9Iv8rpZS0AlXlRC/soctyEFkutD+uYrgdVUfmbxA FE7Q== X-Forwarded-Encrypted: i=1; AFNElJ+9S9X8UeVxqFaMUdjLpnOvvMO5AMxEwFwCTkBo0D9lsoBcA05nzacxdkkmGQlEuv5nD0BfQXrmQcZh3Ek=@vger.kernel.org X-Gm-Message-State: AOJu0Yyezq1QPdvN0TDNNpi0MfbM+WyJWq17Np+6pblVta/+xUe4XYNB O9TZpk3qm2CCiR2jZ9qRs1Rm0/3aZd01UnRFe6WIXGG4KO1ZSsJW19tYbkb2odXWaF9xsyuzu2r X4ZLF X-Gm-Gg: Acq92OFM3SSfY+52bvlZA8d6148gxknxPqC5rNIFg6/bRY6RyK/dsVwm56znmn94Zs8 wFi9cxPp6klN/UQ6IVssbg0ylrCl9ezpxDp5npof/iPxN4vExsXR/pQ8RaYLYpaHGIxKCHF3v1z nyGXOTqeiNVX1kKtYaFjj/Ac1W7X8F5pz7ClBFS3OS2ICqd85I8Jyak79GVcqmn2dJOZ88PWfrO hBgee/KQUa7rSGCS51ftdqj6T3HU2pmiUls9N0OyoZm+Ng+TEuxflBZe/skPhVhOE5/SdppilU0 +Q8YGsVLxBeFtw3XsZYSxdA4kAyxN7rrz7slzBAzOITYHaUYfilVs0afUvBajL7kD0gvmkmJwjR JKH/aqlKTnB2r5tmhHTToQmWgZlATqZCsKyluc6LCL+ec+hJ+fCSVT6qXql9qZicOCJaScngDca dA4U9NwqOX4xIIVVPZPaamWNZaOsMYKHtTw7lhiH83n5ND4uRS5v9dEdnBBjMZPS5IJX1lri9bA cBH1KAcOTM4Mnj5lDlg09aiIt4= X-Received: by 2002:a05:620a:390a:b0:914:daf0:d982 with SMTP id af79cd13be357-914daf0dfbamr2666909585a.13.1779973780875; Thu, 28 May 2026 06:09:40 -0700 (PDT) Received: from ziepe.ca (crbknf0213w-47-54-130-67.pppoe-dynamic.high-speed.nl.bellaliant.net. [47.54.130.67]) by smtp.gmail.com with ESMTPSA id af79cd13be357-914f8810a50sm828419385a.41.2026.05.28.06.09.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2026 06:09:40 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wSaUV-0000000GYFj-3U47; Thu, 28 May 2026 10:09:39 -0300 Date: Thu, 28 May 2026 10:09:39 -0300 From: Jason Gunthorpe To: luoqing Cc: kees@kernel.org, leon@kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, luoqing@kylinos.cn, markzhang@nvidia.com Subject: Re: [PATCH] rdma: infiniband: Added __alloc_cq request value Return value non-zero value determination Message-ID: <20260528130939.GP2487554@ziepe.ca> References: <20260526122329.GC2487554@ziepe.ca> <20260528065435.1269299-1-l1138897701@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260528065435.1269299-1-l1138897701@163.com> On Thu, May 28, 2026 at 02:54:35PM +0800, luoqing wrote: > Although this is fundamentally a driver registration issue (drivers > should specify correct sizes), adding an extra defensive check in > __ib_alloc_cq() — like ZERO_OR_NULL_PTR(cq) — would: Then check the driver specified the right sizes when it registered. But I don't see much value in this avenue, drivers won't work at all if they are so severely buggy. This entire conversation is pure AI slop, please stop. Jason