Re: [PATCH 1/2] selftests/damon: fix DamosFilter memcg_path assignment

[SeongJae Park <sj@kernel.org>]

Hello nicheng,


Could you please update the subject to 'selftets/ddamon/_damon_sysfs.py'?

On Thu, 28 May 2026 16:10:38 +0800 niecheng <niecheng1@uniontech.com> wrote:

> DamosFilter stores memcg_path for sysfs staging, but the constructor
> assigns it with a trailing comma and therefore turns it into a tuple.

Nice catch!

> 
> Fix the assignment so memcg_path is stored as the intended string.
> This makes memcg filter staging and follow-up validation use the
> written path correctly.
> 
> Signed-off-by: niecheng <niecheng1@uniontech.com>

From the git log, I found it seems you also use 'Cheng Nie' as your name.  Are
you intentionally use 'niecheng' as your identity?  We disallow anonymous but
allow using known identity, so I'm just checking if this is an unintended
mistake.  Some of us (mm community) prefer real name, though.

> ---
>  tools/testing/selftests/damon/_damon_sysfs.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/damon/_damon_sysfs.py b/tools/testing/selftests/damon/_damon_sysfs.py
> index 2b4df655d9fd..022f0d392204 100644
> --- a/tools/testing/selftests/damon/_damon_sysfs.py
> +++ b/tools/testing/selftests/damon/_damon_sysfs.py
> @@ -254,7 +254,7 @@ class DamosFilter:
>          self.type_ = type_
>          self.matching = matching
>          self.allow = allow
> -        self.memcg_path = memcg_path,
> +        self.memcg_path = memcg_path
>          self.addr_start = addr_start
>          self.addr_end = addr_end
>          self.target_idx = target_idx
> -- 
> 2.51.0


The change looks good!


Thanks,
SJ