mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Ashwin Gundarapu <linuxuser509@zohomail.in>,
	tglx <tglx@kernel.org>, mingo <mingo@redhat.com>,
	bp <bp@alien8.de>, hpa <hpa@zytor.com>, x86 <x86@kernel.org>,
	"dave.hansen" <dave.hansen@linux.intel.com>
Cc: oe-kbuild-all@lists.linux.dev,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] x86/vm86: Remove deprecated VM86 support
Date: Thu, 28 May 2026 17:44:48 +0800	[thread overview]
Message-ID: <202605281749.4b3Hss7l-lkp@intel.com> (raw)
In-Reply-To: <19e6858d9db.3a90532342003.5043853571553507480@zohomail.in>

Hi Ashwin,

kernel test robot noticed the following build errors:

[auto build test ERROR on v7.1-rc5]
[also build test ERROR on linus/master next-20260527]
[cannot apply to tip/x86/core]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ashwin-Gundarapu/x86-vm86-Remove-deprecated-VM86-support/20260527-153401
base:   v7.1-rc5
patch link:    https://lore.kernel.org/r/19e6858d9db.3a90532342003.5043853571553507480%40zohomail.in
patch subject: [PATCH v2] x86/vm86: Remove deprecated VM86 support
config: i386-allnoconfig (https://download.01.org/0day-ci/archive/20260528/202605281749.4b3Hss7l-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260528/202605281749.4b3Hss7l-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202605281749.4b3Hss7l-lkp@intel.com/

All errors (new ones prefixed by >>):

   arch/x86/lib/insn-eval.c: In function 'get_segment_selector':
>> arch/x86/lib/insn-eval.c:380:40: error: invalid use of undefined type 'struct kernel_vm86_regs'
     380 |                         return vm86regs->ds;
         |                                        ^~
   arch/x86/lib/insn-eval.c:382:40: error: invalid use of undefined type 'struct kernel_vm86_regs'
     382 |                         return vm86regs->es;
         |                                        ^~
   arch/x86/lib/insn-eval.c:384:40: error: invalid use of undefined type 'struct kernel_vm86_regs'
     384 |                         return vm86regs->fs;
         |                                        ^~
   arch/x86/lib/insn-eval.c:386:40: error: invalid use of undefined type 'struct kernel_vm86_regs'
     386 |                         return vm86regs->gs;
         |                                        ^~
--
   arch/x86/kernel/process_32.c: In function 'release_thread':
>> arch/x86/kernel/process_32.c:108:9: error: implicit declaration of function 'release_vm86_irqs' [-Wimplicit-function-declaration]
     108 |         release_vm86_irqs(dead_task);
         |         ^~~~~~~~~~~~~~~~~
--
   arch/x86/kernel/signal.c: In function 'handle_signal':
>> arch/x86/kernel/signal.c:261:17: error: implicit declaration of function 'save_v86_state' [-Wimplicit-function-declaration]
     261 |                 save_v86_state((struct kernel_vm86_regs *) regs, VM86_SIGNAL);
         |                 ^~~~~~~~~~~~~~
--
   arch/x86/kernel/traps.c: In function 'do_trap_no_signal':
>> arch/x86/kernel/traps.c:289:30: error: implicit declaration of function 'handle_vm86_trap' [-Wimplicit-function-declaration]
     289 |                         if (!handle_vm86_trap((struct kernel_vm86_regs *) regs,
         |                              ^~~~~~~~~~~~~~~~
   arch/x86/kernel/traps.c: In function '__exc_general_protection':
>> arch/x86/kernel/traps.c:927:17: error: implicit declaration of function 'handle_vm86_fault'; did you mean 'handle_mm_fault'? [-Wimplicit-function-declaration]
     927 |                 handle_vm86_fault((struct kernel_vm86_regs *) regs, error_code);
         |                 ^~~~~~~~~~~~~~~~~
         |                 handle_mm_fault


vim +380 arch/x86/lib/insn-eval.c

32d0b95300db03 Ricardo Neri 2017-10-27  323  
32d0b95300db03 Ricardo Neri 2017-10-27  324  /**
32d0b95300db03 Ricardo Neri 2017-10-27  325   * get_segment_selector() - obtain segment selector
32d0b95300db03 Ricardo Neri 2017-10-27  326   * @regs:		Register values as seen when entering kernel mode
32d0b95300db03 Ricardo Neri 2017-10-27  327   * @seg_reg_idx:	Segment register index to use
32d0b95300db03 Ricardo Neri 2017-10-27  328   *
32d0b95300db03 Ricardo Neri 2017-10-27  329   * Obtain the segment selector from any of the CS, SS, DS, ES, FS, GS segment
32d0b95300db03 Ricardo Neri 2017-10-27  330   * registers. In CONFIG_X86_32, the segment is obtained from either pt_regs or
32d0b95300db03 Ricardo Neri 2017-10-27  331   * kernel_vm86_regs as applicable. In CONFIG_X86_64, CS and SS are obtained
32d0b95300db03 Ricardo Neri 2017-10-27  332   * from pt_regs. DS, ES, FS and GS are obtained by reading the actual CPU
32d0b95300db03 Ricardo Neri 2017-10-27  333   * registers. This done for only for completeness as in CONFIG_X86_64 segment
32d0b95300db03 Ricardo Neri 2017-10-27  334   * registers are ignored.
32d0b95300db03 Ricardo Neri 2017-10-27  335   *
32d0b95300db03 Ricardo Neri 2017-10-27  336   * Returns:
32d0b95300db03 Ricardo Neri 2017-10-27  337   *
32d0b95300db03 Ricardo Neri 2017-10-27  338   * Value of the segment selector, including null when running in
32d0b95300db03 Ricardo Neri 2017-10-27  339   * long mode.
32d0b95300db03 Ricardo Neri 2017-10-27  340   *
32d0b95300db03 Ricardo Neri 2017-10-27  341   * -EINVAL on error.
32d0b95300db03 Ricardo Neri 2017-10-27  342   */
32d0b95300db03 Ricardo Neri 2017-10-27  343  static short get_segment_selector(struct pt_regs *regs, int seg_reg_idx)
32d0b95300db03 Ricardo Neri 2017-10-27  344  {
32d0b95300db03 Ricardo Neri 2017-10-27  345  	unsigned short sel;
32d0b95300db03 Ricardo Neri 2017-10-27  346  
3a24a60854d2ef Brian Gerst  2022-03-25  347  #ifdef CONFIG_X86_64
32d0b95300db03 Ricardo Neri 2017-10-27  348  	switch (seg_reg_idx) {
32d0b95300db03 Ricardo Neri 2017-10-27  349  	case INAT_SEG_REG_IGNORE:
32d0b95300db03 Ricardo Neri 2017-10-27  350  		return 0;
32d0b95300db03 Ricardo Neri 2017-10-27  351  	case INAT_SEG_REG_CS:
32d0b95300db03 Ricardo Neri 2017-10-27  352  		return (unsigned short)(regs->cs & 0xffff);
32d0b95300db03 Ricardo Neri 2017-10-27  353  	case INAT_SEG_REG_SS:
32d0b95300db03 Ricardo Neri 2017-10-27  354  		return (unsigned short)(regs->ss & 0xffff);
32d0b95300db03 Ricardo Neri 2017-10-27  355  	case INAT_SEG_REG_DS:
32d0b95300db03 Ricardo Neri 2017-10-27  356  		savesegment(ds, sel);
32d0b95300db03 Ricardo Neri 2017-10-27  357  		return sel;
32d0b95300db03 Ricardo Neri 2017-10-27  358  	case INAT_SEG_REG_ES:
32d0b95300db03 Ricardo Neri 2017-10-27  359  		savesegment(es, sel);
32d0b95300db03 Ricardo Neri 2017-10-27  360  		return sel;
32d0b95300db03 Ricardo Neri 2017-10-27  361  	case INAT_SEG_REG_FS:
32d0b95300db03 Ricardo Neri 2017-10-27  362  		savesegment(fs, sel);
32d0b95300db03 Ricardo Neri 2017-10-27  363  		return sel;
32d0b95300db03 Ricardo Neri 2017-10-27  364  	case INAT_SEG_REG_GS:
32d0b95300db03 Ricardo Neri 2017-10-27  365  		savesegment(gs, sel);
32d0b95300db03 Ricardo Neri 2017-10-27  366  		return sel;
32d0b95300db03 Ricardo Neri 2017-10-27  367  	default:
32d0b95300db03 Ricardo Neri 2017-10-27  368  		return -EINVAL;
32d0b95300db03 Ricardo Neri 2017-10-27  369  	}
32d0b95300db03 Ricardo Neri 2017-10-27  370  #else /* CONFIG_X86_32 */
32d0b95300db03 Ricardo Neri 2017-10-27  371  	struct kernel_vm86_regs *vm86regs = (struct kernel_vm86_regs *)regs;
32d0b95300db03 Ricardo Neri 2017-10-27  372  
32d0b95300db03 Ricardo Neri 2017-10-27  373  	if (v8086_mode(regs)) {
32d0b95300db03 Ricardo Neri 2017-10-27  374  		switch (seg_reg_idx) {
32d0b95300db03 Ricardo Neri 2017-10-27  375  		case INAT_SEG_REG_CS:
32d0b95300db03 Ricardo Neri 2017-10-27  376  			return (unsigned short)(regs->cs & 0xffff);
32d0b95300db03 Ricardo Neri 2017-10-27  377  		case INAT_SEG_REG_SS:
32d0b95300db03 Ricardo Neri 2017-10-27  378  			return (unsigned short)(regs->ss & 0xffff);
32d0b95300db03 Ricardo Neri 2017-10-27  379  		case INAT_SEG_REG_DS:
32d0b95300db03 Ricardo Neri 2017-10-27 @380  			return vm86regs->ds;
32d0b95300db03 Ricardo Neri 2017-10-27  381  		case INAT_SEG_REG_ES:
32d0b95300db03 Ricardo Neri 2017-10-27  382  			return vm86regs->es;
32d0b95300db03 Ricardo Neri 2017-10-27  383  		case INAT_SEG_REG_FS:
32d0b95300db03 Ricardo Neri 2017-10-27  384  			return vm86regs->fs;
32d0b95300db03 Ricardo Neri 2017-10-27  385  		case INAT_SEG_REG_GS:
32d0b95300db03 Ricardo Neri 2017-10-27  386  			return vm86regs->gs;
32d0b95300db03 Ricardo Neri 2017-10-27  387  		case INAT_SEG_REG_IGNORE:
32d0b95300db03 Ricardo Neri 2017-10-27  388  		default:
32d0b95300db03 Ricardo Neri 2017-10-27  389  			return -EINVAL;
32d0b95300db03 Ricardo Neri 2017-10-27  390  		}
32d0b95300db03 Ricardo Neri 2017-10-27  391  	}
32d0b95300db03 Ricardo Neri 2017-10-27  392  
32d0b95300db03 Ricardo Neri 2017-10-27  393  	switch (seg_reg_idx) {
32d0b95300db03 Ricardo Neri 2017-10-27  394  	case INAT_SEG_REG_CS:
32d0b95300db03 Ricardo Neri 2017-10-27  395  		return (unsigned short)(regs->cs & 0xffff);
32d0b95300db03 Ricardo Neri 2017-10-27  396  	case INAT_SEG_REG_SS:
32d0b95300db03 Ricardo Neri 2017-10-27  397  		return (unsigned short)(regs->ss & 0xffff);
32d0b95300db03 Ricardo Neri 2017-10-27  398  	case INAT_SEG_REG_DS:
32d0b95300db03 Ricardo Neri 2017-10-27  399  		return (unsigned short)(regs->ds & 0xffff);
32d0b95300db03 Ricardo Neri 2017-10-27  400  	case INAT_SEG_REG_ES:
32d0b95300db03 Ricardo Neri 2017-10-27  401  		return (unsigned short)(regs->es & 0xffff);
32d0b95300db03 Ricardo Neri 2017-10-27  402  	case INAT_SEG_REG_FS:
32d0b95300db03 Ricardo Neri 2017-10-27  403  		return (unsigned short)(regs->fs & 0xffff);
32d0b95300db03 Ricardo Neri 2017-10-27  404  	case INAT_SEG_REG_GS:
3a24a60854d2ef Brian Gerst  2022-03-25  405  		savesegment(gs, sel);
3a24a60854d2ef Brian Gerst  2022-03-25  406  		return sel;
32d0b95300db03 Ricardo Neri 2017-10-27  407  	case INAT_SEG_REG_IGNORE:
32d0b95300db03 Ricardo Neri 2017-10-27  408  	default:
32d0b95300db03 Ricardo Neri 2017-10-27  409  		return -EINVAL;
32d0b95300db03 Ricardo Neri 2017-10-27  410  	}
32d0b95300db03 Ricardo Neri 2017-10-27  411  #endif /* CONFIG_X86_64 */
32d0b95300db03 Ricardo Neri 2017-10-27  412  }
32d0b95300db03 Ricardo Neri 2017-10-27  413  

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  parent reply	other threads:[~2026-05-28  9:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-27  7:31 Ashwin Gundarapu
2026-05-28  9:44 ` kernel test robot
2026-05-28  9:44 ` kernel test robot [this message]
2026-05-30 16:26 ` Brian Gerst
2026-05-28  7:49 Jari Ruusu
2026-05-28  8:40 ` Ashwin Gundarapu
2026-05-28 14:06 ` Dave Hansen
2026-05-29  5:20   ` Jari Ruusu
2026-05-29 12:05     ` Brian Gerst
2026-05-29 14:26     ` Dave Hansen
2026-05-30  5:49       ` Jari Ruusu
2026-05-30  6:52         ` H. Peter Anvin
2026-05-30 16:13         ` Brian Gerst
2026-05-31  6:04           ` Jari Ruusu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202605281749.4b3Hss7l-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxuser509@zohomail.in \
    --cc=mingo@redhat.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®