From: Dominique Belhachemi <domibel@debian.org>
To: Andy Yan <andy.yan@rock-chips.com>, dri-devel@lists.freedesktop.org
Cc: Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH v1] drm/bridge: inno-hdmi: reset DDC segment pointer per I2C transfer
Date: Thu, 28 May 2026 18:41:45 +0000 [thread overview]
Message-ID: <20260528184145.384114-1-domibel@debian.org> (raw)
The segment_addr and ddc_addr fields need to be reset per I2C transfer
to avoid stale values. The reset wasn't required on simple displays with
only one segment, but modern displays with two or more segments end up
with corrupt EDIDs.
This was found on a StarFive VisionFive 2 SBC.
Signed-off-by: Dominique Belhachemi <domibel@debian.org>
---
drivers/gpu/drm/bridge/inno-hdmi.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/bridge/inno-hdmi.c b/drivers/gpu/drm/bridge/inno-hdmi.c
index 5fa533a4eb342..297be02bbd58d 100644
--- a/drivers/gpu/drm/bridge/inno-hdmi.c
+++ b/drivers/gpu/drm/bridge/inno-hdmi.c
@@ -989,6 +989,10 @@ static int inno_hdmi_i2c_xfer(struct i2c_adapter *adap,
mutex_lock(&i2c->lock);
+ /* Reset segment_addr and ddc_addr at the start of every I2C transfer */
+ i2c->ddc_addr = 0;
+ i2c->segment_addr = 0;
+
/* Clear the EDID interrupt flag and unmute the interrupt */
hdmi_writeb(hdmi, HDMI_INTERRUPT_MASK1, m_INT_EDID_READY);
hdmi_writeb(hdmi, HDMI_INTERRUPT_STATUS1, m_INT_EDID_READY);
--
2.53.0
next reply other threads:[~2026-05-28 18:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 18:41 Dominique Belhachemi [this message]
2026-07-10 18:40 ` Dominique Belhachemi
[not found] ` <CGME20260927085152eucas1p274e0c4d85641cbbc5e727b4b559d21cf@eucas1p2.samsung.com>
2026-09-27 8:51 ` Michal Wilczynski
[not found] ` <CGME20260928111522eucas1p1e9b3945eacb52abe425272ebca524d8f@eucas1p1.samsung.com>
2026-09-28 11:15 ` Michal Wilczynski
2026-09-28 22:01 ` Dominique Belhachemi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260528184145.384114-1-domibel@debian.org \
--to=domibel@debian.org \
--cc=andrzej.hajda@intel.com \
--cc=andy.yan@rock-chips.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®