From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27ED01DD877 for ; Fri, 29 May 2026 13:15:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780060532; cv=none; b=ODI+tuaKS5TNshmadLTjFwALvirtGf7h0r+vKe2DVey7gNuURf9+wiW4uw+VyBLlRn8PZJc9oWItVWFgrnxkDt88ZKHQpa7cv+mTACflqzFk8DoIFsepVJYo0GPtXp4X7Ib6j8l/jV33Jda5I/80Q+PmvOndtsEgMPRn+UWV8jg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780060532; c=relaxed/simple; bh=WMDFjbQ1IsgxxBmTUVMs5PZRTemd28Shd5aoPXAI/tg=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=Rk4CtzZTQHEvmJ8NkIgbL57DeRwtYcrVo5FZwfjLzrA0ajTnqGKcwNkf0aH4cpX3YnG36ZaSxtxDJtDlq2hXu8xerz8FO0Cq6GxQbx3plRgBTDPx0GtHcCtRnG4xN5LRiglUEGKGlnzTM0iKYLqOTZSNsjFv+DYV5NZo3lNd9us= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eZujMBiT; arc=none smtp.client-ip=209.85.210.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eZujMBiT" Received: by mail-ot1-f53.google.com with SMTP id 46e09a7af769-7dd73b7c757so6468177a34.0 for ; Fri, 29 May 2026 06:15:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780060529; x=1780665329; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=8U27PrRBYOTBggCy2kOuybL8Sqy0L0L2agZLGzQ4W+8=; b=eZujMBiTZeALWjDcVzqJJahwU3o9YhoBh3aOYfKJeB0Mvp4URKTYsZYWJtbDMiFY+O 2jJuMPExHTIlZetb2p6Ko3n9eMNp14SvEaNoYbnnNAAFHYRHYWXCeOLyN4P9WBrWDDs6 NPffLTUyj+D8Pp7O4r0iBMobLCeKFFsQ3E0eXW9kTRw9fSBWJF9HoChFxRMdB0cuvxwi /Z13uCp5NjWMYZSY6gisQ5s30yr/igZpuVftolpJC2pn12/2F6VafNbSBIIBDtyxAA6Z na8AOBZ2IpbIzURK3C301o4D6VLjXwXma/4PzNIzM8JAqy21jfzI6PaTpaviBnka9vD2 p3dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780060529; x=1780665329; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8U27PrRBYOTBggCy2kOuybL8Sqy0L0L2agZLGzQ4W+8=; b=bQODpplmV7O+uN5Qi7cxJypDD5vmoADPpiOh+ZBT1lfRlCQlYdi43Kb4aGAIcMib0A LIWmz/wC97O/wf+7HPxrHHDrZgDLuAVPp4ZWKYJsNfe1hA7pqDT+pf6Pg9aWnbWb+o/i iEo2HVrqfrvwX4MlgyRPfkg82Rp3L8QyYX+EjOw7ZJPngECzACHm0CFx2Px3J7xnjjRf 4/rmcEjkSFxDIUpSVgqqAnPJWvFEOrIEhVF1RABBuIrxqMBvuQWFv0b+FheVqQhvGx+1 +POy9Dr35YShUIdvKxMYuCw7kC0NweCtwlH1/0EQH3AxWN08jaEY3lvwwvPZ2H7LR5bF JP/A== X-Forwarded-Encrypted: i=1; AFNElJ8sP0nA7ds6KHI/nyW0AKyrvN2DYjpL0me2D3bp0GRU0QwQXHsoyxSPTGL2MFlT0qO/+onESQ1dze9M+io=@vger.kernel.org X-Gm-Message-State: AOJu0YxIA+JhSqoiJ3fqDuQFyGISXS+2GvH6+0Iz0UjFr8GT7xyCKIX0 MH8gVrRBL6I7AXuv/RJRf7ta8KXR/Y44YTfHBhSodAsGSRBhWLIu0nS+ X-Gm-Gg: Acq92OHpVmXm4h0NAvc0CRPlnm5yvZ35aJ05ILlAy68i5ex+gOGZGg7poBxzepYrmSQ SCY0m5B6ikd4LVJkPAYUgSOWWLrDjjsyBl/nlCxJqCfpDRFpAMM2CI3QYPnniXKJXCXFaA3ooDy 5tXbkHBoB61NDFdTmKHTuWOMiyS3C1OOPJ9SlKSOOlIXVPeSd0Dwc1w80vLogNFeH9P2fLDohL0 ZcYn/XH0Ardh7/MTxHZ5IpxszUQkSTheom3t8p6jrddkAb6ckpjVSH2G0yzamxGfVaL9TEpMGBI opBxgy77YY8gCvLcJbNyXB9+6P8d+DhgDLXRmpIrEjLnca1aj1un28fwmN+y/RUcQxtfinq3ZmA BJb3UKh7LNYeNYjdcsRwFioPqTqkJ2V621sieeqJULznYJOaoV6udg7wX8oN17w9uRLeJVdIPUy t78oZn8uW6TtCyCLpD2f/LPy0prC+dAqY= X-Received: by 2002:a05:6830:3748:b0:7dd:5a21:2246 with SMTP id 46e09a7af769-7e694e5c7b3mr1858386a34.25.1780060529098; Fri, 29 May 2026 06:15:29 -0700 (PDT) Received: from localhost ([2a03:2880:10ff:42::]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7e695d69b20sm1407562a34.22.2026.05.29.06.15.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2026 06:15:28 -0700 (PDT) From: Daniel Zahka Subject: [PATCH net v2 0/2] netdevsim: psp: fix issues with stats collection Date: Fri, 29 May 2026 06:15:26 -0700 Message-Id: <20260529-fix-psp-stats-v2-0-3a194eacf18e@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAG+RGWoC/12NywrCMBBFf6XM2pEktZG68j+ki5pM2wH7IBOKU vLvhuDK5X2de4BQYBK4VQcE2ll4XbIwpwrc1C8jIfuswShjVaMNDvzGTTaU2EdBaq2zXtnWKw1 5swXKhcJ7wEIRumxOLHENn/Kx6xL9cPUfbteo0Plnra+XwTRmuI9zz6+zW2foUkpfnfWToa8AA AA= To: Jakub Kicinski , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.13.0 It has come to my attention via a sashiko review of my net-next series for aes-gcm in netdevsim [1] that there were preexisting issues with netdevsim's implementation of psp statistics. API usage issues: 1. not calling u64_stats_init() on the u64_stats_sync object during init 2. not serializing usage of the writer side API during stats update Logical Bugs: 1. We were incrementing rx stats on the sending devices stats counters. Fix the first set of issues by removing the u64_stats_t api entirely, and keep track of stats with atomics. Fix the second issue by charging events to the right netdevsim object. [1]: https://sashiko.dev/#/patchset/20260508-nsim-psp-crypto-v1-0-4b50ed09b794%40gmail.com TAP version 13 1..28 ok 1 psp.data_basic_send_v0_ip4 ok 2 psp.data_basic_send_v0_ip6 ok 3 psp.data_basic_send_v1_ip4 ok 4 psp.data_basic_send_v1_ip6 ok 5 psp.data_basic_send_v2_ip4 ok 6 psp.data_basic_send_v2_ip6 ok 7 psp.data_basic_send_v3_ip4 ok 8 psp.data_basic_send_v3_ip6 ok 9 psp.data_mss_adjust_ip4 ok 10 psp.data_mss_adjust_ip6 ok 11 psp.dev_list_devices ok 12 psp.dev_get_device ok 13 psp.dev_get_device_bad ok 14 psp.dev_rotate ok 15 psp.dev_rotate_spi ok 16 psp.assoc_basic ok 17 psp.assoc_bad_dev ok 18 psp.assoc_sk_only_conn ok 19 psp.assoc_sk_only_mismatch ok 20 psp.assoc_sk_only_mismatch_tx ok 21 psp.assoc_sk_only_unconn ok 22 psp.assoc_version_mismatch ok 23 psp.assoc_twice ok 24 psp.data_send_bad_key ok 25 psp.data_send_disconnect ok 26 psp.data_stale_key ok 27 psp.removal_device_rx ok 28 psp.removal_device_bi # Totals: pass:28 fail:0 xfail:0 xpass:0 skip:0 error:0 Dump stats on both devs tx on one should match rx on other: local dev: id=5 ifindex=2 stats={'dev-id': 5, 'key-rotations': 0, 'stale-events': 0, 'rx-packets': 1226, 'rx-bytes': 39244, 'rx-auth-fail': 0, 'rx-error': 0, 'rx-bad': 0, 'tx-packets': 1931, 'tx-bytes': 2478908, 'tx-error': 0} remote dev: id=3 ifindex=2 stats={'dev-id': 3, 'key-rotations': 0, 'stale-events': 0, 'rx-packets': 1931, 'rx-bytes': 2478908, 'rx-auth-fail': 0, 'rx-error': 0, 'rx-bad': 0, 'tx-packets': 1226, 'tx-bytes': 39244, 'tx-error': 0} Signed-off-by: Daniel Zahka --- Changes in v2: - get rid of u64_stats_t and use atomics instead - Link to v1: https://lore.kernel.org/r/20260513-fix-psp-stats-v1-0-cdb3174f252f@gmail.com --- Daniel Zahka (2): netdevsim: psp: update rx stats on the peer netdevsim netdevsim: psp: use atomic64 for psp stats counters drivers/net/netdevsim/netdevsim.h | 10 ++++------ drivers/net/netdevsim/psp.c | 27 +++++++++++---------------- 2 files changed, 15 insertions(+), 22 deletions(-) --- base-commit: 422b5233b607476ac7176bfa2a101b9a103d7653 change-id: 20260512-fix-psp-stats-e96c6d069d01 Best regards, -- Daniel Zahka