From: Dominique Martinet via B4 Relay <devnull+asmadeus.codewreck.org@kernel.org>
To: Eric Van Hensbergen <ericvh@kernel.org>,
Latchesar Ionkov <lucho@ionkov.net>,
Christian Schoenebeck <linux_oss@crudebyte.com>
Cc: v9fs@lists.linux.dev, linux-kernel@vger.kernel.org,
Yifei Chu <yifeichu24@gmail.com>,
Dominique Martinet <asmadeus@codewreck.org>
Subject: [PATCH] 9p: v9fs_file_do_lock: replace WARN_ONCE with p9_debug
Date: Fri, 29 May 2026 12:09:20 +0900 [thread overview]
Message-ID: <20260529-lock-warn-v1-1-20c29580d61d@codewreck.org> (raw)
From: Dominique Martinet <asmadeus@codewreck.org>
This warning depends on server-provided data, we should not use
WARN here
Reported-by: Yifei Chu <yifeichu24@gmail.com>
Closes: https://lore.kernel.org/r/CAPJnbgJ7ZK7DCjCfG56hd_iKGePmAzudb4hOWd4=9r32nM+KcA@mail.gmail.com
Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
---
fs/9p/vfs_file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c
index c5e73c37baea55394294b939fdda7170db8503c0..cddfb4b7ce4e22aacad7b51f6e6cbd164b7c2f8f 100644
--- a/fs/9p/vfs_file.c
+++ b/fs/9p/vfs_file.c
@@ -198,7 +198,7 @@ static int v9fs_file_do_lock(struct file *filp, int cmd, struct file_lock *fl)
res = -EAGAIN;
break;
default:
- WARN_ONCE(1, "unknown lock status code: %d\n", status);
+ p9_debug(P9_DEBUG_ERROR, "unknown lock status code: %d\n", status);
fallthrough;
case P9_LOCK_ERROR:
case P9_LOCK_GRACE:
---
base-commit: 3ec9e935015b11236ba778885d89e399f00d6b50
change-id: 20260529-lock-warn-f014cac9badd
Best regards,
--
Dominique Martinet <asmadeus@codewreck.org>
reply other threads:[~2026-05-29 3:09 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260529-lock-warn-v1-1-20c29580d61d@codewreck.org \
--to=devnull+asmadeus.codewreck.org@kernel.org \
--cc=asmadeus@codewreck.org \
--cc=ericvh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=v9fs@lists.linux.dev \
--cc=yifeichu24@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®