From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB01A2F1FD0 for ; Fri, 29 May 2026 12:56:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780059370; cv=none; b=QmoU7MkHKre7pjVp+SFbXE10nRDyidjXUr5qhnhtv7yahc0LkrllLlND51ad+MR3s9MlSRwOAgZnRdARNLe3d5mn/s19RcmhQNc7/HU8OmS7jKMEtEsbN1x03VrGenZHb6Ci5U8HlZi2Jx+I6ar6SiEhFxNEpCsvaLkm8yEWEDI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780059370; c=relaxed/simple; bh=cBvvneJfGJhX9Fyl4t3YJDwOJjbmuxDZLayl05Ei4+0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Y0YljPtL6SRLMg3jEp59ohrwUlRhnKRpqKlWkcjk6x/rZfm14jzFihcVzqUCE+cAPJ5t2dSbpsjPyDTZk9mvRf4VagLjtFGpaq4vcXX2r9Z+uozwX5M96BK40opXVUTRdkWqYwsq2Hj8tgnJfpFA/HdALmL8l2l4o0NjrIx0MO4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=f1oKhUYG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AubOS4Uy; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="f1oKhUYG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AubOS4Uy" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64T7nhnY2258001 for ; Fri, 29 May 2026 12:56:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EqBIzW2d/Qy5w+LqO0U7UT6nDTErkNchWOxlyPRePYI=; b=f1oKhUYG68PZFmrE 299r4PlcKr2WO1zCcr9Eklceb+e9BQ50O8tKVfBWS9MJ8CgjF2GuLsFzHzRO36p5 0npEYnIDd6qHsAPYzpgcom+i4ZUb3YH0XmUVaeKRGdFtea/uj7frQVZp0gDnyf4K lGpzpkiWmyNZmklF6PEf1dbMvGrovR7m+LKHy7lGrF1Bc0JhYQ6XyLljH2iZbamD PYvU6bgw9tTkfaUgZQW8/CBjZdG/+sH4bB+HJGSrjGtdUGpIwCo0Kxg/YK6Xpvpe BamtFQu8I8sON7SC67PgaNTYxZF0o25y9OzTw+LApHzcWZBqJ+Vhkck6kbdl0JLp HnzCMQ== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eety5442u-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 29 May 2026 12:56:07 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c8292e18166so6955837a12.3 for ; Fri, 29 May 2026 05:56:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780059367; x=1780664167; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EqBIzW2d/Qy5w+LqO0U7UT6nDTErkNchWOxlyPRePYI=; b=AubOS4UyGhbA0Xq5l0vFbQT6CqzTbX3usBe6UlQLQRuEdY8S4DL2fsJMFNp3Kk82Ut Onitsguxpb1DkwSbDy3BNmSBZqwYptnsjYun4o2RhvTuiMcjCECyXebZonttB6wSqVzN YISfe3DxCsVmg78+q9TFPK5fVkpaEB0b5YQH7prJSRaLVJ9aFLxqv+3T1tEzE/gzC2F3 DmqBL5VNcHktq2/ZwkN/H3Rp5Xs4/tiRxHXzmJoNprfMQTrJdx7+JjDkCDkUBw6n0KDZ /KHOC3qxL39moyRiJ+2gK/kr6HUTg6029zTzLyBPWsaajV6m5t3PtC+RAIsBqGWVx++B 7LYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780059367; x=1780664167; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=EqBIzW2d/Qy5w+LqO0U7UT6nDTErkNchWOxlyPRePYI=; b=e0Sb8C0CeT1qsqsWusuARi6gZSlQseqz4FEhlVmL9qjTXqmrVjFeKQXaHI2dMQSGFa BNZSx0tu+zh+4LiBWWMh58JudG89+/V64qIyr/0AUlBqxsfcIAwwkjq1GyLheEdGc5Bv Ks2zg64D6/V0yotn7m1Ns2OP2f9A/fpyINeiwk+FHEiOnZ7acskkj0Vk0gr6DA52iYi8 ebLVJrlGOA9R6zipLO2zmTdAjKZ+vfcXQDXrOaqIMS7TWCHl7ef6UUZguTa2PgqVx1IN b5oYvpGIFxZcZfo/Y0+xYS3KaE9ODG3e/AcFQpRrhf9vcAXQ7JeoGWTg58DPqqOmXOE9 04aA== X-Forwarded-Encrypted: i=1; AFNElJ/HXEKVudAtyHjt39zfOmSvI/TsII1tMr4xyBJh9DjFfxtFUIKQ5lXvyj5tdEkZ+1NLYmcAnmpiOaeO85o=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8x1qjz+yRig2yU8LioQPQLRFXMlurDf+mGfLNPfa7k4ZT33YF wMnDvXAd0ba0HCN7okEXinuwWX5Zo07aWDlbrkT+MwtzJ2U2i+SLaq6YcJsB8uSGNX2Iqkeh3nQ 29kitYmQJ5WYwFLJpie8Bhlm/6tg8LCMmVcjjtux/3Thgk4AiOQIk+c1oqUZ49quJaHY= X-Gm-Gg: Acq92OFpX/fryPG+tVxLhffzDd6X8+JtOEd3WwZpqUMSAkYOfIXt16cf4zXF2+aN7Mo 63W5IL+PxBV4cNw2i8vaZMycd3Jae3pMl3IDAWHlvUXik4mROMhrYR4CFPu80+Uro/bmH5bTVBs TGZ5QRxYJvzFcVA2Jf5D6v5ldFvYPmFz989og/8wlhtU63KapCu3n0gUXtBIBURysUJADzWG9DP dgHeprO0toMbzWUJYG1Tj+xbIOQl5IC5SsMxl7g84DAKPCQa7BayllftUSITZQwHJRbqCX8Bogp 8aARHl2TyZW5yvFsdbIwuwv03Os6hc6VGT8wkIw+D3G4wLNayBtp1oKaHWedT9g6S7xkEgv7bxb iP5euqLpbjZL5NJ6LndZanrUHD+YQlu8a/CD8lSVpPr6UzfdQRIXKd6AptKMxYw== X-Received: by 2002:a05:6a20:432c:b0:3a1:90ef:7e46 with SMTP id adf61e73a8af0-3b411e16350mr3018566637.33.1780059366536; Fri, 29 May 2026 05:56:06 -0700 (PDT) X-Received: by 2002:a05:6a20:432c:b0:3a1:90ef:7e46 with SMTP id adf61e73a8af0-3b411e16350mr3018536637.33.1780059366065; Fri, 29 May 2026 05:56:06 -0700 (PDT) Received: from hu-smankad-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c85771a7c24sm2119680a12.2.2026.05.29.05.56.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2026 05:56:05 -0700 (PDT) From: Sneh Mankad Date: Fri, 29 May 2026 18:25:45 +0530 Subject: [PATCH 2/3] pinctrl: qcom: Fix resolving register base address from device node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260529-tlmm_test_changes-v1-2-88bfdccb4369@oss.qualcomm.com> References: <20260529-tlmm_test_changes-v1-0-88bfdccb4369@oss.qualcomm.com> In-Reply-To: <20260529-tlmm_test_changes-v1-0-88bfdccb4369@oss.qualcomm.com> To: Bjorn Andersson , Linus Walleij , Yuanjie Yang Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Sneh Mankad X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780059355; l=2155; i=sneh.mankad@oss.qualcomm.com; s=20250818; h=from:subject:message-id; bh=cBvvneJfGJhX9Fyl4t3YJDwOJjbmuxDZLayl05Ei4+0=; b=L2bj2YcoyPU7o9lR8uK0/dcAAj2uZyspMWCIkwU6ogDf6DK1Riqyj+8urNGGvh5csWYwAq7l/ 1/Zg7q6RSx0AXvAmQyo1Z9aLeEHQZCt6XptBBO8tYKLuFHfipKkcAVe X-Developer-Key: i=sneh.mankad@oss.qualcomm.com; a=ed25519; pk=sv57EGwdcfnp6xJmoBCIT1JFSqWI+gawRHkJWj/T2B0= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI5MDEyOCBTYWx0ZWRfXwuSka+97TEVM 1G3s5fvVplMSUPQojEZ4jRWYUWaRtidtQOzpUOuMAKYK7oxXT1BV0zJRtt6LdF6CaaUCnnxljbg nJTROnsFP+6Apbzc2biOEmIsn9UnO13abzyDHvM+wZxMVpOV4e+i3MbDxyxB2j13e16m/DXXBu4 tAe69/+25rP5IgZWDbVoT0FKcO1o4ZvWYe3A3x/OssagmaOKC9amUEOCAZB3pPdKZR5fItT+nbY fgO6gtbkJ1ZiWq8RsJXLjRIYGq9bMWQUBBPWCF26eHtXYiI32VWau+S8iEeBISuWpnpBO6F7E1/ aq1bRZ5XcIYankgtUIdURjIc91iM0qcPjKSlTj+E0gXNUnV/9mDvBdV+tmfI/e67td9CRLGDO13 H6J/Dzjq49c7dbTK11D7IVq3b8MLqoXGaGdhCOH+anaIG8UO9EHyYnSXIRtdzzT6QtBWg3l2cp4 ANPheK/k8QhBqoIyGwQ== X-Proofpoint-GUID: DAWXaWdU-EUJlHIRl1O0DJUd7MsD5zWv X-Authority-Analysis: v=2.4 cv=WaM8rUhX c=1 sm=1 tr=0 ts=6a198ce7 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=bvtI4k_f0RER6Z2YCYcA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-ORIG-GUID: DAWXaWdU-EUJlHIRl1O0DJUd7MsD5zWv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-29_03,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 adultscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605290128 Commit 56ffb63749f4 ("pinctrl: qcom: add multi TLMM region option parameter") added reg-names property based register reading. However multiple platforms are not using the reg-names as they have only single TLMM register region. Commit tried to handle this using the default_region module parameter, however this condition is unreachable as the error return precedes it by just checking if reg-names property exists or not, making it impossible to use tlmm-test for the SoCs (x1e80100) which don't have reg-names property in TLMM device. Fix this by moving the default_region check at the start of the tlmm_reg_base(). Fixes: 56ffb63749f4 ("pinctrl: qcom: add multi TLMM region option parameter") Signed-off-by: Sneh Mankad --- drivers/pinctrl/qcom/tlmm-test.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/pinctrl/qcom/tlmm-test.c b/drivers/pinctrl/qcom/tlmm-test.c index b655de5b4c5f08e7b138f0da24546274bc5fa93b..007d6539ceced294e81cfbe93a00c75a98c858de 100644 --- a/drivers/pinctrl/qcom/tlmm-test.c +++ b/drivers/pinctrl/qcom/tlmm-test.c @@ -581,6 +581,9 @@ static int tlmm_reg_base(struct device_node *tlmm, struct resource *res) int ret; int i; + if (!strcmp(tlmm_reg_name, "default_region")) + return of_address_to_resource(tlmm, 0, res); + count = of_property_count_strings(tlmm, "reg-names"); if (count <= 0) { pr_err("failed to find tlmm reg name\n"); @@ -597,18 +600,14 @@ static int tlmm_reg_base(struct device_node *tlmm, struct resource *res) return -EINVAL; } - if (!strcmp(tlmm_reg_name, "default_region")) { - ret = of_address_to_resource(tlmm, 0, res); - } else { - for (i = 0; i < count; i++) { - if (!strcmp(reg_names[i], tlmm_reg_name)) { - ret = of_address_to_resource(tlmm, i, res); - break; - } + for (i = 0; i < count; i++) { + if (!strcmp(reg_names[i], tlmm_reg_name)) { + ret = of_address_to_resource(tlmm, i, res); + break; } - if (i == count) - ret = -EINVAL; } + if (i == count) + ret = -EINVAL; kfree(reg_names); -- 2.34.1