From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1EFD3BD642 for ; Fri, 29 May 2026 09:56:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780048592; cv=none; b=I1zWSun0NJs5Ap9lc/y9bObV42WzULIDRnU+tB/XE8tDLBu3z2MBGPNe8AtatiNdzNZ0nlSUXrL7+t6zS3uGk9a479iNLLFnrHARlvdwv4YzhJ9S8z5HDhs/v58qyS8mzgVW0ZhsPNn0D27hks7PGt7b22wGxykRm3wWy++w7fE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780048592; c=relaxed/simple; bh=b4SlGHyKejpjGEPSSsF9TtxkNCBpxGUf0lpztK/k6FU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bXQEVd15U/C8s4GB7R4MM5qExBkmJ1O6AKFZJbovj4ZCe0MzCVNKlVGZ2vL0N24s73cUfX1E2THGoIa5GcONmM57T3LuSVKz8s01EJZudj3+vXaorZXOx1JaKmG5AbHd7ocy4kiBnzh/0mg92FkoBSImDm5iOscyF3UfhizO8iw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jVQAw4GH; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jVQAw4GH" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-45e9f4a3510so4601134f8f.1 for ; Fri, 29 May 2026 02:56:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780048590; x=1780653390; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=QlBVL2w9TAGD5JVBams2MPk6DO1Ps9XKY2pj6ZAb950=; b=jVQAw4GHq19+XzXlvAaw6dL6k9Ehf2rQF0oT2xRU6PzGVvpUeYKgHIARgCND67ZZEK 6ln6r9u73kj364EMV3Ljd4ODIc4HM13izpThsm9GpwlkfGsofCVgWUyRW8kh/Jr54gYz hL0o7wkWyl6qDtiHlvmjutstqBRW9CNpW1CnEvw+zJcZGbzf9O9dzzvGqnBE2Zdvvx3b mWQCWRhGkGmbnFumNnYBObFF/baRlOUZyo9dliNPUIqPIzvN9zRoeyZqGpYRM+SiGriu 4vvlGMItgXHxbFr1HK8ZuiW+hQ3dTEUrfNrrPdh61Y7qTD6Sp72lt+1Q/fVXtMPgUQu8 esLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780048590; x=1780653390; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QlBVL2w9TAGD5JVBams2MPk6DO1Ps9XKY2pj6ZAb950=; b=ESvzI9x+XXpQvRccJbtqd2dDjrkjxgbSDYVO8WE47WKmMl6DifJjsdFNSg71c2APGO B72UWo9MtjpfTZtQJkvDt/g5jq0DPmBiaWEQCUFJpqZtmsr6iiV85BKJ+FjDkwyHm6BY tS0AOF/Qw0WtX3Q3nxcfds1gVyHQk/fq11sWaNjIr1yvuEF483+YR20uMmu1kH/IYKZG IgokQ64ecMtRHDEc0X5BW2ngauNz5hnwG7qA9Uxrc7eRJM54RZeGnYwWb3YJSCdBxSl5 SHsAhOebRzUsYHXh6pnwfcxu+WegUDtKV5vqHR23Nq8WXo1UE4dZ8s1Staa7906e/G4H aouw== X-Forwarded-Encrypted: i=1; AFNElJ/f52ikDwuW3CPTQqoGRT2MF4Xr6wxq22wCHM84vEW3AfyW7qhQZstbc+IBeWShl8voJwEdf1Y9fdrGDvI=@vger.kernel.org X-Gm-Message-State: AOJu0YwgiRxg45iaEBKjDzFviHbyZkV7PxLE9cFqpQNZIUtTKq3f7jfI KqZYvj2ERw4ZQQiva6SolR60s6K+SR93TOZi/UDOOXE9yXxRcNhfjVs4 X-Gm-Gg: Acq92OGkxs99t93RA2Mt7s6laBP6xYlO5zYo9UZmerGOmEVV9zIuA4fH9ERyb30YqBi ZFqx3Aj2f89jFaOY5TswnYBuv94FveorqvI9WWJlFGZct/S+v1ziP3K+GBAF8efiXoZiD+iwSry t8/RDXAF7kMEgllE4DQAVHV7BIwsoNAdlxl2hV9EQLpY7Zo2fCQ6jlqFUcaB5BDVHXXHU3t9Tll v2ghuL5y1L1BCz+G/GOg3D3dzz91LyAhxZFrOQNkzSGCaxCCkGFxdcERnIna4Ilqv59E/PHA53W yQJHRlNi8dHZUP4R8hkJW1euEODXzljp6dQpgNeo6xkJ+xXaY0/np4ZYdSaiXQHfXDjLKgxb3tZ Dp3oC04VAj05U6Fq1Qg+Qzh2Wc82EguyoO9TCZnEl5zYvUuAtZ/PcIDih27TvEKMHt72sTQkI8+ gT4kMg+n4qeCpvrtrL64OaSGU9oFaF26Nd X-Received: by 2002:a05:600c:c168:b0:490:50eb:b777 with SMTP id 5b1f17b1804b1-4909c07267dmr43425645e9.5.1780048589855; Fri, 29 May 2026 02:56:29 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4909c09ab75sm11200965e9.6.2026.05.29.02.56.28 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 29 May 2026 02:56:29 -0700 (PDT) Date: Fri, 29 May 2026 09:56:28 +0000 From: Wei Yang To: Johannes Weiner Cc: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Shakeel Butt , Michal Hocko , Dave Chinner , Roman Gushchin , Muchun Song , Qi Zheng , Yosry Ahmed , Zi Yan , "Liam R . Howlett" , Usama Arif , Kiryl Shutsemau , Vlastimil Babka , Kairui Song , Mikhail Zaslonko , Vasily Gorbik , Baolin Wang , Barry Song , Dev Jain , Lance Yang , Nico Pache , Ryan Roberts , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 5/9] mm: list_lru: deduplicate lock_list_lru() Message-ID: <20260529095628.nagjdy3f24z6qjtk@master> Reply-To: Wei Yang References: <20260527204757.2544958-1-hannes@cmpxchg.org> <20260527204757.2544958-6-hannes@cmpxchg.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260527204757.2544958-6-hannes@cmpxchg.org> User-Agent: NeoMutt/20170113 (1.7.2) On Wed, May 27, 2026 at 04:45:12PM -0400, Johannes Weiner wrote: >The MEMCG and !MEMCG paths have the same pattern. Share the code. > >Reviewed-by: David Hildenbrand (Arm) >Acked-by: Shakeel Butt >Reviewed-by: Lorenzo Stoakes (Oracle) >Signed-off-by: Johannes Weiner >Reviewed-by: Liam R. Howlett (Oracle) >--- > mm/list_lru.c | 21 +++++++++------------ > 1 file changed, 9 insertions(+), 12 deletions(-) > >diff --git a/mm/list_lru.c b/mm/list_lru.c >index 7d0523e44010..fdb3fe2ea64f 100644 >--- a/mm/list_lru.c >+++ b/mm/list_lru.c >@@ -15,6 +15,14 @@ > #include "slab.h" > #include "internal.h" Hi, Johannes One very tiny nit below. > >+static inline void lock_list_lru(struct list_lru_one *l, bool irq) Here we use @irq. >+{ >+ if (irq) >+ spin_lock_irq(&l->lock); >+ else >+ spin_lock(&l->lock); >+} >+ > static inline void unlock_list_lru(struct list_lru_one *l, bool irq_off) Here we use @irq_off. Do you think it would be nicer to unify the parameter name? Also the name in callsite and the argument annotation. Would it be cleaner readers? -- Wei Yang Help you, Help me