From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9BFF2FE074; Sat, 30 May 2026 10:48:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780138093; cv=none; b=d5bfONUwg9Ge43KVvsOvgYldyMw07qBR/gFlGhdYaunrmYUpnEd1xd2aKsg/kXVgtEUvpS/H4UDQrZxTwEbeTtkv50xU7xkckBYcxL2JZgtzSsQ8WRW7fnijp9U/p4VpT8ggnBmP9xGecKQRWTOGqn0QFVo/QMBUMAEihyxio7w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780138093; c=relaxed/simple; bh=P0FCZwwYbVMr0jekGLdzkA0WJKNkpxU2GibrYj/mhk0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=N9/VN4TOGiG7KZ/7RUk9WvZ7a6NGBgrIeoJ99EIlm/KxTQ/Z8DjmiLZ6nAbOtp1nu1KTjJRMq4eAIff1A8MUAcVTD/48ILP6LezQrOKq0oyDlVIa8vmlEva60x3k+kfbFKbBt9/2TKAw4/0Qt07wN+1BC/KPflf6f7hDvifhm8k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MP5c73d9; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MP5c73d9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C49D91F00893; Sat, 30 May 2026 10:48:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780138092; bh=8ZOkOiUGphlye6XMDBEWeJg+3upNBwM3JqNA5E14kxQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=MP5c73d9myscEqyCSzql55cJ27CeS+f0OyRedHnif8Ny44lNNrYxpOuTIVQqlUmbf iS1Lyx17qVCiER0uLQcw/OIH0j42Zi70dtGt9eAGTS/iaMEbnbbJWVK087lh5ZFMxM A3/9LnhWwT0BqzFAtrPh16o3vvzNTryX+Y/nRsNJnx1fCvA1jtMqVZywrgd8KKCpie uIVjnR//3JbS0erZg+8JCOyPZcGQIpSHvFTXXasBuyrM8Wjj+vFAV7YPzM1vyla2cc NvugdXL2GIQfechTmq05Y2/AzeIldT2WGT955Dw4r3FgkJFM3d3094zUQVxzplrOvC DkP0oorkhEPgw== Date: Sat, 30 May 2026 12:48:10 +0200 From: Krzysztof Kozlowski To: Eric Biggers Cc: Demi Marie Obenour , Dmitry Baryshkov , Herbert Xu , "David S. Miller" , Thara Gopinath , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Russell King , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ard Biesheuvel , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] crypto: Delete Qualcomm crypto engine driver Message-ID: <20260530-unbeatable-supportive-wren-c27de8@quoll> References: <20260523-delete-qce-v1-0-86105cd7f406@gmail.com> <20260523-delete-qce-v1-1-86105cd7f406@gmail.com> <7rgfuvv3hai7g4wt4accbkejtzdt5dnb6mkj6x7ox5sz35q4n2@h7j6rr7extuj> <66317f6a-645e-432b-ae11-8f40569d4117@gmail.com> <20260524204537.GB110177@quark> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260524204537.GB110177@quark> On Sun, May 24, 2026 at 03:45:37PM -0500, Eric Biggers wrote: > On Sun, May 24, 2026 at 10:29:28PM +0200, Krzysztof Kozlowski wrote: > > On 24/05/2026 22:12, Demi Marie Obenour wrote: > > > On 5/24/26 12:42, Dmitry Baryshkov wrote: > > >> On Sat, May 23, 2026 at 03:03:56PM -0400, Demi Marie Obenour via B4 Relay wrote: > > >>> From: Demi Marie Obenour > > >>> > > >>> It's slower than the generic C code and causes problems. > > >> > > >> Which problems? > > > > > > See https://lore.kernel.org/all/20260522024912.GC5937@quark/. > > > > Your commit is still incomplete and other people's opinion is poor > > reason. If you do not know what to write, ask that person to make > > necessary changes. > > > > Not mentioning that removing driver is not even necessary to achieve the > > goal Eric was mentioning and if I understood correctly: you are removing > > even the pieces Eric found useful. > > This driver is more than an order of magnitude slower than the CPU for > both encryption and hashing. See: > > https://lore.kernel.org/r/20250704070322.20692-1-ebiggers@kernel.org/ > https://lore.kernel.org/r/20250615031807.GA81869@sol/ > > There are many examples of it having bugs as well, for example see the > second link above. > > That's why it had to be disabled via the cra_priority system. This > driver was actively making Linux worse. > > This isn't particularly unique to drivers/crypto/, of course. This one > we just have data on, so it's a bit clearer. > > I've yet to see any real reason to keep this driver. > > Crypto drivers need to be held to a higher standard than other device > drivers, as well. The onus is on those who want to keep a particular > crypto driver to prove that it's worth keeping. Commit doing the work should have all these explanations, including numbers. External references are not a proper justification for commits. Make your case, describe the findings including impact (or lack of impact) on ongoing hw wrapped keys work and inlined encryption for other devices (ICE). Best regards, Krzysztof