From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FD8923C4F3 for ; Sat, 30 May 2026 01:25:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780104313; cv=none; b=Jztb6y3ZeoYkYiQMo5/7snbBktHKZJjkzMO+y6gTh+/Itlt+lX1dnDf0lKuoxDcCqvPmvWKFOnUKl6FhKK8IvAhxAx9Onzkp8/DqvOXgq8J9ZNYbuCZi90girLaigdnZGheOA2MfuDMb1mLTicdtIneRDf11Y8TQUJKF1x+1Fsg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780104313; c=relaxed/simple; bh=VXHmww2kmAiStU1LtDb87dJBC0iCRH3nmBh0AQEIFsk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qnBJD1uKzZfQIFSOfyCrNeva7TZbAA0DTMJLZOLxKuSpCfaYBxgnqD3Ib5gLuVQvrjWFEJmfLLpINIM6qlgn8bv1yVBJNMEA0gBbwkGtvezpbKtZlcVTj0drp8tzuy1Rf/TTzIpOSKzOZAYeQvKIapNL5IDVmTKiBDQD7vIigc4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HpgY9CCX; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HpgY9CCX" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-68b73f1a8ebso3465711a12.1 for ; Fri, 29 May 2026 18:25:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780104309; x=1780709109; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=blzWfs+CdYUoQumGPXqABGcwSvz3mulcURHwgoS7ZCY=; b=HpgY9CCXDGiwoy2lVarMJStV/6ujZkoakylS74rNJdMtxSpF+kM2W6hU+wYGo4+fxS 7bEJ5Ue2CAX1gxl/Km0N7GBiIai9Ls8MzFRoYVIJrsXQbeqBE0yRs1IjcWCP9xyHvKgG pNMZtdhaoTmZFKoOkh57J0d1/0I0Nh+0Oft00czQPFU0a12ZvZEcQ9tAg86ke3GzZdmn KJQBZFRYU74r0EXZzwc0cphR5ldQubLtVrIbJSTTi+42a3HANZdl/lkWCX66ooEf6kO1 dAv54SlswANszwtue3J6/Zi5zX694ZSVhU5HKRExm+0IsnmHCiFd5XU4eKOKmsxh80s2 53ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780104309; x=1780709109; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=blzWfs+CdYUoQumGPXqABGcwSvz3mulcURHwgoS7ZCY=; b=SP+1Hl6mdv+gXTQKLnJsXncQiEChmZi8u8j5z1/GellTiX8olL6eyPhLYQy+PJQ/XB 1wZ+yEwRmLs5DBa5033+2gVrfR5MjtduWKQVXYTgc2riEfG5+Haz4nr8cJYzaOIEVR1S /6tioUa0P99FEwo7sJIZMI+XiBb5sBK0CV1R3UzVjlHKAWJ59QmzkEuiTpxoMk2we/8P 3V7fluD/ESkhS4TeX/scjy9PGSyofEB8qoOthIRJcX3aAyeVkw3p7QEX3IMIAy3P54eE 04aaGREDqKJQp6XTBBmKkDoqkH3Idm6Ec3G8d/noQ7L9Ae1Fsf7jygKbAW5Wl+1t9UZJ 58WQ== X-Forwarded-Encrypted: i=1; AFNElJ+l2EmOXD1YOBm0N2UZ1Okb7Zf8pKdBcFox0Hze60Zx/+MvSRf/dO1SO39XLpjqvGJUYf/6FqcvVVY46VM=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5gL1C27TTB8/ULO5vyQLkI1EKHtLVUmtNxY5LwdxOMI8LzZEL 8nIQBkcfSi5Rh+S3p9Z455wLamg0RiXQaJa38wnqtwFRO4nKhA7Dq5Pz X-Gm-Gg: Acq92OG67VHFGsibQikNquvCIpo5hA01TFKbNjxTJpGH4ain6zf1WnUOUDyI5/LCNed QusYIP+Mbk8oB/YkfAoG/lq9zo7WxdLMv/bkQ+uaAv5uA2k87YH3FvTSMoulYSYfqiRKo7AJGTk yt9XhrRf/PTInbAmef72mH6M77+ELYVW95C/9N6HvXfonPaBdavGUvUbEEcf8iYItcCEYXIkkIe jRz4qp+SLDqOWF/kYNr/40Y/jxSsSeOnZRZgCEOu/qM6SuustqDoOlU35CjPyfAdtb4hAKx1vpa oL5FWB8+Cc8MROOKjqp6B91vjAcLHv9xCrgXrOUNRLXd/5TctqAwqAVndWHz3+hi+Iq9tlN/yoD HgZNZo5T1ogWhq4YPLvjDOmzHu0bxEsC1/o1Zfg4EG+w4vidaZmN7occ05y5wDYE1mIx0cGE6r4 lkGj3bAjv3OjBjhpdM0It7vhn4Qh/EAGSslFviLdF0ijY= X-Received: by 2002:a17:906:c10f:b0:bd5:7a3:a590 with SMTP id a640c23a62f3a-beab6cba322mr85730566b.47.1780104308756; Fri, 29 May 2026 18:25:08 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-be9d27f224bsm114374166b.3.2026.05.29.18.25.06 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 29 May 2026 18:25:07 -0700 (PDT) Date: Sat, 30 May 2026 01:25:06 +0000 From: Wei Yang To: Johannes Weiner Cc: Wei Yang , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Shakeel Butt , Michal Hocko , Dave Chinner , Roman Gushchin , Muchun Song , Qi Zheng , Yosry Ahmed , Zi Yan , "Liam R . Howlett" , Usama Arif , Kiryl Shutsemau , Vlastimil Babka , Kairui Song , Mikhail Zaslonko , Vasily Gorbik , Baolin Wang , Barry Song , Dev Jain , Lance Yang , Nico Pache , Ryan Roberts , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 5/9] mm: list_lru: deduplicate lock_list_lru() Message-ID: <20260530012506.yui5w25n3axgzpoc@master> Reply-To: Wei Yang References: <20260527204757.2544958-1-hannes@cmpxchg.org> <20260527204757.2544958-6-hannes@cmpxchg.org> <20260529095628.nagjdy3f24z6qjtk@master> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) On Fri, May 29, 2026 at 09:42:02AM -0400, Johannes Weiner wrote: >On Fri, May 29, 2026 at 09:56:28AM +0000, Wei Yang wrote: >> On Wed, May 27, 2026 at 04:45:12PM -0400, Johannes Weiner wrote: >> >The MEMCG and !MEMCG paths have the same pattern. Share the code. >> > >> >Reviewed-by: David Hildenbrand (Arm) >> >Acked-by: Shakeel Butt >> >Reviewed-by: Lorenzo Stoakes (Oracle) >> >Signed-off-by: Johannes Weiner >> >Reviewed-by: Liam R. Howlett (Oracle) >> >--- >> > mm/list_lru.c | 21 +++++++++------------ >> > 1 file changed, 9 insertions(+), 12 deletions(-) >> > >> >diff --git a/mm/list_lru.c b/mm/list_lru.c >> >index 7d0523e44010..fdb3fe2ea64f 100644 >> >--- a/mm/list_lru.c >> >+++ b/mm/list_lru.c >> >@@ -15,6 +15,14 @@ >> > #include "slab.h" >> > #include "internal.h" >> >> Hi, Johannes >> >> One very tiny nit below. >> >> > >> >+static inline void lock_list_lru(struct list_lru_one *l, bool irq) >> >> Here we use @irq. >> >> >+{ >> >+ if (irq) >> >+ spin_lock_irq(&l->lock); >> >+ else >> >+ spin_lock(&l->lock); >> >+} >> >+ >> > static inline void unlock_list_lru(struct list_lru_one *l, bool irq_off) >> >> Here we use @irq_off. >> >> Do you think it would be nicer to unify the parameter name? > >Yes, I think it would be nicer. > >Note that I inherited this - we had irq on the lock and irq_off on the >unlock before already. I didn't want to mix even more yak shaving prep >patches into this series. Reasonable. > >Mind sending a follow-up patch on top of mm-unstable? Thanks, I am glad to. Since this is trivial, I would wait until everything is settle down. Looks good to you? -- Wei Yang Help you, Help me