From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AAA7347514 for ; Sat, 30 May 2026 08:08:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780128496; cv=none; b=O5zpCRb77gvijzPejAQMSjmQLrAdSv8hm9pY4pWfT6pVh4hz1YTpHSg//CUtg4j2lv+V13/KhznaQcieoqJRxME5kWdNF5nkAjGYUC+XQu5kJEMVyFBMLeOpmz9pK6yYm6lObLPB+r6pPmr40nq9bk/2vMi1xWaUj9EQL8DJTGE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780128496; c=relaxed/simple; bh=rD9awX0RkN/CCtppCeTpHNOnh8YqYGtTq7A7y+jcBJY=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=V/GKMtWIHQI1EK12RuBgRKpUwXOB3H7Cw7KbPHs9TQWqAWKM4DAkxL096xMMxj0jK4ZbO1YF4RRPWtu2OdsaFwWEzMaSTb4ugftZb0PiG/BI27mrUkM+qIuEBHyNZ55FHG4gvjU7P/yrgtLhm+PMDCMD4LKLZQ/9XemxcoWPiLs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JZgcVbjY; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JZgcVbjY" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-490388fd0dbso89493705e9.0 for ; Sat, 30 May 2026 01:08:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780128494; x=1780733294; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=kH8Pl7SP8LWSHPvqI1Gh+YwqGQGUx2sMcX2ZQOOsAWo=; b=JZgcVbjYuklxwJmQ9X/bpZUVTeUilREJPCo6CvyK3LU4LNkFCYsUSIdIVS8j/HhzGs 7JnFE41VXpUDBtezEstBKb/G2ULH3GpH4JO3E/SY083TQSByu05Vr/bC6qetLcIOIt+6 5PyVd6a7Do7GHwf0LhvktAvxNpvmq4lNkElApQ7Ww4CpbVE9XavI1a4vstP1uxeXhh/9 DVXlm7bCmT58IPZ59HAA9BrTa9q7mxealXQqF2wbh06oMQx8Lzl6UMioZSc49bKfwZsM asQGv18s8LRTRnWrJCfhwwEvH5hN5yL30fSQEz9J7vb7jdtyj2McUQSVC7SU3uBu+Tz1 ipfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780128494; x=1780733294; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kH8Pl7SP8LWSHPvqI1Gh+YwqGQGUx2sMcX2ZQOOsAWo=; b=CR2370vUNWG4MdBgfh2vi1aMXQ/sRsvY40DzllMBlAUlkQwt3Syqh6iXHn32N2p/zv L/oe8N2pp4o5uDqDu6iIw8/bFFnpMEA6z7Yte6CNJ5tbQd1FYVmpKIb/0ed9ybRbWBdQ 9Y5ORGVxvAmtbzsRdg8BH4CmzFZbQBffWTTIXLVu5MQ7WFHTcrxBGowSyU+TEqvVeRM0 sBkc/ONxeyfRbUWjfX0anhwz0kzTep50TFuUtwbXKRn2mkRQgFDkYDcz1/AD1a8++sxk 6sodvfy0U82MBHi68HE8CPMxp6acovg/M9+Kfa311Rm8DIAnDU+IFl+RQyStO4khA94H HI1g== X-Forwarded-Encrypted: i=1; AFNElJ9rfIXdMYiEaVW/6eCi3ddVVlw7iI4GDPoSaLm8wFZi3WFUr1SfpP2Y8a1TbYBmORzSmgIJpE8uYgZ2fbw=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4bCL9r0KMqiDmW9Nkj6l/Z/bEFXsQCCtyIMm0hEYcD+VYzFxP etAeklwWICcnpeSr6rsKVjwj7XwxoaYI2VFgDI+d2CpMpGzeDHKcn8/Z X-Gm-Gg: Acq92OGE62ur4HqEnAamYxUXEpXLprv+LB+sN8MMKjen3VGLj07bvA+gvAlrtvKhgMH rk2UJPAsktsMmWKORLbZDgFlGV3pIU50ovgDK67D1XdIxoTZFt4t4ZoPKY2eeIeQkM0XLXRT29G USpuzwrGhSzOXe2Dd6z/LsNItPfHIuewnec790JgEr2IA1f/Ce4MQp8PEwvPL57oP7FKZiidOxk INBH1R645ql5xMAoAdMqvrO3YRKzy6yO3gf9+Oohb5cKd0W0NvY4OXd1CmCosFxSHKx6nO9SgYP Rk6HZ4XoeJ7yJBV0S54I/bDReukPGyoyUnyQQLUR2eamRbCAMcD51/8ADu9E9xgruQMMfxFyQao crAwcKt0frEC7xieShF5qLpP8leM149Kaq5FZPlEkFnPZuxEvbi74+DTXy8FtcoOVE9Jdv/4UG0 0uFL6HsGAw0ICzWvuoM+tvQPVxc24qWthVCg== X-Received: by 2002:a05:600c:34c8:b0:488:ac01:72de with SMTP id 5b1f17b1804b1-490a2b6e3d2mr43745985e9.5.1780128493612; Sat, 30 May 2026 01:08:13 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4909c09abadsm29881905e9.1.2026.05.30.01.08.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 May 2026 01:08:12 -0700 (PDT) Date: Sat, 30 May 2026 11:08:09 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Zhang Cen , Jaegeuk Kim , Chao Yu Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Gao Xiang , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, zerocling0077@gmail.com, 2045gemini@gmail.com, Zhang Cen Subject: Re: [PATCH v3] f2fs: protect published gc_thread during teardown Message-ID: <202605300627.kUlwXIge-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260528065601.3257303-1-rollkingzzc@gmail.com> Hi Zhang, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Zhang-Cen/f2fs-protect-published-gc_thread-during-teardown/20260528-145912 base: linus/master patch link: https://lore.kernel.org/r/20260528065601.3257303-1-rollkingzzc%40gmail.com patch subject: [PATCH v3] f2fs: protect published gc_thread during teardown config: i386-randconfig-r071-20260529 (https://download.01.org/0day-ci/archive/20260530/202605300627.kUlwXIge-lkp@intel.com/config) compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 smatch: v0.5.0-9185-gbcc58b9c If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202605300627.kUlwXIge-lkp@intel.com/ smatch warnings: fs/f2fs/super.c:5006 f2fs_fill_super() warn: missing error code 'err' fs/f2fs/sysfs.c:1027 __f2fs_sbi_store() warn: inconsistent indenting vim +/err +5006 fs/f2fs/super.c aff063e266cbf4 Jaegeuk Kim 2012-11-02 4961 ed2e621a95d704 Jaegeuk Kim 2014-08-08 4962 try_onemore: d1267b5f0b476d Zhang Cen 2026-05-28 4963 gc_thread_srcu_inited = false; da554e48caab95 hujianyang 2015-05-21 4964 err = -EINVAL; da554e48caab95 hujianyang 2015-05-21 4965 raw_super = NULL; e8240f656d4d5d Chao Yu 2015-12-15 4966 valid_super_block = -1; da554e48caab95 hujianyang 2015-05-21 4967 recovery = 0; da554e48caab95 hujianyang 2015-05-21 4968 aff063e266cbf4 Jaegeuk Kim 2012-11-02 4969 /* allocate memory for f2fs-specific super block info */ bf4afc53b77aea Linus Torvalds 2026-02-21 4970 sbi = kzalloc_obj(struct f2fs_sb_info); aff063e266cbf4 Jaegeuk Kim 2012-11-02 4971 if (!sbi) aff063e266cbf4 Jaegeuk Kim 2012-11-02 4972 return -ENOMEM; aff063e266cbf4 Jaegeuk Kim 2012-11-02 4973 df728b0f6954c3 Jaegeuk Kim 2016-03-23 4974 sbi->sb = sb; df728b0f6954c3 Jaegeuk Kim 2016-03-23 4975 92b4cf5b48955a Tetsuo Handa 2022-11-09 4976 /* initialize locks within allocated memory */ e605302c14ffda Chao Yu 2026-01-04 4977 init_f2fs_rwsem_trace(&sbi->gc_lock, sbi, LOCK_NAME_GC_LOCK); 92b4cf5b48955a Tetsuo Handa 2022-11-09 4978 mutex_init(&sbi->writepages); ce9fe67c9cdb21 Chao Yu 2026-01-04 4979 init_f2fs_rwsem_trace(&sbi->cp_global_sem, sbi, LOCK_NAME_CP_GLOBAL); 6a5e3de9c2bb0b Chao Yu 2026-03-06 4980 #ifdef CONFIG_DEBUG_LOCK_ALLOC 6a5e3de9c2bb0b Chao Yu 2026-03-06 4981 lockdep_register_key(&sbi->cp_global_sem_key); 6a5e3de9c2bb0b Chao Yu 2026-03-06 4982 lockdep_set_class(&sbi->cp_global_sem.internal_rwsem, 6a5e3de9c2bb0b Chao Yu 2026-03-06 4983 &sbi->cp_global_sem_key); 6a5e3de9c2bb0b Chao Yu 2026-03-06 4984 #endif bb28b66875cca7 Chao Yu 2026-01-04 4985 init_f2fs_rwsem_trace(&sbi->node_write, sbi, LOCK_NAME_NODE_WRITE); f9f93602512bce Chao Yu 2026-01-04 4986 init_f2fs_rwsem_trace(&sbi->node_change, sbi, LOCK_NAME_NODE_CHANGE); 92b4cf5b48955a Tetsuo Handa 2022-11-09 4987 spin_lock_init(&sbi->stat_lock); 66e9e0d55d117a Chao Yu 2026-01-04 4988 init_f2fs_rwsem_trace(&sbi->cp_rwsem, sbi, LOCK_NAME_CP_RWSEM); 92b4cf5b48955a Tetsuo Handa 2022-11-09 4989 init_f2fs_rwsem(&sbi->quota_sem); 92b4cf5b48955a Tetsuo Handa 2022-11-09 4990 init_waitqueue_head(&sbi->cp_wait); 92b4cf5b48955a Tetsuo Handa 2022-11-09 4991 spin_lock_init(&sbi->error_lock); 92b4cf5b48955a Tetsuo Handa 2022-11-09 4992 92b4cf5b48955a Tetsuo Handa 2022-11-09 4993 for (i = 0; i < NR_INODE_TYPE; i++) { 92b4cf5b48955a Tetsuo Handa 2022-11-09 4994 INIT_LIST_HEAD(&sbi->inode_list[i]); 92b4cf5b48955a Tetsuo Handa 2022-11-09 4995 spin_lock_init(&sbi->inode_lock[i]); 92b4cf5b48955a Tetsuo Handa 2022-11-09 4996 } 92b4cf5b48955a Tetsuo Handa 2022-11-09 4997 mutex_init(&sbi->flush_lock); d1267b5f0b476d Zhang Cen 2026-05-28 4998 err = init_srcu_struct(&sbi->gc_thread_srcu); d1267b5f0b476d Zhang Cen 2026-05-28 4999 if (err) d1267b5f0b476d Zhang Cen 2026-05-28 5000 goto free_sbi; d1267b5f0b476d Zhang Cen 2026-05-28 5001 gc_thread_srcu_inited = true; 92b4cf5b48955a Tetsuo Handa 2022-11-09 5002 ff9234ad4e9747 Namjae Jeon 2013-01-12 5003 /* set a block size */ 6bacf52fb58aeb Jaegeuk Kim 2013-12-06 5004 if (unlikely(!sb_set_blocksize(sb, F2FS_BLKSIZE))) { dcbb4c10e6d969 Joe Perches 2019-06-18 5005 f2fs_err(sbi, "unable to set blocksize"); aff063e266cbf4 Jaegeuk Kim 2012-11-02 @5006 goto free_sbi; error code? a07ef784356cf9 Namjae Jeon 2012-12-30 5007 } aff063e266cbf4 Jaegeuk Kim 2012-11-02 5008 df728b0f6954c3 Jaegeuk Kim 2016-03-23 5009 err = read_raw_super_block(sbi, &raw_super, &valid_super_block, e8240f656d4d5d Chao Yu 2015-12-15 5010 &recovery); c0d39e65ba3243 Namjae Jeon 2013-03-17 5011 if (err) 9076a75f8e0f23 Gu Zheng 2013-10-14 5012 goto free_sbi; 9076a75f8e0f23 Gu Zheng 2013-10-14 5013 5fb08372a68936 Gu Zheng 2013-06-07 5014 sb->s_fs_info = sbi; 52763a4b7a2112 Jaegeuk Kim 2016-06-13 5015 sbi->raw_super = raw_super; 52763a4b7a2112 Jaegeuk Kim 2016-06-13 5016 b62e71be2110d8 Chao Yu 2023-04-23 5017 INIT_WORK(&sbi->s_error_work, f2fs_record_error_work); 92b4cf5b48955a Tetsuo Handa 2022-11-09 5018 memcpy(sbi->errors, raw_super->s_errors, MAX_F2FS_ERRORS); b62e71be2110d8 Chao Yu 2023-04-23 5019 memcpy(sbi->stop_reason, raw_super->s_stop_reason, MAX_STOP_REASON); 92b4cf5b48955a Tetsuo Handa 2022-11-09 5020 704956ecf5bcdc Chao Yu 2017-07-31 5021 /* precompute checksum seed for metadata */ 7beb01f74415c5 Chao Yu 2018-10-24 5022 if (f2fs_sb_has_inode_chksum(sbi)) d005af3b6756e5 Eric Biggers 2025-05-12 5023 sbi->s_chksum_seed = f2fs_chksum(~0, raw_super->uuid, 704956ecf5bcdc Chao Yu 2017-07-31 5024 sizeof(raw_super->uuid)); 704956ecf5bcdc Chao Yu 2017-07-31 5025 458c15dfbce62c Chao Yu 2023-05-23 5026 default_options(sbi, false); dabc4a5c60f796 Jaegeuk Kim 2015-01-23 5027 94b3ce7f1509d9 Hongbo Li 2025-07-10 5028 err = f2fs_check_opt_consistency(fc, sb); dabc4a5c60f796 Jaegeuk Kim 2015-01-23 5029 if (err) 94b3ce7f1509d9 Hongbo Li 2025-07-10 5030 goto free_sb_buf; d185351325237d Hongbo Li 2025-07-10 5031 94b3ce7f1509d9 Hongbo Li 2025-07-10 5032 f2fs_apply_options(fc, sb); d185351325237d Hongbo Li 2025-07-10 5033 d185351325237d Hongbo Li 2025-07-10 5034 err = f2fs_sanity_check_options(sbi, false); abd0e040e9a516 Eric Sandeen 2025-03-03 5035 if (err) abd0e040e9a516 Eric Sandeen 2025-03-03 5036 goto free_options; abd0e040e9a516 Eric Sandeen 2025-03-03 5037 6d1451bf7f84ea Chengguang Xu 2021-01-13 5038 sb->s_maxbytes = max_file_blocks(NULL) << e0afc4d6d0d3e7 Chao Yu 2015-12-31 5039 le32_to_cpu(raw_super->log_blocksize); aff063e266cbf4 Jaegeuk Kim 2012-11-02 5040 sb->s_max_links = F2FS_LINK_MAX; aff063e266cbf4 Jaegeuk Kim 2012-11-02 5041 5aba54302a46fd Daniel Rosenberg 2019-07-23 5042 err = f2fs_setup_casefold(sbi); 5aba54302a46fd Daniel Rosenberg 2019-07-23 5043 if (err) 5aba54302a46fd Daniel Rosenberg 2019-07-23 5044 goto free_options; 5aba54302a46fd Daniel Rosenberg 2019-07-23 5045 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki