From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4AE9355F3A; Sat, 30 May 2026 20:44:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780173879; cv=none; b=PVCTfP2fPgGIuDTPCuBKSJBSVnR6LZaWUsRE3yvu0YE6tgBfW4TZoq4eOzwBkivDlgcDdneWITxYAeOAsT9aSyrt6zCmm42MzHYLu48tx5abDV29xhrZTWRJPEfWOf1GDJ0SW587hPHYID2miH8n7YFVy5ZeG3JXk63JRLRXxLQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780173879; c=relaxed/simple; bh=lMmH0s5NcHHnMjtPYyHAIx3VxaoajI0IWp6g9tHyoao=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qoM8FwX05tX/a9HCFvBz86s5xWN+oadEjm+05Z4Iq5qonxb76MIeAA+IpT7H/uU1smHdixXia/o9by44simErVTKlVf1dMHQwwy4LLYqB8pTF2gntjC9F9Br+xuIKTQwBCZkyHNZjC02KghS7ZCF58jmzDL7/lGhinNgZLX2MJI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mYTrT07O; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mYTrT07O" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C29091F00893; Sat, 30 May 2026 20:44:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780173878; bh=E60/PJE2WKp8w/h+GMwpXV+vokSE+dnbcL27XuFG6FA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=mYTrT07OqLL/eHGT4iTy/Ja6f5G0M6NVorMlN2GRSwRtTZlm5Yn2wSC7mXmkh6y8b ZymCA9kvl7TN7ef1V0ypjCOCdowkCMnKLh9HCMEIMpLiVwDOM/cyisQ2MeGFoGuZbd 4kOGMakA2lIPnOPiEh5gqmfvu26pEq0K3ZLaQpA4p8WM91z1yFGi3EgVX0dJCvbZ+V PERFgZQQNTjBzswEZkB37+5/01WzOTpSCofn8QBLH/au/iJ5Sjp52DEpdIMbfAERNw x0QeeBNtLZ3XK7wgbLFUThnj8gh9jcL4iq4HNWtQhAxZJ4xbXNimR4K4ku/vNzWZC1 MNZNlPDU39i+g== From: srini@kernel.org To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Bjorn Andersson , stable@vger.kernel.org, Dmitry Baryshkov , Mukesh Ojha , Srinivas Kandagatla Subject: [PATCH 2/8] slimbus: qcom-ngd-ctrl: Fix up platform_driver registration Date: Sat, 30 May 2026 21:44:15 +0100 Message-ID: <20260530204421.116824-3-srini@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530204421.116824-1-srini@kernel.org> References: <20260530204421.116824-1-srini@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Bjorn Andersson Device drivers should not invoke platform_driver_register()/unregister() in their probe and remove paths. They should further not rely on platform_driver_unregister() as their only means of "deleting" their child devices. Introduce a helper to unregister the child device and move the platform_driver_register()/unregister() to module_init()/exit(). Fixes: 917809e2280b ("slimbus: ngd: Add qcom SLIMBus NGD driver") Cc: stable@vger.kernel.org Reviewed-by: Dmitry Baryshkov Reviewed-by: Mukesh Ojha Signed-off-by: Bjorn Andersson Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/qcom-ngd-ctrl.c | 36 ++++++++++++++++++++++++++++++--- 1 file changed, 33 insertions(+), 3 deletions(-) diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c index 428266949fdd..47ba9fb34d25 100644 --- a/drivers/slimbus/qcom-ngd-ctrl.c +++ b/drivers/slimbus/qcom-ngd-ctrl.c @@ -1560,6 +1560,13 @@ static int of_qcom_slim_ngd_register(struct device *parent, return -ENODEV; } +static void qcom_slim_ngd_unregister(struct qcom_slim_ngd_ctrl *ctrl) +{ + struct qcom_slim_ngd *ngd = ctrl->ngd; + + platform_device_del(ngd->pdev); +} + static int qcom_slim_ngd_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; @@ -1662,7 +1669,6 @@ static int qcom_slim_ngd_ctrl_probe(struct platform_device *pdev) goto err_pdr_lookup; } - platform_driver_register(&qcom_slim_ngd_driver); return of_qcom_slim_ngd_register(dev, ctrl); err_pdr_alloc: @@ -1676,7 +1682,9 @@ static int qcom_slim_ngd_ctrl_probe(struct platform_device *pdev) static void qcom_slim_ngd_ctrl_remove(struct platform_device *pdev) { - platform_driver_unregister(&qcom_slim_ngd_driver); + struct qcom_slim_ngd_ctrl *ctrl = platform_get_drvdata(pdev); + + qcom_slim_ngd_unregister(ctrl); } static void qcom_slim_ngd_remove(struct platform_device *pdev) @@ -1752,6 +1760,28 @@ static struct platform_driver qcom_slim_ngd_driver = { }, }; -module_platform_driver(qcom_slim_ngd_ctrl_driver); +static int qcom_slim_ngd_init(void) +{ + int ret; + + ret = platform_driver_register(&qcom_slim_ngd_driver); + if (ret) + return ret; + + ret = platform_driver_register(&qcom_slim_ngd_ctrl_driver); + if (ret) + platform_driver_unregister(&qcom_slim_ngd_driver); + + return ret; +} + +static void qcom_slim_ngd_exit(void) +{ + platform_driver_unregister(&qcom_slim_ngd_ctrl_driver); + platform_driver_unregister(&qcom_slim_ngd_driver); +} + +module_init(qcom_slim_ngd_init); +module_exit(qcom_slim_ngd_exit); MODULE_LICENSE("GPL v2"); MODULE_DESCRIPTION("Qualcomm SLIMBus NGD controller"); -- 2.53.0