From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8C313233E8 for ; Sun, 31 May 2026 05:55:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780206938; cv=none; b=geeEIL+X/rV39/VyX33CpFvvWGIWylnD0rovwVmxHeg8tQ+IKl5QrjGAn3pPhKuceQf4IZkX6dE1rJyg78QuvApWElNNAVrVQyXDjN7sufXfF9TNoCUcv9LnE3H+oasD+/v7hyopRodZ3zZWGpO8EsTGGb7/bkYTu23IMBUOXzM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780206938; c=relaxed/simple; bh=bVPxoi85jbZFO9af2Hg2HjePj0L5XNSg5j6catQYaJw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DYxwqr1+w9A+DVElOFjSDwpzTScxTP4JelakZRaVcZDkmpl4woz7emOhKMJasVeQ+ezvMmdp5odyabHfDej2c515s72tZ9cL9a8BpNg3JkhoOZCCVY8lTYUJNMzl2FfS1/eEv+fdMDYsNiE9WcRG9zAKXOhn0vvPw+kXZKf0zb8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jffAadAE; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eCdLUOKS; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jffAadAE"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eCdLUOKS" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64V59h3Q701184 for ; Sun, 31 May 2026 05:55:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0bP38xOel7Wb7+m5gMySSFSDl94pHOR46F+B0I+Gh0Y=; b=jffAadAEzOpKIi7d b9X0gR2i7tkBD8SGtjY6kjv7S2CcFpxdE0fIYM0bEaoHbdClzUTUWKe66wiKWSny XJ73AFe+qmtoddOuZeFe3c1EuGu7+uHWUmldYJpESXQ32wZ94vmDIcTz0ehi1sFU peVUaGggejxNE04boNZpDZZDET+6Jx5V7rxtUslVdafSxgfXyEcCkCqqZCpoxhg9 SlsBD/O1jhSL5t3Ky4nGOs3XIma90wia/wEjqUFyJGiXlPP5DXuAjjUCKbHlvxln SgATFDd0ve3D0rOJoAt8p+HWsjLhpBTwMcgu+CXjo7yJeQk1fuYlx+LfGZWhM2yj 38V5cg== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4efxy7t37x-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 31 May 2026 05:55:37 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2c0c272e532so3386145ad.1 for ; Sat, 30 May 2026 22:55:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780206936; x=1780811736; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=0bP38xOel7Wb7+m5gMySSFSDl94pHOR46F+B0I+Gh0Y=; b=eCdLUOKSJ6Wh6YKqhcVAdTLkpAmy3WMrZb7cRdkvkQtBVsOv3buCMMS2I1+oeiwLgc H9YwwIBxONYG9NJuI5664Odv4MrolNt/3dSjDMqcaMUfhxrScFwc64qKrip3Djj2ntId j90mESU65BS0/wYoGED5qMiwU4ZPtY6rQsI60XTbrYQxzo8RsseXkzU0k0piLZ187KFz v2phfrNDypeWsu3TwqDlUdR6DKTHKoUxOlOvYKWl/bEpbTw8cf994VtwGYIGq3E6bTW1 poTd5+AJBz9LuRhUHuqLUs7gFFk6NS+oM/mrNsK8KoQ3oq2Jt4xuukzigpovYTsRetnD V0sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780206936; x=1780811736; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=0bP38xOel7Wb7+m5gMySSFSDl94pHOR46F+B0I+Gh0Y=; b=bcYwXRp9aoaFiYra/gJZoJzIr7sdcKHWoKCRwpW3OVlQgeMXExXBcn5/s86RutqEuX ntuOUE4WLwUlRSf1z84CUx759WiS3wLUmPbIVZvxFbAysfKQhh7h5FNlipNyilTx6ZI/ xcT5Gb4/dMhWGSbxZocNxz2ttAfUBwT4fsnliiZHTiOWZI2bOraBTVXJRX5RHuO4fEqA bjYTqpCxZ9IN9wcFr6wFtUq8URwyDp7XxYZuqaxmiQvK15peLJa0XoCDWIqNayI/NBZo muAQSCUqA7wzcXqra7FmnZIjGcDu3HPxPgu3CFjsSqE2+pglEZqFiKxiG6ux3V4gW5cu FYrw== X-Forwarded-Encrypted: i=1; AFNElJ9v92Y6lZy3atn6mVcx4LxwIVbQbbNzWwi0ZqzDLqnRU7/kwE6flhSk1tPZh5fj5OI0sMWjf+DObmtuKd4=@vger.kernel.org X-Gm-Message-State: AOJu0YwnFBhC7jg6BpwOaHWmzo23OWHasDaXfUENWMnJsRFIHE+nBQZz iSgAbPwBdvTYyUSgTlLXkUg7BftyJrUQCFiCMdSaGUNRoj2tgb76VL7j57NRCCn1bfu8jo47oby OH9zpRPy/aA4SxmdnwXqRoX/RjztYCvAs8Ukg3Y/fH+uTxAA3ZY00IwlDefsXrvTTIlU= X-Gm-Gg: Acq92OFdtRD499Wp7I9tl0vEt7GsFjtj1IQsbOhGdWegKTUOidylttzfocV4g599ef7 YV2PK8u9wsxvnVuX+eodJ6QnHQ0vKG7YvxHM+ppWVf3D5QcBXis1N/i3SqN5RUwmq53PqAHhXN/ HNE+5NG+PoSQ6/sh4Iyw+C5IYMwyd3jjT0dbyRSUvcezZM/fb6+uPV9FWckS6bnxf2AVWPJOwKd uIsn8O7pkNdWt/3K00jnn5kCecdaJzb419H6tq1+eaxwIPuJRFH3mqZyAuMkkqTYQ6ZBjsyHKAY ic8kZZVKYGIpZd4xGpHS3YNfmljyuI8vLFXHlo61HDIsc0RIITCsMsa/7WYCoz7bizcT38sJhtD 5Ho/jxplMX5LbzCniu8Df9Hg7AXqHUM3yi57IDpoLq1gFElIc9ZPMa7l+jjmhKTjiJQ== X-Received: by 2002:a17:903:1c6:b0:2be:1c3c:72ba with SMTP id d9443c01a7336-2bf36877582mr69541555ad.32.1780206936351; Sat, 30 May 2026 22:55:36 -0700 (PDT) X-Received: by 2002:a17:903:1c6:b0:2be:1c3c:72ba with SMTP id d9443c01a7336-2bf36877582mr69541295ad.32.1780206935919; Sat, 30 May 2026 22:55:35 -0700 (PDT) Received: from hu-bvisredd-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf239e702fsm67124375ad.4.2026.05.30.22.55.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 May 2026 22:55:35 -0700 (PDT) From: Vishnu Reddy Date: Sun, 31 May 2026 11:20:36 +0530 Subject: [PATCH v3 2/7] media: qcom: iris: fix state-change debug log printing stale value Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20260531-iris-code-improvement-v3-2-4c699c3dd719@oss.qualcomm.com> References: <20260531-iris-code-improvement-v3-0-4c699c3dd719@oss.qualcomm.com> In-Reply-To: <20260531-iris-code-improvement-v3-0-4c699c3dd719@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Vishnu Reddy , Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780206921; l=1345; i=busanna.reddy@oss.qualcomm.com; s=20260216; h=from:subject:message-id; bh=Uq29RriGWpbhBmOAxORGoqBD0WkHutgpBJXYyBKyE+o=; b=rQ1wFVhrzKpX8UHQdt+tbafWMw7piYPyv23/irop9qOXHIN6lTu8pOwBn9djV1SJY/P3OynUd pAI5c0BEm1ECcW/Mq8LOmwDxRzkN/o3mqWum2ZHCXY1SeeMaMltKMjM X-Developer-Key: i=busanna.reddy@oss.qualcomm.com; a=ed25519; pk=9vmy9HahBKVAa+GBFj1yHVbz0ey/ucIs1hrlfx+qtok= X-Authority-Analysis: v=2.4 cv=POg/P/qC c=1 sm=1 tr=0 ts=6a1bcd59 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=iF4bBz5rOIv4ZkufqEYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTMxMDA2MiBTYWx0ZWRfX3udAM8i0CkQ/ FaataHlpUumiZp/xPjsJqf9FXDeHM4ISiV/NfDoS5ghIvFtaFaiCX/tTmaZ0fUKpz1McVLz0Qm5 +13D4bFkXU1/S1Dxe/2I1Wq/OnHJVvjHDsiwpzzrV/jj2uBOIJy2JxnETMcnUlKeH56A5+VERRx BF4iNWWBLbZR9XRfB/7ScCYRBraAwxs3pzdLEgkwGxaModwL+eOEvolnkPhx94/PLrvQRoELUeG RBLVo9NocLi7gKWS9ICneOQ/3I9AEZ1kefSY8M9qgrwz+Pn1wNke/jvu2S34QeC06AlozKwbGW3 kMIm6WakgaQUtMhcB9LjIlm8n1B8+DfgOt1Xb25AJbJpnlmKJIpUCIdXlXtOO2LtD20JFj1k6ES IH3l8O74kPdbS6hXnkEggXkDRnLxWuR+ps/g1AU5girbyxIw6kNIaUugkr2axV1AqGwiWuEoqCH r90x0l9LLnE1T79zxTA== X-Proofpoint-ORIG-GUID: L95Uyb-ouXtcRwNkPjKrrPWQcVHHOk4G X-Proofpoint-GUID: L95Uyb-ouXtcRwNkPjKrrPWQcVHHOk4G X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-31_02,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 phishscore=0 bulkscore=0 adultscore=0 spamscore=0 impostorscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605310062 From: Dikshita Agarwal The state‑change debug log in iris_inst_change_state() always prints the same value for the old and new state, rendering it useless for debugging. This happens because the state is updated before the log is emitted. Log the transition before updating the state so the previous value is preserved, consistent with the existing sub‑state handling. Fixes: 11712ce70f8e ("media: iris: implement vb2 streaming ops") Reviewed-by: Bryan O'Donoghue Reviewed-by: Konrad Dybcio Signed-off-by: Dikshita Agarwal Signed-off-by: Vishnu Reddy --- drivers/media/platform/qcom/iris/iris_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_state.c b/drivers/media/platform/qcom/iris/iris_state.c index d14472414750..e991f34916ec 100644 --- a/drivers/media/platform/qcom/iris/iris_state.c +++ b/drivers/media/platform/qcom/iris/iris_state.c @@ -60,9 +60,9 @@ int iris_inst_change_state(struct iris_inst *inst, return -EINVAL; change_state: - inst->state = request_state; dev_dbg(inst->core->dev, "state changed from %x to %x\n", inst->state, request_state); + inst->state = request_state; return 0; } -- 2.34.1