From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F4447DA66 for ; Sun, 31 May 2026 05:55:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780206944; cv=none; b=YUHE6SWVKd7Zpf/9IBoa52C/dMucfkZrX5LpW6soHQ7VWu9+ettqHNr6KIpJENLzCWBv+ZL+8aA/+I3G8U2IY/skACxsgiVajd4bjpw4LAoc78dUjas+jv3y/Xxg0krYKXW8sj1fQA3SFraephXpjyxzZtToF/0OYJvSvBFKHII= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780206944; c=relaxed/simple; bh=XrExrogGyNY8zefzhUS+pWbzmqCVYgThgf2zASOamL8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MJNVY1xrvNNfgzZbqTpI1vxvs2r5SgzVwkRBI5VSM35w9hTu4PGYVuW4+zQeEN1jmp37Rmpa80RX+vuyZSDb2SdSBO9luIhfxzmOcyRiM43E5KJnlbOnH2gImPk9+WdjF6nbskPQIHN61PeT8/gpeuDblfMmAW4/N4KaVHUII94= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Z9335Ei2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=g492gi1u; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Z9335Ei2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="g492gi1u" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64V1e1cG235321 for ; Sun, 31 May 2026 05:55:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EdKAn8ifT4fLcJXnkTbDem6y66hxcJsOU6t0kTzLNac=; b=Z9335Ei2cE9IT7R9 B0ZWeVG8LC/oACCwxbnVG8y/sXZ/gVBXtRY6uGKvKytbQnQ5ug3C0P7cFndGKcqP qRvGEPAfKqfqn0B0oVEmDmHuPM4tGbr/MPNvHJXZZecJpPUIloTPqpbDna7860fS UUDRIb1Grt0YbJkM+oP+RpCOmm1JOEqHJKwnancsZvNe2UzAVPJhm969c3QGMdAO Hi7xlQke/qodnS9rjpNcWWR853coBFEd648QDvz02tjQrZ/Q23hGSHhvBZJ5Ybaf 1InvIpFl5hZZ75pPUafHo1gE6kmsFwxwBA/siv7lz3if7lF3D5i4fgb6K9h1wuO8 59GTeA== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4efn8pkf5h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 31 May 2026 05:55:42 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2bf32fb7cb2so10635635ad.2 for ; Sat, 30 May 2026 22:55:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780206941; x=1780811741; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EdKAn8ifT4fLcJXnkTbDem6y66hxcJsOU6t0kTzLNac=; b=g492gi1udpsyo/idnz5wAVzOUBoJkr9yrDpdzufOjg2OUHG4cWjse7wQe+DSBnPqQm P5kb6UbArLyuqQFaJykC6iKOh7O05wt86vXj0eY5snuj3FYOeGkFLyxQzsVEt7bVM0Bc iEAAHUtI4c2ME4ESCydXAmWpHx5/xwyZehpti23ZZp9FhJAwywnBYnYtFgZJcjwz8TwZ lpVh/uZqSV2Du04PDATrJ/u7gGXK8X1LbzggVAm8GTFNe9HV45qC6FQL8vS1V4qvOXFe owln1XxLh6XmrpPC/I8vvO1S6ZCuevvVqR5VG7oYUiOHQ1igODYRc9qL1wzlW+x2wdpW YqOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780206941; x=1780811741; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=EdKAn8ifT4fLcJXnkTbDem6y66hxcJsOU6t0kTzLNac=; b=Prh0CLQ+fpCv3QPgJXjHeZIMij0qiOE7/6+b74euByaL+46Vm5n57ToXnj0SANjtF5 GKrf2ER9UfWIEo2e/pJezBE2ttxjy6SDe3ICLhx8B95T660gMzM5V7ZhdjGq5JxGcUoU decmh8NEiC49pEhm9Sj8Obcb93cLOfWNojXMhAus0Rx3/Z5tVK1T6vpufmmuPscIIQj6 dI0+VYs7P41mdDC491hO2w+siuBPcWzdfw8ey6wQlaCrnUJPMidqXTsBs1/5sRzHNMg+ WBrme2MHOtL1xHGu2SX/BsGgqJb38W9+Jz/M1ezosEjgrs7oU7mBgwhZehIY5jey/2l7 asiA== X-Forwarded-Encrypted: i=1; AFNElJ9Yy2RbPHqfr2Ew0Gz6PyaqWaGUxYTM/950A7SVDHBqK7TKRsdUC/lo2i18t1xU1Dm4/MHeOZj/uEHoctk=@vger.kernel.org X-Gm-Message-State: AOJu0YxVBDEUvxRIO2ShT3pAwk1XG+6t1j2Q+7/KMK5q0jjybMFV1goF pFuGXLzy4oguNV6cC68+IK5LVjLbZtyded0eZ4NhdYlV9M5n/mJuEHL4r8VamB9U2PJmJd46v4K O5/DSbFfqLbajdJQxzGZjTJ2xZcomzYy86+6VC4brfdwv6SXsZjemclo/mAHwmrwiR2M= X-Gm-Gg: Acq92OGiD9vUx4hpipZASFzQizMbebOJQlte4r1L8PH3PttA7Iyh5wxnt03U00A0prU l6EEwF31u+f+qJkvG+y05yNIzQzoQk1eRwiICb/g1reuwON07keZJaypsOcTqlFkRleGiy2kjns od4s+cakRIp96AF0J/XkkwoToo8JsUUPZfNrZUgtx5v5X3XZCB4bzb5jmgM4QeCPy11GKk7FobH ENk9ZF8XBr13OQJiPz1ilX5u4LOFzaw+9OukY/0pP8Ullm3mmVoygu84QwIewaZJ/82lcQAkFI/ P1ocPT+rri9/TF6dV0ImseyeipK24YWqPFgfyCt7ctABK6cq1Ne5JlynyqZomFddEdraiVnEus7 9rXhadkkqWatSgtFf8nTaptF2i3I53D01IJ/+KVR8+VFY+a5xZ6o9yE404mXrf1eiNA== X-Received: by 2002:a17:902:e887:b0:2c0:a746:7aff with SMTP id d9443c01a7336-2c0a7467f47mr54864355ad.24.1780206941180; Sat, 30 May 2026 22:55:41 -0700 (PDT) X-Received: by 2002:a17:902:e887:b0:2c0:a746:7aff with SMTP id d9443c01a7336-2c0a7467f47mr54864035ad.24.1780206940705; Sat, 30 May 2026 22:55:40 -0700 (PDT) Received: from hu-bvisredd-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf239e702fsm67124375ad.4.2026.05.30.22.55.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 May 2026 22:55:40 -0700 (PDT) From: Vishnu Reddy Date: Sun, 31 May 2026 11:20:37 +0530 Subject: [PATCH v3 3/7] media: qcom: iris: Fix bitmask test in iris_allow_cmd() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20260531-iris-code-improvement-v3-3-4c699c3dd719@oss.qualcomm.com> References: <20260531-iris-code-improvement-v3-0-4c699c3dd719@oss.qualcomm.com> In-Reply-To: <20260531-iris-code-improvement-v3-0-4c699c3dd719@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Vishnu Reddy X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780206921; l=1251; i=busanna.reddy@oss.qualcomm.com; s=20260216; h=from:subject:message-id; bh=iUPNcmr9LcDxjiMweUrnUvGUJcwSJce63MellJNuucw=; b=ezIbKToaQmXP9xrtCwyXd3cvyElME/u6McvNG0gJrzRBMRPzxp9VgdhzZ1lVOin6PB/Y4Q1uf KI5UOD0wO2NDhzuNfub60AKW9lZcLUwelb8Wff/DO4ktese6hNlqfQw X-Developer-Key: i=busanna.reddy@oss.qualcomm.com; a=ed25519; pk=9vmy9HahBKVAa+GBFj1yHVbz0ey/ucIs1hrlfx+qtok= X-Proofpoint-GUID: o9S1bagrD8VKn49aHP-m4em43wOz4vA8 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTMxMDA2MiBTYWx0ZWRfXx/CtIjRDz64/ o+grNTxigbzZSUJM0FL0RR16MbpnycpKK4jeThw7t0fJTrqJ8ncYLqdxLKl8qrR+oDEYYDJ+xSr DBbZsXFYCaV/neF93zyvQNuw0lF2E1/gt69GygkwIAH4MEVwwQlon8i6wYnxwWlLWQ+Irzv29EQ A1J2mSF7dm1NIyexuxaCxPB2ZHEhkesmmZlJ6Wzgn5AMNS7/slIEdNpm2s5hxJKTgYcNlxoRFH9 eGVwoiEVEh8yCwsYWtnASu5H/mkVaJIFdZzOQJ8F/FuBQk8Rcbm1DealTLFIgFYatupbq9zzLsb aoamSmACj2silhhPHG5PK9NO1P4qKClerlQ6n36axaZE4KR2OryVmR3zcblEToUZir+e1MD0cfP K391pEwdjVuzmyP9jsr3bEkdOeVEnbp4722fwiAj/i35sdcPXpZDSl5hQV8AMV3I8sZbGHF3gcB runqB8ineB3e3GMeTTg== X-Authority-Analysis: v=2.4 cv=NvvhtcdJ c=1 sm=1 tr=0 ts=6a1bcd5e cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=qiYeaxkneK40FgSAABkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: o9S1bagrD8VKn49aHP-m4em43wOz4vA8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-31_02,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 clxscore=1015 adultscore=0 malwarescore=0 priorityscore=1501 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605310062 From: Dikshita Agarwal iris_allow_cmd() incorrectly checks a sub‑state flag using a logical equality comparison. Since sub_state is a bitmask, this allows STOP to pass when IRIS_INST_SUB_DRAIN is set alongside other bits, violating the intended drain semantics. Fix this by using a proper bitmask test. Fixes: d09100763bed ("media: iris: add support for drain sequence") Reviewed-by: Bryan O'Donoghue Signed-off-by: Dikshita Agarwal Signed-off-by: Vishnu Reddy --- drivers/media/platform/qcom/iris/iris_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_state.c b/drivers/media/platform/qcom/iris/iris_state.c index e991f34916ec..5552725c614e 100644 --- a/drivers/media/platform/qcom/iris/iris_state.c +++ b/drivers/media/platform/qcom/iris/iris_state.c @@ -269,7 +269,7 @@ bool iris_allow_cmd(struct iris_inst *inst, u32 cmd) return true; } else if (cmd == V4L2_DEC_CMD_STOP || cmd == V4L2_ENC_CMD_STOP) { if (vb2_is_streaming(src_q)) - if (inst->sub_state != IRIS_INST_SUB_DRAIN) + if (!(inst->sub_state & IRIS_INST_SUB_DRAIN)) return true; } -- 2.34.1