From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1160B3264EF for ; Sun, 31 May 2026 05:55:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780206949; cv=none; b=cCMc9hnDyBhERTIcr4AcqklK3eXvej5XCvSsAdBfyoc9qVzatQsvPjnpE/LShxft/UMWVL2KxMrXIom2USgf5jOuKiYNd/pHmSdJen12gzb5b3FpDA7fHP6qHraA/JQe3IxDwQ+Gp4haARyXjw/8Aigpk4NiW5IapRIORlp54V8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780206949; c=relaxed/simple; bh=GAAkIIXQjYZWxC6zM1mlm9QigG1B8h92fJVsYMtHq4Q=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=noUTgwFJgQoOaUDi6L1XsaTps/O5E8YfY1k68AIV2uMDiQQKPCEMSavZXcIyTRpvM4XMqkOXwmbGs06xALig/bIileMI6eZtYxoV4a9beG32YduUKA32JbRlmp7v00JJT7OmIlP20jT/NPND49h7MHu7yY5rQBin5wkA6Serh0Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kLnXbKzl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OVoM6Kx/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kLnXbKzl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OVoM6Kx/" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64V3lfNg696762 for ; Sun, 31 May 2026 05:55:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= FXD5gNIRtvmr4+Do3wK68iROsdsaJkUKKy74Ap4MRV8=; b=kLnXbKzlwyN7Ykqc yrh4wD6vfzhwZqdC9Ea9+0Ez6f3XZar9CRdsMyD6oh4Ol79sSt0fqu/Kew7hELJM WEg9tYwThhSK/3QlEKfTpzfHFEd9Wacg94nNZZ2NhrOjmeDd1yC2EUAQGt4bmK78 n1wM12IgNzIi8BA8uer46L/W+Chg+u3vd4U8nzKilhDEs9asiQ4Bt4vmq/PfXVdy g1QP4g//GarbqiTKMuSTQpeR8ZTMjRYzNAWoqZMwhs5AHCQa19rpgVowbKosjIz+ C5SpTnYsmcSkN6qOHNObDEyoHTcAVUtW+SNfLiccwQe87Rny6LlF+0LsZepOihTN nPToMg== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4efq7fayb8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 31 May 2026 05:55:46 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2bfdd99f6b7so18711425ad.0 for ; Sat, 30 May 2026 22:55:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780206946; x=1780811746; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=FXD5gNIRtvmr4+Do3wK68iROsdsaJkUKKy74Ap4MRV8=; b=OVoM6Kx/7QyN+S0TEos07JyMHPSG7ZDiyQaKD+ECnBZb6fKqJAuX9snM+/bllztx2y DyTtp+7Qnhc+p6HkqSZv2vYo+dHHAjnKqd658g6KYSZ0PBT58Hz8Iw+pBsl+7cY73ng0 17Ec2P6G59bcZ//UCZ51G4fk6oubj8Wflq9pC1jjNoOsXmflZJLHt/7Ka4UiAH6Bp7Rx wSW3AIA9ZmV8DWEvi2Q3XxxuIf59m7z7uOJsWRwkCes2xjeutWNDETqCHx421kOXjcoG kRB00udvEIhWAsher4MXXMcKcOICXLtMYhw9+u/BPamrpAGMquQdg+Pecu+DEJg1ksTV K58A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780206946; x=1780811746; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=FXD5gNIRtvmr4+Do3wK68iROsdsaJkUKKy74Ap4MRV8=; b=VTJD7S39vtDPP1NLvOiAVOLE2T/E0yxZYCxy6jofYKtNzTMqARMdFEAXRa0/GWjej5 YgTwZLPJ2pLck5FTVbzM5NZ4kxu7skWmFutzKhObehMEtGPopwXNBHKOpBOLjqKtzp9K 5tkQ/Qrr2iEohpKzbV7jPD5+f1xQ+C85JOQKEHWZdlQ++yJxX8R7hbv+rN3ZX9KBsCBS 23cIBqnl+xjEO0+woWrUng3YeR1NpsP8+TqDct7BUVzV5EN0hLr9i0E5OM1iqrEwhbMy I/KH06o7etPe+VSKUr6cpDkgYRUf/LMmqvZZNExZiCoXJLJEr8RkWzV/MAzGqZW3Fohp DldQ== X-Forwarded-Encrypted: i=1; AFNElJ9GJ5PZff0qvLkFPrYn4jcjv/5mCAzHtjnRaQmK2p4gQ4zbQH6frMZOHzstwWRBORvl6iMZvef1wBq2v0c=@vger.kernel.org X-Gm-Message-State: AOJu0YwNKeYS+JA4FuqK6qJ199BHND8P+Zp1QVPgPuMWmQsZbAbiLqZ/ 7y5BBmkDZcHtXQBPd8nDNQm7OazlsycrlzQsJ3URQrDqWntDiPWz/1GNl5/l8rqwiUDddCZomdU lnxOtpCVzTUe5SbAduwBNdxZ3FO4kTG/JDvdcQh9SJ7V7hEAWkavcw6mA++r67rarJpA= X-Gm-Gg: Acq92OEnJO4wmMzx/Na8w35Grjx5rUkVYTxbzp1OoPXz6Ol6ty/ysIvu18Ukmd/s5U5 2VVNq0+pE8RfemDjHpNXPeDEYD1SlZbcPyG3DjTIxmpiDX7HQdMV0ttuA6ZCibHcrqq+Vy3FlcK a75R5xLjHEQBGXa+KzJMfHksS9xe7a4IXBtQEnUu02YcHW9a7WQA287GbcILo2ssDdfj4GIhw2L 3AjWnQF3+nf6oFlxpxsCueqgS9QmaL1ijWIgg047UA+VKk/JU96L1blIlmJ+D/HXiZkWsRHxcRq XHLPc+saIF3xTMAJAUQK7KXN9XELSyYKp283b7vVPToXa5Y+wWqlxMBX/k2cjUt8o1JGuSGcqPZ Ol/gsEqGuz/nsd0VB+250nHZtd+qSkOL8npwtnk9phaNsscqZvyrm7SX3X79dYN3UrQ== X-Received: by 2002:a17:903:2f05:b0:2bd:c925:3a16 with SMTP id d9443c01a7336-2bf367b1670mr72469375ad.2.1780206945809; Sat, 30 May 2026 22:55:45 -0700 (PDT) X-Received: by 2002:a17:903:2f05:b0:2bd:c925:3a16 with SMTP id d9443c01a7336-2bf367b1670mr72469165ad.2.1780206945385; Sat, 30 May 2026 22:55:45 -0700 (PDT) Received: from hu-bvisredd-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf239e702fsm67124375ad.4.2026.05.30.22.55.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 May 2026 22:55:45 -0700 (PDT) From: Vishnu Reddy Date: Sun, 31 May 2026 11:20:38 +0530 Subject: [PATCH v3 4/7] media: qcom: iris: Remove dead assignment in iris_hfi_gen2_set_tier() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260531-iris-code-improvement-v3-4-4c699c3dd719@oss.qualcomm.com> References: <20260531-iris-code-improvement-v3-0-4c699c3dd719@oss.qualcomm.com> In-Reply-To: <20260531-iris-code-improvement-v3-0-4c699c3dd719@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Vishnu Reddy X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780206921; l=1375; i=busanna.reddy@oss.qualcomm.com; s=20260216; h=from:subject:message-id; bh=aqhs4jaqkXidlgjr5SFVJnDOR/verJ9BG22AWDOERv8=; b=fBrM22ZPdY7kkmJhmuG30GdvcjhBdE1aNrF8V8DZcDUn5/mV/L0n3klpalCLskDNABeLyMmaq j3SlJUD5JI+AI2Chvgb2tcNg297mCrmG95ZGw3yXBwMxBkKgO/QesQp X-Developer-Key: i=busanna.reddy@oss.qualcomm.com; a=ed25519; pk=9vmy9HahBKVAa+GBFj1yHVbz0ey/ucIs1hrlfx+qtok= X-Proofpoint-ORIG-GUID: LcB0xM4h2rihuBPXpFki2IJKipEcFoR8 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTMxMDA2MiBTYWx0ZWRfX7NM4hklmmNM1 Mz22Pz04Mr18JntIHAz1HUQrLXzc32bWk8nm3tfWTfXRbyekdzWTV7Wj2Q6nfxW0bt6IPSC9k/U 8T4ae4bB1yG3QPss8RibMw5F8/RUIPbkuX57gjOShpCZnN+EN0zG15sAy5HxZzD0gemkvgb9Gjw lXbFpDZdIrxLFUcOCb8aliNVRfVMBH2JkwQ/QYLlQCE1G/kvB1x/xvzsjdFe49TL60pKC1k/dIx msjbZpqmXI/BQxiShSKYJ0638gyiSmjKfvPr6FNPjf/PlEgGIsTa9mo+giOOt+e6e5htUiXh2+e rgJgztWa4hnLWNy60u4XexNvmYEinNy1CwU4sYZpaiCtFFACF+iC8dMj9WrmIupcfI744PKXO/q 3bfXFcQ1vzfwwDSwu8AtP+aX5slBDTce25j0NH6bL+xYcskFpXeJ+PL6DzKrw467H2LETbO/Ctx bF4IjCT2qDDckJH6Xug== X-Proofpoint-GUID: LcB0xM4h2rihuBPXpFki2IJKipEcFoR8 X-Authority-Analysis: v=2.4 cv=XqzK/1F9 c=1 sm=1 tr=0 ts=6a1bcd62 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=7A-KeLSbcoVXy4yL1OsA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-31_02,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 adultscore=0 clxscore=1015 phishscore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605310062 From: Dikshita Agarwal Fold the ternary initialiser directly into the variable declaration, removing the dead store that was immediately overwritten. Reviewed-by: Bryan O'Donoghue Signed-off-by: Dikshita Agarwal Signed-off-by: Vishnu Reddy --- drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c index c90b22a75bc5..fe67ad0ffb4f 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c @@ -536,10 +536,9 @@ static int iris_hfi_gen2_set_tier(struct iris_inst *inst, u32 plane) { u32 port = iris_hfi_gen2_get_port(inst, V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE); struct iris_inst_hfi_gen2 *inst_hfi_gen2 = to_iris_inst_hfi_gen2(inst); - u32 tier = inst->fw_caps[TIER].value; + u32 tier_cap = (inst->codec == V4L2_PIX_FMT_AV1) ? TIER_AV1 : TIER; + u32 tier = inst->fw_caps[tier_cap].value; - tier = (inst->codec == V4L2_PIX_FMT_AV1) ? inst->fw_caps[TIER_AV1].value : - inst->fw_caps[TIER].value; inst_hfi_gen2->src_subcr_params.tier = tier; return iris_hfi_gen2_session_set_property(inst, -- 2.34.1