From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f43.google.com (mail-yx1-f43.google.com [74.125.224.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAAA323392D for ; Mon, 1 Jun 2026 02:53:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780282423; cv=none; b=qNDhKxE+sJSiCCcjFXjV2ukrwr84/7ID4Px+7c6SpO/ruHuz37I2EDjKWPZge69vME22LJ5l9HVzt3AuXA3hMcJ5D1j/Sh2sAJbOoTRYpSKzhEjI82TcVhitzxH/cT1R/IrHycHrmxQ3RWHynY4uJEa9L6Z+XzLt/b1dFTAfFSc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780282423; c=relaxed/simple; bh=6vvUpEnA3zuZyhkh5L9tx3acH0/PiR28xnODKHfdVgc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FpcvZlAOKWvLwNjxnawfxo8Q8ngKc3/nODSdrNDa3jHlwC2336r3KjPt1xbGEdred1rXUrXHXFEWt0nYFSPFW9EWnI1XLCH7WsTtfcsu/n7wK6jmDNniIkOQhS83EHWqWv1gtp/rweVJ2Mec+waQcJyPPEdxMj2ZF8jrAvlpwmo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cQ/e8QXJ; arc=none smtp.client-ip=74.125.224.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cQ/e8QXJ" Received: by mail-yx1-f43.google.com with SMTP id 956f58d0204a3-65eb226b1ceso9890481d50.0 for ; Sun, 31 May 2026 19:53:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780282421; x=1780887221; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=rgdsNgCTJpv8k0KRcqQg2bYC+LqfZpfIBBy5KwRLQzE=; b=cQ/e8QXJ1QTCAtv81BcypunUHPID91NN5YSB7l6keIrgg7A4GoUm4K2tiqKr0Vj3k/ l/rKdwOXBpwxdja8w+i433AILUmFyMZhRU0xhv3OMirrChD98plnrYO4NZXtGUjt3HtK 03umuBgyDJj1BLFcHA7MaQAW4v7ulMtYXpIcZmXSbdM/mVq+33P7e8vZDnPdrzRO8BhX r0nRwwKMURczmLXfVjd0jHA8bBmRZIQMdMzwE4OZAqgJOlRe2n02eCqz4QOLVBhZWklc knqMmTEDAQLH2Gq8NvNqlM4LuswwqhrEhRL+u1DxXqTjPAyQCTVEutNX7klYG9qhP6xq tDDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780282421; x=1780887221; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=rgdsNgCTJpv8k0KRcqQg2bYC+LqfZpfIBBy5KwRLQzE=; b=hil7jhI5U7tI5gzyqO7V3pNPs7vyckyYHDBsaDU07ZRx2B4yu5exzX9KdxMsS5u/Nd 56mNaAO2Xn+XyjwozoDr4muMfI+DX3IEG2E8sRD+aoc2Wry93kMt6nS0ymGC5e0X+zlH M+ECdbpsqYjwciGozM/d96cdumsiRR/Sc7cmBw5b1WPqzW9lV9RaSc5Ke1X++vQN1/B/ 8lhCKKUswF7ry/pb5lAnCpUrGamnBveoaah35hYn2Vij91EXwXHvzfGdInOV9/YsGFKo 5ZKH6j6IwifWqHkefrznXJK53D7GdXvqBE1iKK61DeQoIyaAo7aIOfDziPmQWOV7iLCb eQrQ== X-Forwarded-Encrypted: i=1; AFNElJ8RSuG0NsaSNq5jZ/9pWxmn9NFCvLa2JAu1vMLI688S5n6VPIIwut/EQdYtzhhcIKtgaYjey1p1NJgyzCc=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4r3PTlGJ7b/48ko4wtCpIUoJI5cOApGRteG7582tf02rosuij 7tmVLQxv2lPas5FguqXn9Th5DDJrX2Da/hfz4TYEbUqbLFepqxnMwpEW X-Gm-Gg: Acq92OEqkgeOQY2LEaiTDWksmc1j1TlmeqNFBEIy+rmM+RSpuWwxfvP2vhrjRBbqMHL IAoLBnI0sYNq2hU/n0ud1oXuZRpRoz6owdyho2Ia/GKL4aCzHIkyIyQDrrfp30VNUSJ9DVY38pK SdyPxkM5ssF3qTVCXVNXJAhWTy5OgSZ/olzpy8Nd2z5CgmXWs9NGEGYqAGcbNKsZaJkb6kkP4HX mfDDZZ4AFC+5AKb0fj75wxi/UPtg2IP5eP+nVlbaZGFnrzvS/gOiGZ0PkYobTcDYT3gzkwbvNLU Jm9PqpnVqg3DB5F3c0goPlOW+YNb7k4JSJABxqAUmuTLB5FWp8kHJSNXBfNlDSSy/RSJ0jREQvE 9ibNhUcRpJamhGfBCx5qu+xrOCX+6nCv+JlDj+NLracXeVkZy/9KIpqd0vKlZeoKMJh785tctLP +Dl5z/sAr59xD9lW4OMhNTbljwwfDh39r9drNWydT70K2Mnz4rNQ== X-Received: by 2002:a05:690e:4086:b0:660:8e05:d0da with SMTP id 956f58d0204a3-6608e05d7c5mr1635382d50.59.1780282420651; Sun, 31 May 2026 19:53:40 -0700 (PDT) Received: from tresc054937.tre-sc.gov.br ([187.65.210.13]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6606977ab05sm2952518d50.9.2026.05.31.19.53.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 31 May 2026 19:53:39 -0700 (PDT) From: Luiz Angelo Daros de Luca Date: Sun, 31 May 2026 23:53:16 -0300 Subject: [net-next PATCH v11 1/9] net: dsa: realtek: rtl8365mb: use ERR_PTR Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260531-realtek_forward-v11-1-50d60f5717e8@gmail.com> References: <20260531-realtek_forward-v11-0-50d60f5717e8@gmail.com> In-Reply-To: <20260531-realtek_forward-v11-0-50d60f5717e8@gmail.com> To: Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Linus Walleij , =?utf-8?q?Alvin_=C5=A0ipraga?= , Yury Norov , Rasmus Villemoes , Russell King Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Mieczyslaw Nalewaj , Luiz Angelo Daros de Luca X-Mailer: b4 0.15.2 Convert numeric error codes into human-readable strings by using %pe together with ERR_PTR() in dev_err() messages. Also use dev_err_probe() instead of checking for -EPROBE_DEFER. Reviewed-by: Linus Walleij Reviewed-by: Mieczyslaw Nalewaj Signed-off-by: Luiz Angelo Daros de Luca --- drivers/net/dsa/realtek/rtl8365mb.c | 51 +++++++++++++++++++++---------------- 1 file changed, 29 insertions(+), 22 deletions(-) diff --git a/drivers/net/dsa/realtek/rtl8365mb.c b/drivers/net/dsa/realtek/rtl8365mb.c index 0da048da533a..2637884fe472 100644 --- a/drivers/net/dsa/realtek/rtl8365mb.c +++ b/drivers/net/dsa/realtek/rtl8365mb.c @@ -803,8 +803,8 @@ static int rtl8365mb_phy_read(struct realtek_priv *priv, int phy, int regnum) ret = rtl8365mb_phy_ocp_read(priv, phy, ocp_addr, &val); if (ret) { dev_err(priv->dev, - "failed to read PHY%d reg %02x @ %04x, ret %d\n", phy, - regnum, ocp_addr, ret); + "failed to read PHY%d reg %02x @ %04x, ret %pe\n", phy, + regnum, ocp_addr, ERR_PTR(ret)); return ret; } @@ -831,8 +831,8 @@ static int rtl8365mb_phy_write(struct realtek_priv *priv, int phy, int regnum, ret = rtl8365mb_phy_ocp_write(priv, phy, ocp_addr, val); if (ret) { dev_err(priv->dev, - "failed to write PHY%d reg %02x @ %04x, ret %d\n", phy, - regnum, ocp_addr, ret); + "failed to write PHY%d reg %02x @ %04x, ret %pe\n", phy, + regnum, ocp_addr, ERR_PTR(ret)); return ret; } @@ -1082,8 +1082,8 @@ static void rtl8365mb_phylink_mac_config(struct phylink_config *config, ret = rtl8365mb_ext_config_rgmii(priv, port, state->interface); if (ret) dev_err(priv->dev, - "failed to configure RGMII mode on port %d: %d\n", - port, ret); + "failed to configure RGMII mode on port %d: %pe\n", + port, ERR_PTR(ret)); return; } @@ -1112,8 +1112,8 @@ static void rtl8365mb_phylink_mac_link_down(struct phylink_config *config, false, false); if (ret) dev_err(priv->dev, - "failed to reset forced mode on port %d: %d\n", - port, ret); + "failed to reset forced mode on port %d: %pe\n", + port, ERR_PTR(ret)); return; } @@ -1143,8 +1143,8 @@ static void rtl8365mb_phylink_mac_link_up(struct phylink_config *config, rx_pause); if (ret) dev_err(priv->dev, - "failed to force mode on port %d: %d\n", port, - ret); + "failed to force mode on port %d: %pe\n", port, + ERR_PTR(ret)); return; } @@ -1299,8 +1299,8 @@ static void rtl8365mb_get_ethtool_stats(struct dsa_switch *ds, int port, u64 *da mib->length, &data[i]); if (ret) { dev_err(priv->dev, - "failed to read port %d counters: %d\n", port, - ret); + "failed to read port %d counters: %pe\n", port, + ERR_PTR(ret)); break; } } @@ -1652,7 +1652,8 @@ static irqreturn_t rtl8365mb_irq(int irq, void *data) return IRQ_HANDLED; out_error: - dev_err(priv->dev, "failed to read interrupt status: %d\n", ret); + dev_err(priv->dev, "failed to read interrupt status: %pe\n", + ERR_PTR(ret)); out_none: return IRQ_NONE; @@ -1725,10 +1726,13 @@ static int rtl8365mb_irq_setup(struct realtek_priv *priv) /* rtl8365mb IRQs cascade off this one */ irq = of_irq_get(intc, 0); if (irq <= 0) { - if (irq != -EPROBE_DEFER) - dev_err(priv->dev, "failed to get parent irq: %d\n", - irq); - ret = irq ? irq : -EINVAL; + if (!irq) { + dev_err(priv->dev, "failed to map IRQ\n"); + ret = -EINVAL; + } else { + ret = dev_err_probe(priv->dev, irq, + "failed to get parent irq\n"); + } goto out_put_node; } @@ -1790,7 +1794,8 @@ static int rtl8365mb_irq_setup(struct realtek_priv *priv) ret = request_threaded_irq(irq, NULL, rtl8365mb_irq, IRQF_ONESHOT, "rtl8365mb", priv); if (ret) { - dev_err(priv->dev, "failed to request irq: %d\n", ret); + dev_err(priv->dev, "failed to request irq: %pe\n", + ERR_PTR(ret)); goto out_remove_irqdomain; } @@ -1966,14 +1971,16 @@ static int rtl8365mb_setup(struct dsa_switch *ds) ret = rtl8365mb_reset_chip(priv); if (ret) { - dev_err(priv->dev, "failed to reset chip: %d\n", ret); + dev_err(priv->dev, "failed to reset chip: %pe\n", + ERR_PTR(ret)); goto out_error; } /* Configure switch to vendor-defined initial state */ ret = rtl8365mb_switch_init(priv); if (ret) { - dev_err(priv->dev, "failed to initialize switch: %d\n", ret); + dev_err(priv->dev, "failed to initialize switch: %pe\n", + ERR_PTR(ret)); goto out_error; } @@ -2091,8 +2098,8 @@ static int rtl8365mb_detect(struct realtek_priv *priv) ret = rtl8365mb_get_chip_id_and_ver(priv->map, &chip_id, &chip_ver); if (ret) { - dev_err(priv->dev, "failed to read chip id and version: %d\n", - ret); + dev_err(priv->dev, "failed to read chip id and version: %pe\n", + ERR_PTR(ret)); return ret; } -- 2.54.0