From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BA3A351C2F for ; Sat, 30 May 2026 17:46:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780163197; cv=none; b=klXbb8R7sa3ZvhzoE1jitf6bA0i/u8biDZLQY8GB9gN/PGR/jomKM0MGZUYD+sjpTFFXX/xYG8P4/v96CaLDMTNp+XwMSw1mfL8oD2qMgbTSDx3eQfAy3lIwshfWzdyw8aGfLa/PMrS1lqdEJQuD1WK7UG6Z4UnLSX4lASMJxvs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780163197; c=relaxed/simple; bh=p9mmt+HC9BO3hUp9yEhHwEZiKKcOtn8P/wxRR15M1ZY=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=f7rn/o78HfXJq4s+P1qmKin4qlMSyM/uH/dlM834PZD1qDZWdXHsjHJRftpzgos3qcrKd9KOAG44hziqJ8HNa1TUeOLeQnHC7lz3O9lT4i9NyExIOjZyQU8KceATzf5WQFdNKmOoyOxMM6Unc/KxAtdC5ZblqUbqsE+kfzWI7aA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aX3RnmaE; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aX3RnmaE" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-45eedc94d37so1281382f8f.3 for ; Sat, 30 May 2026 10:46:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780163195; x=1780767995; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HhbZmkaWK2d+OrlQbKHk4YxAXH5lr2lMy7P+sZtQEn8=; b=aX3RnmaEQOsfwxbdzW9OMi4d6/XwsDgquP799aavhVNB76gN7UDnvAuEMH3WDT5seW TscTdzsv/twUYKOyGc9pVj93yN8zbuD/doBSiVlatuUH+M7BrFke42GOSs1CnuP6LcIn 7IGTOdTjASbK1mogXbFSgP/2ikdckz5BjMceSDatw2BO5tr7RVrMW0qxrR4kF29xAl+h tSDsuX77j1aNsSYC5EeGksYLOt4ISeEZYk58nPop93yqjfaPwvx7v+oUUkuO3Wk1kt8j 1EXVh/dX6pTayuGAEwXCEilfSXlWfEyF+bwa8UDNqCOwpSQkGRoAP3QstZZghNvCMhlo UmXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780163195; x=1780767995; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HhbZmkaWK2d+OrlQbKHk4YxAXH5lr2lMy7P+sZtQEn8=; b=q6VZPYEbNaJfrPUeAAl9LNRcfLmG/9oAqSzMna/5lXKCwpvTjDJb5RGBggd0JYTJu7 KiQyrAUGvK6yNlfAvdmAf0jcUfbxYNcvncPATSERjsJy4OWOBAPOOgasNbFazd5HPum3 f+zjwwtk0nBN6yecEYpDOnE6DLTZe3c24tijwXQrS02NMOMLMKPEdHxOEy60wW/LNnhD h/aFl4M1RzByXdy0tQfOqwaBu8LrYQ9BkxO2M01d8NI53D0Tsd7Z/XA4urukOR1szzil wP9v5xSgyVqxnxP87AxBBW+rsLsr3A5sC28Luzu3ceM6sqZWw34JuVQEY/ooI3aPE54x DM0w== X-Forwarded-Encrypted: i=1; AFNElJ8/PXbMbsjfHM5jksTCpYWK6S6/7BY5R3Tv+G4S+i9Ke48XcPJtdkmXOu7+v3uGX39pxn6ciXafprqJ8P8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz//uGS3sHiMOPUsb5+Xb7Bu5BAp1Xq3wguw4Du7TvJXPIaJdIY kK9FAHVVCa6hy3OCEw753tU+UrKn6o2EzrmlzqQW6nQmN/T5jR9abIno X-Gm-Gg: Acq92OFJidrmXzM3VIMX2PzMyhQIflpvZtQLEsrHCDp+KkUxIbLzTlP2DtqXfqAZQe7 q4bVE1fb1MRPoxhSXbeMD3etHIIyqEiUce8YkTHUwgq9MoHyaIDDGTzd+uBqA35ZoO/lWJSq7Z7 Gfbef1WaqRfK5vRooqfUaIwx7vJO3EvbzM1c8TeDJXNWPBN8jZf3WqKAPAnBuMSfbnlMIXQFTUY iHjNnklUiBO6u42fdrI5YCJWLGwF4dt7KWEFGkSW4SdELU79JLXXRYkihzAw76bLLVOYnNYfptD ULRnpjsxJSWQzbzaQMWlKMWt3rIAuA63PvjFGXgVzKbybxWV6H12yGCXSaQuyz6EM3tOrvzuyT6 pH0LweRfMhpCajS0YFQRmGtkU4hWZr6O9BCvCOrUtrte1vZsx/v3hyDkpUcBw9Fq9B57gN/F+Rx CZHBKwgRZITMh0ovlib7Ifn+faf5+ua/nIeQ== X-Received: by 2002:adf:f190:0:b0:44f:9b70:2996 with SMTP id ffacd0b85a97d-45ef6b4f4f5mr5775458f8f.21.1780163194681; Sat, 30 May 2026 10:46:34 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45ef354cd7csm12052902f8f.18.2026.05.30.10.46.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 May 2026 10:46:34 -0700 (PDT) Date: Sat, 30 May 2026 20:46:31 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Pavitra Jha , idryomov@gmail.com Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Slava.Dubeyko@ibm.com, amarkuze@redhat.com, ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Pavitra Jha Subject: Re: [PATCH v2] ceph: fix bare ceph_decode_8 OOB in decode_lockers() Message-ID: <202605310022.LGyGb8eD-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260528132521.843004-1-jhapavitra98@gmail.com> Hi Pavitra, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Pavitra-Jha/ceph-fix-bare-ceph_decode_8-OOB-in-decode_lockers/20260528-212749 base: https://github.com/ceph/ceph-client.git testing patch link: https://lore.kernel.org/r/20260528132521.843004-1-jhapavitra98%40gmail.com patch subject: [PATCH v2] ceph: fix bare ceph_decode_8 OOB in decode_lockers() config: um-randconfig-r073-20260530 (https://download.01.org/0day-ci/archive/20260531/202605310022.LGyGb8eD-lkp@intel.com/config) compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 smatch: v0.5.0-9185-gbcc58b9c If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202605310022.LGyGb8eD-lkp@intel.com/ smatch warnings: net/ceph/cls_lock_client.c:313 decode_lockers() warn: missing error code 'ret' vim +/ret +313 net/ceph/cls_lock_client.c d4ed4a53056288 Douglas Fuller 2015-06-29 288 static int decode_lockers(void **p, void *end, u8 *type, char **tag, d4ed4a53056288 Douglas Fuller 2015-06-29 289 struct ceph_locker **lockers, u32 *num_lockers) d4ed4a53056288 Douglas Fuller 2015-06-29 290 { d4ed4a53056288 Douglas Fuller 2015-06-29 291 u8 struct_v; d4ed4a53056288 Douglas Fuller 2015-06-29 292 u32 struct_len; d4ed4a53056288 Douglas Fuller 2015-06-29 293 char *s; d4ed4a53056288 Douglas Fuller 2015-06-29 294 int i; d4ed4a53056288 Douglas Fuller 2015-06-29 295 int ret; d4ed4a53056288 Douglas Fuller 2015-06-29 296 d4ed4a53056288 Douglas Fuller 2015-06-29 297 ret = ceph_start_decoding(p, end, 1, "cls_lock_get_info_reply", d4ed4a53056288 Douglas Fuller 2015-06-29 298 &struct_v, &struct_len); d4ed4a53056288 Douglas Fuller 2015-06-29 299 if (ret) d4ed4a53056288 Douglas Fuller 2015-06-29 300 return ret; d4ed4a53056288 Douglas Fuller 2015-06-29 301 d4ed4a53056288 Douglas Fuller 2015-06-29 302 *num_lockers = ceph_decode_32(p); 69050f8d6d075d Kees Cook 2026-02-20 303 *lockers = kzalloc_objs(**lockers, *num_lockers, GFP_NOIO); d4ed4a53056288 Douglas Fuller 2015-06-29 304 if (!*lockers) d4ed4a53056288 Douglas Fuller 2015-06-29 305 return -ENOMEM; d4ed4a53056288 Douglas Fuller 2015-06-29 306 d4ed4a53056288 Douglas Fuller 2015-06-29 307 for (i = 0; i < *num_lockers; i++) { d4ed4a53056288 Douglas Fuller 2015-06-29 308 ret = decode_locker(p, end, *lockers + i); d4ed4a53056288 Douglas Fuller 2015-06-29 309 if (ret) d4ed4a53056288 Douglas Fuller 2015-06-29 310 goto err_free_lockers; d4ed4a53056288 Douglas Fuller 2015-06-29 311 } d4ed4a53056288 Douglas Fuller 2015-06-29 312 cff58e4599d8e1 Pavitra Jha 2026-05-28 @313 ceph_decode_8_safe(p, end, *type, err_free_lockers); This macro has a goto err_free_lockers but the error code isn't set. d4ed4a53056288 Douglas Fuller 2015-06-29 314 s = ceph_extract_encoded_string(p, end, NULL, GFP_NOIO); d4ed4a53056288 Douglas Fuller 2015-06-29 315 if (IS_ERR(s)) { d4ed4a53056288 Douglas Fuller 2015-06-29 316 ret = PTR_ERR(s); d4ed4a53056288 Douglas Fuller 2015-06-29 317 goto err_free_lockers; d4ed4a53056288 Douglas Fuller 2015-06-29 318 } d4ed4a53056288 Douglas Fuller 2015-06-29 319 d4ed4a53056288 Douglas Fuller 2015-06-29 320 *tag = s; d4ed4a53056288 Douglas Fuller 2015-06-29 321 return 0; d4ed4a53056288 Douglas Fuller 2015-06-29 322 d4ed4a53056288 Douglas Fuller 2015-06-29 323 err_free_lockers: d4ed4a53056288 Douglas Fuller 2015-06-29 324 ceph_free_lockers(*lockers, *num_lockers); d4ed4a53056288 Douglas Fuller 2015-06-29 325 return ret; d4ed4a53056288 Douglas Fuller 2015-06-29 326 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki