From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F060364053 for ; Sun, 31 May 2026 02:06:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780193161; cv=none; b=WrN8KycbJmd0qgwj0YnkVM7Q5pUl5R26inj/oLUjQyact48eQif8FL+7QCyve74Pihn9JojW/tMQufTjWjqkJU4uugcdUxxAYPvCnx0BemTUP0/z0Edd+pi3CeiC8gSbwj8eltS4iy9niiCB9ng0mEvFtVaSJ2cFIsDXmsHe6/c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780193161; c=relaxed/simple; bh=IQfxgm2MWgvf9AN1+HadB8z6n3kjnD8BRuJ/NOZfTVg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=X0N0yI2GBAMwKNhS0yE5WDKqtrB4XnvYgmF6m7xx6qSPJU2R+rW/JDLj7+VZm/FqNLbED2VM53Ojew8k5CaAN/HyWqKK01oWIQDcz2J5joWgGrtowcxtecx0TNd7skOHAED8NcV5Og4VTzWBxvlM5AvgdFOavg1XWQb1ihRgrSc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MInsIqZX; arc=none smtp.client-ip=209.85.222.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MInsIqZX" Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-914b4be9c4bso822463385a.0 for ; Sat, 30 May 2026 19:06:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780193159; x=1780797959; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ev7p7h9heSSNp8XX7uho86JPebrwudJ97FaZXIjk1zc=; b=MInsIqZXa3920VX9ttZr3tTamgorsxkFsXj3sLsA+1PxzSoK5qBV39iBP9cbtW4VvS COaETIHJRwj2ZJ1M4NszFy4U/gLWQszUY5vzimFQX1mdF5lJD4kvhBZeZpJpZQ2Qc7j9 Aizv8xOHqTbdyFPT6R6tOypxpGtsuR6ArETUT3R00jjMN1ntlhdHEvHZj1yFEWJk1LUx /L1Hnfsq9hG9xs4lYs0qjHf248h0PcrjTpG6DirrJrpR4zrIzBzoxqpTdVh/OSBs0b93 lE7ebQEtRZJlStchWChL+PAKyg25MbF6+gv+gqla/6e6VVqfZwLuu8sPe6soAL4lek93 cEhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780193159; x=1780797959; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Ev7p7h9heSSNp8XX7uho86JPebrwudJ97FaZXIjk1zc=; b=suZRzSUk1W42SQ4NkSNg8LR1gj3pViuhhuvq655WKxiZ2bAqSSNrbMfY2zLT+cYmcq N1h50O0J1lB234Ar+GwmQGlnFPzbVPDWXAbZ7g8c5QWWKTGcn5x1K/eBF9W7o62Oq86U aFKn7L79SIBr7UsSoLwlnWbCjak65BzgWfnWiqJMfd8xYq2wXmUKuwHHTvZfI9Ud4c7B fDl6lPG0ROpi2Q0CJ80Fo4He37ZxysVlfr9pVyYBsOP5QBRfUxyd0u5fIuuNoJnjh2sy xxt/81iY31rH7YflX8y9uEqEJe0SmdQcerZqyy0/Ja0yotR+qESeU+Ga+pDO7qkh/Izo 8c4g== X-Forwarded-Encrypted: i=1; AFNElJ+r+lkWpWyL4HxynVmV/GwiWWmxdWThkxaGNzFe1pMdXiXb06pMbnxKB1y0SVoHIk/AR120Z+Nngjcoytg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5m058GyR5lUxO8MEvq/33M9F1qXkYR44KEyl88q6/fgyRYyAX gVax74A8n3PVzZMT8X534OWryXTdOc1lnAn0vDXOKqvoVEImS9OFxSC6 X-Gm-Gg: Acq92OGCfOZJ4uM2ksDdWgo3nv2FVnY3dyGstlUojRAnbwCHCKf51F6PGYsgTYELtCs nzlV+r2/V1LTRDZrmXeN5AkLDV/TELRPLJZN7RgJyqfcM2KPatNgZn46GQvW94PxQoTYlayvBoF Vmb7NlIgXeWj/Gb1SDK+1VNaLSUNHTjaeK2bSg9LsrQFOJNN5WPhsIwsjNhmkgb0Wj75Kqh2iKm FPi9M9oRIvUWUqaLrO8qtZgzvv8RQsRdodWUCJKWu+LciBlzzfk4uVKs+vrOkRPLS8xZcvgm8xl j/UXdfq4xM8KOiHZtIOZ/b7Dg1zqWznHKl6+TSD0Lovj0vzioV7UMdcMaY7AxnRY4GRq6ZCfGCE lWWNGabNwLEyZMscjV859XSXhwZSizBES5lzBSsrKnZ2GUG/3eVD+v4UwwMSPj/kc7X/I+pwuCL sUyFMtvdB4uTqk93azxf3slJN1V4mC2u6g5IXR+YAx+faRqas2hi1mzPzLkHjuVZW1ErA37QH3r Rj0psF/l5030lxCShj7B0Hx5tZYN5E9OFpsxrDn1d/6sA== X-Received: by 2002:a05:620a:2610:b0:8f8:cdd0:df82 with SMTP id af79cd13be357-9153dcb4b99mr938551185a.58.1780193159498; Sat, 30 May 2026 19:05:59 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id af79cd13be357-915324745cfsm620246285a.12.2026.05.30.19.05.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 May 2026 19:05:58 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Peter Ujfalusi , Vinod Koul , Frank Li , Haotian Zhang , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 2/4] dmaengine: ti: omap-dma: fix notifier leak in remove Date: Sat, 30 May 2026 19:05:33 -0700 Message-ID: <20260531020535.594460-3-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260531020535.594460-1-rosenp@gmail.com> References: <20260531020535.594460-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The notifier may be registered for needs_busy_check (omap2420) rather than may_lose_context (omap3). The remove path only checks may_lose_context, leaving the notifier registered during driver removal. Check both flags. Fixes: 2e1136acf8a8 ("dmaengine: omap-dma: fix dma_pool resource leak in error paths") Cc: stable@vger.kernel.org Assisted-by: Opencode:BigPickle Signed-off-by: Rosen Penev --- drivers/dma/ti/omap-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/ti/omap-dma.c b/drivers/dma/ti/omap-dma.c index 0f6dd6b0a301..839e04f53fc2 100644 --- a/drivers/dma/ti/omap-dma.c +++ b/drivers/dma/ti/omap-dma.c @@ -1853,7 +1853,7 @@ static void omap_dma_remove(struct platform_device *pdev) struct omap_dmadev *od = platform_get_drvdata(pdev); int irq; - if (od->cfg->may_lose_context) + if (od->cfg->needs_busy_check || od->cfg->may_lose_context) cpu_pm_unregister_notifier(&od->nb); if (pdev->dev.of_node) -- 2.54.0