From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC1E8364047 for ; Sun, 31 May 2026 02:06:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780193163; cv=none; b=SgV+GTCHOS0Gxp9GJ9ywalAMicaXZkJ4OUbUuiS16Eqe0ty9luRKWZTen7Sgtln+bfQD7CpNxotYsd1BdBDQNWIhnzjpkHrRqiES1hsOpZZijpsWAj2CaOBR+KqLjPwJIW4BK1144AlQzNu7N4CZ0NvCTzwG4+Z2iqeOVfnz124= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780193163; c=relaxed/simple; bh=J6YChUmyD3xRmPfZq01QjdSSzKNUlsorT+F2G536OjQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TZugxX5bw/p9QADnvZ9o1IqeBBxjUPojxVLtUdDFY0o6s+Qwp1m6ZImRDWKiGCEdxtfBZkbuEfrhfsxDPu4P+AzACZO8ft5LhWHqaDYcrYKVYznoofMplZSOHZDotYvyk7MT4I/wmz4PCLJPQllVRTgFdFnCtjlYMkrb/Iy6RCg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=o1VXEde0; arc=none smtp.client-ip=209.85.222.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="o1VXEde0" Received: by mail-qk1-f179.google.com with SMTP id af79cd13be357-914bd98faafso674793485a.0 for ; Sat, 30 May 2026 19:06:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780193161; x=1780797961; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0/Rv5j798E/wJxW6Lz2s/cY52hep39bRvHPoM4YeyHU=; b=o1VXEde0wIndEwV76+95gt1fjsFCE5UiHApVkpiM9Id5iueWU/TBewDHouLwOzFM0h S80zJzquY4Fx0qnFiNgy+4VBRmMhMzkyjT0HhjfKsIO+ccyGfCh2U1YUeo8yckqZpgab 2WqQiCNiBR0UOhiWIRmr36fJBCrz1pBxaElBHHNyVSjl/eA+wczK461cxGHls2wOgaoO uyd6AwsqOIPxZlqRhjgVmDHjy+wkHGGPSGEQE1DAIufzpJzvairr7Y9bdufA42RWLezt CIsGwFpk5x5DqVdGFmRq5X0C5L8ZXdi8EH6RqSv4hmMi5sg7IawIlYS2ITWyg40i87Ba kN8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780193161; x=1780797961; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0/Rv5j798E/wJxW6Lz2s/cY52hep39bRvHPoM4YeyHU=; b=bnY/Zxh8JNF+RHSL+iMqyh6PKY+aEBUg9+3d2HvJrZkIjRVjh+icUKlEGwZAKKiUpk hih1cBCs53O7b0pAy+yJ00x+P0JxWYZU7/GxlM0xyeIgy0qTLg5b1iwFtNwUquGxquIJ MdiQNXAlZxNBAa6t7kA7x98qSYbA4/B7PSF5rDFKMp5ZM1YhMhaJljhIaMq/meUWPHRi OK78X/mA7Mtn1vE5J6ok/KmG/0fmJtIwWc/u8L0LJu2oWU9cXmY6wkuvPWNSzl4WtiP8 Q4NJTc3Ur+S0cSqigXt87ZKew72wWm/tmMaJK4+2Z4eNfkXjClvTbJ2jzKaTijN6IERI LGGA== X-Forwarded-Encrypted: i=1; AFNElJ/HQ+tEMnmdQ9cK9uXHLmrWM+srC+TmCYKMog8Rwpz/tYAFsQNN/0aB9s/6TFQ3gnH6K6q2nevJpII7G/w=@vger.kernel.org X-Gm-Message-State: AOJu0YxxXd7GCXpOwoNq/snMN7OIJ4jTdTt09YOWeho/K9GjsBadLt3V 3bjHuW5bX0RG5UWpKcA87XgwwHCHl68pnBORVv9PEn8HMUB2+eiBeLxj X-Gm-Gg: Acq92OEviPpgGilsKA8Ak+RpoPgPV1+yJcHJ/tnx/iu9Yp38sgUxPDomzxHjjiNFqz1 erOC9ekkJj8CUTHRuwwQoFEO/+CtAEtxQg+XZQobLX/nymMsVnFLMVxIO1/NMX9l9HXAcMDDTaN uI5Pchle46bhPZMrAeh35rpbkWS6WDwnQNgWuGE47bK3+WXYTgPx84hCp5nGUC1cxTicGz6n9rM dUS5EjtMpsQLoIVcusUIo2aYqEmWgUMMOj3SJvTW//OykP4/ytjVtCx8aqXojwHcueKnniBJKv1 HFsG93mpxKPuhIONvquWL9IzE8HpXtW+GYWNjcHP0fwGhGawoFjdRD9Q29csMDG14AUqLC0zU9/ TIikuIkWbJECXClXVJur5qswP3TGhWsaXsk2CM1bXX+RDA9HTek4eG2JPdnsCORfR4W8yrwrK+u q8g1zpbRJO5xzfKn3FutAdr/Upfs5kdw/uVJFbfwTPcV6abdoWTjPQL4aP9sk7dy7sSLZEsnLdB p/PtKAVdpmxhzPJzTL+yWOO5lthoDIF7DTNH88csCsTnQ== X-Received: by 2002:a05:620a:4688:b0:8cf:c106:faca with SMTP id af79cd13be357-9153d9f87d5mr879641385a.36.1780193161058; Sat, 30 May 2026 19:06:01 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id af79cd13be357-915324745cfsm620246285a.12.2026.05.30.19.05.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 May 2026 19:06:00 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Peter Ujfalusi , Vinod Koul , Frank Li , Haotian Zhang , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 3/4] dmaengine: ti: omap-dma: fix dma_pool_destroy before omap_dma_free in error paths Date: Sat, 30 May 2026 19:05:34 -0700 Message-ID: <20260531020535.594460-4-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260531020535.594460-1-rosenp@gmail.com> References: <20260531020535.594460-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit omap_dma_free() tears down channels and may free t2_desc entries from the descriptor pool via tasklet cleanup. Destroying the pool before omap_dma_free() is a use-after-free. Move omap_dma_free() ahead of dma_pool_destroy() in both probe error paths and the remove path. Fixes: 2e1136acf8a8 ("dmaengine: omap-dma: fix dma_pool resource leak in error paths") Cc: stable@vger.kernel.org Assisted-by: Opencode:BigPickle Signed-off-by: Rosen Penev --- drivers/dma/ti/omap-dma.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/dma/ti/omap-dma.c b/drivers/dma/ti/omap-dma.c index 839e04f53fc2..fd1ad3b4268c 100644 --- a/drivers/dma/ti/omap-dma.c +++ b/drivers/dma/ti/omap-dma.c @@ -1808,9 +1808,9 @@ static int omap_dma_probe(struct platform_device *pdev) if (rc) { pr_warn("OMAP-DMA: failed to register slave DMA engine device: %d\n", rc); + omap_dma_free(od); if (od->ll123_supported) dma_pool_destroy(od->desc_pool); - omap_dma_free(od); return rc; } @@ -1825,9 +1825,9 @@ static int omap_dma_probe(struct platform_device *pdev) if (rc) { pr_warn("OMAP-DMA: failed to register DMA controller\n"); dma_async_device_unregister(&od->ddev); + omap_dma_free(od); if (od->ll123_supported) dma_pool_destroy(od->desc_pool); - omap_dma_free(od); return rc; } } @@ -1869,10 +1869,10 @@ static void omap_dma_remove(struct platform_device *pdev) omap_dma_glbl_write(od, IRQENABLE_L0, 0); } + omap_dma_free(od); + if (od->ll123_supported) dma_pool_destroy(od->desc_pool); - - omap_dma_free(od); } static const struct omap_dma_config omap2420_data = { -- 2.54.0