From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75F3B376A00 for ; Sun, 31 May 2026 07:36:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780213000; cv=none; b=XFsZT7j0P0XZRe7Ms+iVIjr9KAGnSaRk9EDMgCyC2rz2o44c5OsHCdN2hDM/DO8c7QwF9sRU2Xxb+oDC5jhNTQTiuGfphHk15JxazROYN+mUxuc+YEl7Vsz0+jxLwdn8dVgr1mwa61sFJEdgvq/41Sp4KbMnzRobeJLRIlzCS5o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780213000; c=relaxed/simple; bh=ebKI7dfQEJh47/K4AATE4arzGNHHlSJ98haph6AoQ6Q=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=eEwU/MOA3Gv3V3TvrIzEjAYEbJKPjYlBY96hoeGJ48SXx1U56ig2TWPti49E19LjwM4j2seFmiuCsdH5eqjlROdtHjG9qIdlkf10STe3SBo1cF7HLIbPbOkYf7n85T1f3/GbKHybMleVbT1iXuV1tkIVErAe36FN1Ap9rFujLXg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MOrd6HtB; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MOrd6HtB" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-8424b6792efso5251b3a.3 for ; Sun, 31 May 2026 00:36:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780212999; x=1780817799; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jKPe1TO+FoogghrC8LGLLeXq7GSJc49agxpkGaHZqpM=; b=MOrd6HtBK0/IQeQjlm4gKKVuEGcoRNKERXjgp4nKEcQnFbvChRgVHjzORJELQjj8Lt WvbGHV6nzrkIkSxAfaan2VAbZowPyOQlwfieCsPd73dt7cNq36EXKIKiPpoHS+kim0oy VUCkoS6nGeWINTWhbPRtZZpqFt68CZKXIpe/X8q/c016NyCMTbTEs0+sBNJd8mVHfsqg 6l231ab4SpnxXKf9EwqI8/qtBCOObtsErzEwhtKuoC59MVeRk97oYbt8IElITjnFk157 RkRxGS1ybQTHr+Dp2DdJAQ50/jtCYk/LtyT+yp9v/rddt889nsboA4Jps7hqfVhbQxvp 7y5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780212999; x=1780817799; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=jKPe1TO+FoogghrC8LGLLeXq7GSJc49agxpkGaHZqpM=; b=QEnRrXrxi5o4pLVL2YzCbUkq0ivohYgHRLDMmiBpKRLORHV2iiPIfzZH7Q9bYQowrM 1l+q/+rixKmCZPZJeWceR+uyhMWgIGqg9jXr2dFGjghZn0Ei/28/kMtegB1JQJXRt9DC FNzrLRHyTKwAzQd3Gl5LBWf/+LuiDXNBHdfH4nC7g9F8ZI6UA9zkwKOS0vQgrxPVWBge WJaqda3hWtrSwm69+y3dV3R0XDO2iUrZbZBXJ9r1LuNPCwgFCfqqktc1i4QMTJ0Pezq7 DQUAoAq6Hd0OqQNKld5VXF1M3scbTEcw0L7dwuPd8HAQOxbR89KTFIa6yt8cDfKepaPh z0Mg== X-Forwarded-Encrypted: i=1; AFNElJ/dXywSS2BvdKRZEAl3yGp2gK1dLieCx6W2EfQodvOPhb34E0Z+xrnxIIrZl6LJQ/WKr7YR5CX4Eg5RbXw=@vger.kernel.org X-Gm-Message-State: AOJu0YxvgAyVUmHKFzI8gIyRl6S2ibJDHrY/nQ9wjq6wDmRsQ6IZh3xE i77qnFGt95DzqyvzxuRHN2juVX3QWRGSIb3vNpIn57gFV+FO7tNzGLns X-Gm-Gg: Acq92OF07ToH5iPrqIxy44HOK1qnTCgmvnO1ODjIVJENmB2CPRX8D0Urp9HoLBHE46S PVI02/py9YrTWXR/pLl4OYuLibnxZ6eANvlUHCBI4xYK91MoY9+TcOTmPRqhLksNGL03RmvSm0T THKUXZXhXbF0iqD44T//0C66nraIdvkZxet7EwiWI46bFiZNJ+/gCsWWYDFQgV/QzFqyoWVORx9 Igiy8j3lbLl17mdOdZvX9Z4DIW63JQpnV8Xru3C8xcsKhpUVtWGajh7Y/4AWsvpjaBDuWX6tt8U 7voNhuK7lp3JHGzzrCcGz3/v5i1z0U/BoXYxSHAN/lAc+rKAcRgHKSNZ8j6EJJwByQiq6PgiaYa OYQ8+jtWOSaRmtY2w1ZusYd7cBl1k1Z19728TZTEtFkKsWWOyvHjAcU8N29AduEVffjbzaXl2xW Sb8BIFLSq8/WhFA6uRYWieyO2azDRk4Soxfc1lmXodWQ== X-Received: by 2002:a05:6a00:1a05:b0:842:3373:f662 with SMTP id d2e1a72fcca58-8423374104dmr2845469b3a.11.1780212998783; Sun, 31 May 2026 00:36:38 -0700 (PDT) Received: from Naman.Naman ([2401:4900:1f39:4c4a:1e56:d301:ce43:ac25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8422e712309sm3760709b3a.59.2026.05.31.00.36.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 31 May 2026 00:36:38 -0700 (PDT) From: Naman Arora To: dri-devel@lists.freedesktop.org Cc: tzimmermann@suse.de, maarten.lankhorst@linux.intel.com, mripard@kernel.org, airlied@gmail.com, simona@ffwll.ch, stefan@agner.ch, alison.wang@nxp.com, jyri.sarha@iki.fi, tomi.valkeinen@ideasonboard.com, kraxel@redhat.com, dmitry.osipenko@collabora.com, neil.armstrong@linaro.org, khilman@baylibre.com, linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Naman Arora Subject: [PATCH 1/6] drm/fsl-dcu: Open-code drm_simple_encoder_init() Date: Sun, 31 May 2026 13:05:27 +0530 Message-Id: <20260531073532.8609-2-namanarora029@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20260531073532.8609-1-namanarora029@gmail.com> References: <20260531073532.8609-1-namanarora029@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The helper drm_simple_encoder_init() is a thin wrapper around drm_encoder_init() with a simple destroy-only encoder funcs struct. Remove the dependency on drm_simple_kms_helper by open-coding the encoder initialization directly in the driver. Signed-off-by: Naman Arora --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c index 84eff7519..a16c6013e 100644 --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c @@ -14,11 +14,14 @@ #include #include #include -#include #include "fsl_dcu_drm_drv.h" #include "fsl_tcon.h" +static const struct drm_encoder_funcs fsl_dcu_drm_encoder_funcs = { + .destroy = drm_encoder_cleanup, +}; + int fsl_dcu_drm_encoder_create(struct fsl_dcu_drm_device *fsl_dev, struct drm_crtc *crtc) { @@ -31,8 +34,9 @@ int fsl_dcu_drm_encoder_create(struct fsl_dcu_drm_device *fsl_dev, if (fsl_dev->tcon) fsl_tcon_bypass_enable(fsl_dev->tcon); - ret = drm_simple_encoder_init(fsl_dev->drm, encoder, - DRM_MODE_ENCODER_LVDS); + ret = drm_encoder_init(fsl_dev->drm, encoder, + &fsl_dcu_drm_encoder_funcs, + DRM_MODE_ENCODER_LVDS, NULL); if (ret < 0) return ret; -- 2.20.1