From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CF6237756F for ; Sun, 31 May 2026 07:37:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780213032; cv=none; b=ZxT7F2OG5Z66zuT17AqbIqe/ViCbrIcDFBOG1DaeRd4as/Ra9+OiPJEqTL0yKm/M7a8OTLeuSTqnv4A98d2Zqe7rgwZ2ub8+ZFP+No9kfplCMwD1YzgfVXz2Rtk/xgk8QLOnkGrFkABfZqZPHPjIBCK1dKBRztWOn0oXGMTNdnM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780213032; c=relaxed/simple; bh=oY+w3vSzP4EwsS3DqrAbl0ftq8sR3CTRkppY0TR5Xcw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=aVUPZCpCbMkEjC5JAbTKI+MBEmY7oe/2AedVKpiy2p4t6fI89ekMeYIQKTgSqQF/cvNU8oEbz3ShYusdfqSTQgS8x9ZXJ1zZRyvMB6hp4d4s6DENnC0xxxrfO4uGzhiCYxDF/vRm/wqyVFE2Er8yzHkL4ltPleRaieT2WoNcsPs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rCsRCbFx; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rCsRCbFx" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-c8573e75425so708902a12.2 for ; Sun, 31 May 2026 00:37:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780213031; x=1780817831; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FRd0rxdsonje9jnyvzmzGfqu89ZUVs4w1wFb8uxr/rs=; b=rCsRCbFxM1qO26dEZ8cJVGxmA2TWcRTiPhCdaBeYSBSqwBfzOlZoomVb1IkQNpre9P Dvp6Q3B2S02Xgil7pmDwUoT9YO+YjitwF0a2dMzhwWwaDdtkOhfOLo/T1He+aD6hfDRd g9i7UtniNQIwoCRE4/Ju0riOl6eaEEwjSwlygSojIWlNhRw2EGJc2Haw7P0fSlMzz/IB 9+ShnbA5c1lmZiSrtMCVEAaq990VSBuDqOnhUMUsiat6zU0gi7FM7c/IzGAN1dTBrdj6 XjVQZNdlDvd7E0d8f285VU2Dus5O50YQ5vtEUH2j97cL0G+CF2/NmuMIXDOKepCQnaCl NTzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780213031; x=1780817831; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FRd0rxdsonje9jnyvzmzGfqu89ZUVs4w1wFb8uxr/rs=; b=h9Uc4ZXJeT9R3Y0DYV+82Mr6GjZP+xbIZWoi8STOIAbZDjVeaeU/gzznLJvf1MCje0 O2/fEFJdDBhT6tKt3TG5KacdfXACwopj00mm8zFMmXJk9MgZVqr+sE6x9eDByOlQk0Wa ii8CxFsjX0Wo8Aieyf9yCMqzI4jwohyLQXErOdjumGX8c27YFlkWZY0ZlMMv0+q6vOjY zf+XkSebdrESP2yxujyzvQhNL2PVMK2UKuKBk/cIrEeV4wlTqFRZbPkg7ip1wTqkx/7c 2wKVIJSEiEic0R/LPDDx5zO3f/Sj++00KoKKCMftclcaT0cYu5Gr7E/Dv9JsPPnPqRHG zn+w== X-Forwarded-Encrypted: i=1; AFNElJ8NYOhsgWoS3ATU/oFfpuLl3QXS2fTL+vB8m4CJDh5QmVr0ebmWJiJJmV09E+Ds1AMCOSMvHNUMA6p+q/I=@vger.kernel.org X-Gm-Message-State: AOJu0YxWZN9ppn4DTMRw/kimshJW8b5Qke9+dyLaHTAnu4DkytbJzglv vd6FvjKypEyF6kG8gcrNyOGnR/+G0Y44qWL9ulTpODk859mTopNK4xJB X-Gm-Gg: Acq92OEorvGQAM6Kh5rrsBWOfuARkO4o0Xm088T23VnVUwFaeiBYBIGAE3n8C1wkkB4 th5CfpcHFTN1IPN2mzUQOB7FhDTSZ485dlDa2f/C3VPTUelTlujN8OD1znonxnmALcOw5o23lMF wPJp/FWXCF7lh7bHDb+o7e7s9addWoT2zwI2kLGM7V33PZPlzAJ72+Migx4O+ud4aRTGWjkGQ+8 HJa5plKkw9kZE1UkGvN7LMajSB3+FdkOvGlK/eC0nM/0CvB+MCbuS5VnX7TobP95x2vAWxAEXrY enCKq7HKl3pG00n5VUrriQlpae8Qfkz28+Nzr6ZkhyTzqpIp6SA3zebd2KdSFlKty90KYaFbw76 ohvC+hWUfrLHPS4Z8k9QSofuzxLvo5QNpqAQN2ZQZ5T92s3Xb0yDjMpbu02LPp5j/nTEZ4szeae tp96TlApVPbBldo/nYeMaPajpy+T/0siVq/DkBddiT5Q== X-Received: by 2002:a05:6a00:408f:b0:837:e9cc:d465 with SMTP id d2e1a72fcca58-842253a671fmr5468493b3a.20.1780213030642; Sun, 31 May 2026 00:37:10 -0700 (PDT) Received: from Naman.Naman ([2401:4900:1f39:4c4a:1e56:d301:ce43:ac25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8422e712309sm3760709b3a.59.2026.05.31.00.37.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 31 May 2026 00:37:10 -0700 (PDT) From: Naman Arora To: dri-devel@lists.freedesktop.org Cc: tzimmermann@suse.de, maarten.lankhorst@linux.intel.com, mripard@kernel.org, airlied@gmail.com, simona@ffwll.ch, stefan@agner.ch, alison.wang@nxp.com, jyri.sarha@iki.fi, tomi.valkeinen@ideasonboard.com, kraxel@redhat.com, dmitry.osipenko@collabora.com, neil.armstrong@linaro.org, khilman@baylibre.com, linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Naman Arora Subject: [PATCH 2/6] drm/tidss: Open-code drm_simple_encoder_init() Date: Sun, 31 May 2026 13:05:28 +0530 Message-Id: <20260531073532.8609-3-namanarora029@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20260531073532.8609-1-namanarora029@gmail.com> References: <20260531073532.8609-1-namanarora029@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The helper drm_simple_encoder_init() is a thin wrapper around drm_encoder_init() with a simple destroy-only encoder funcs struct. Remove the dependency on drm_simple_kms_helper by open-coding the encoder initialization directly in the driver. Signed-off-by: Naman Arora --- drivers/gpu/drm/tidss/tidss_encoder.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/tidss/tidss_encoder.c b/drivers/gpu/drm/tidss/tidss_encoder.c index 81a04f767..4d73a271c 100644 --- a/drivers/gpu/drm/tidss/tidss_encoder.c +++ b/drivers/gpu/drm/tidss/tidss_encoder.c @@ -13,7 +13,6 @@ #include #include #include -#include #include "tidss_crtc.h" #include "tidss_drv.h" @@ -81,6 +80,10 @@ static const struct drm_bridge_funcs tidss_bridge_funcs = { .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state, }; +static const struct drm_encoder_funcs tidss_drm_encoder_funcs = { + .destroy = drm_encoder_cleanup, +}; + int tidss_encoder_create(struct tidss_device *tidss, struct drm_bridge *next_bridge, u32 encoder_type, u32 possible_crtcs) @@ -95,8 +98,9 @@ int tidss_encoder_create(struct tidss_device *tidss, if (IS_ERR(t_enc)) return PTR_ERR(t_enc); - ret = drm_simple_encoder_init(&tidss->ddev, &t_enc->encoder, - encoder_type); + ret = drm_encoder_init(&tidss->ddev, &t_enc->encoder, + &tidss_drm_encoder_funcs, + encoder_type, NULL); if (ret) return ret; -- 2.20.1