mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marco Scardovi <scardracs@disroot.org>
To: Mika Westerberg <westeri@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Linus Walleij <linusw@kernel.org>,
	Bartosz Golaszewski <brgl@kernel.org>
Cc: linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v4 0/4] gpiolib: acpi: Consolidated fixes and bounds checking
Date: Sun, 31 May 2026 14:03:07 +0200	[thread overview]
Message-ID: <20260531120816.17255-1-scardracs@disroot.org> (raw)

Hi all,
while reviewing my patches I ended up noticing these two were concurrent of
the same problem so I ended up merging them and opening a new thread to
avoid any confusion.

lore.kernel.org/linux-gpio/20260518075357.112584-1-mscardovi95@gmail.com/
lore.kernel.org/linux-gpio/20260524162708.62949-1-scardracs@disroot.org/

Please mind to check the 1st one before reviewing it as it contains some
of @Andy's comments on it.

This series consolidates various fixes and bounds-checking improvements
for gpiolib-acpi.

- Patch 1: Adds robust bounds checking for GPIO pin resource arrays.
- Patch 2: Fixes a resource leak and concurrent access race in the
  GPIO OperationRegion address space handler.
- Patch 3: Prevents physical address truncation from 64-bit to 16-bit
  in the OperationRegion handler.
- Patch 4: Prevents out-of-bounds pointer arithmetic in
  acpi_gpio_package_count when counting GPIOs.

Changes in v4:
- Merged the address truncation and package count pointer arithmetic
  bounds-checking fixes into this unified patch series.
- Cleaned up the OperationRegion handler modifications to avoid
  conflicts between the leak fix and truncation check.
- Added code documentation comments explaining locking requirements in
  acpi_gpiochip_find_conn().
- Reworded the commit subject line of Patch 2 to follow standard
  kernel conventions.
- Optimized the concurrent double-request rollback path in Patch 2 to
  free the descriptor outside the mutex (`conn_lock`) to prevent
  potential lockdep issues.
- Refined the `-EBUSY` recovery comment in Patch 2 to accurately
  characterize it as a best-effort recovery path.

Marco Scardovi (2):
  gpiolib: acpi: prevent address truncation in OperationRegion handler
  gpiolib: acpi: fix out-of-bounds pointer arithmetic in
    acpi_gpio_package_count

Marco Scardovi (scardracs) (2):
  gpiolib: acpi: Add robust bounds-checking for GPIO pin resources
  gpiolib: acpi: fix resource leak in OpRegion

 drivers/gpio/gpiolib-acpi-core.c | 186 ++++++++++++++++++++++++-------
 1 file changed, 147 insertions(+), 39 deletions(-)

-- 
2.54.0


             reply	other threads:[~2026-05-31 12:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-31 12:03 Marco Scardovi [this message]
2026-05-31 12:03 ` [PATCH v4 1/4] gpiolib: acpi: Add robust bounds-checking for GPIO pin resources Marco Scardovi
2026-05-31 12:03 ` [PATCH v4 2/4] gpiolib: acpi: fix resource leak in OpRegion Marco Scardovi
2026-06-01 12:18   ` Mika Westerberg
2026-06-01 13:03     ` Marco Scardovi
2026-06-02  7:57     ` Andy Shevchenko
2026-06-02  9:53       ` Mika Westerberg
2026-06-02 10:04         ` Andy Shevchenko
2026-05-31 12:03 ` [PATCH v4 3/4] gpiolib: acpi: prevent address truncation in OperationRegion handler Marco Scardovi
2026-05-31 12:03 ` [PATCH v4 4/4] gpiolib: acpi: fix out-of-bounds pointer arithmetic in acpi_gpio_package_count Marco Scardovi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260531120816.17255-1-scardracs@disroot.org \
    --to=scardracs@disroot.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=brgl@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=westeri@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®