From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C915E3A3E76 for ; Mon, 1 Jun 2026 12:05:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780315541; cv=none; b=B3OzwATtJsJVUnVS/LPA0a/8WfotwjR75QEKRc0TEOQp9j5WbiV+U0x3B1MTv1/LBWwEXL1otMhJypfk9AiJrhQrhzyA3VED7n6RM9QdRiZcryhpa7q8cT7OUAYiZ4lc1P1Bhvj6R+/u8cb2Ygh87x9qRUurcuJtPSlmjPcHccs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780315541; c=relaxed/simple; bh=qrUOU8qnHGg0JvQozawLRdf39GqEwr6BMsdBUWY+zJs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RFB73MN1dbYKoLi2396cSA2q9iRK5iRKABzYVNrVkHrzM6S5GUjftYeQOciaujWkWWcimqCn38vLAJU/hv4h2ETWdS3uN1mz79q/f2MS4XHNwFzJws4xpQ7WnGeKojvyN02l1mXu4qlX09G9sBYfzBzCtD2eoaMT1QaIULUzycw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nykfcaGD; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nykfcaGD" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-49041e84237so82060305e9.1 for ; Mon, 01 Jun 2026 05:05:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780315537; x=1780920337; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=LWYGhk2F/MyqS6FkLrsC1PXV1OSFLSJSVfJ4W+L2Bjw=; b=nykfcaGDKWiy6jwWwsuE+Z/ATaiThMTLv/3kiA2Eychw6D/wheSUN+crOSqf/sqb8A S8rxwOSqL/K2wvAxTXKV9nz/otQ40BA1roGeC/10oDEliigpZKZROPsXEcJdk3orUvGi 32it+Pq1rDzMF5M5xuXuHcZF5lzOm9F44mznsI2K4tN1KePoI43fqWFcuzn5WIUyLmXk M5XvfU1/dkawxz0Wa/+8xsjV3/9mETt9BN3huUmlk7Js3SSoAm7Mmh8rJsdoDk+1hKTW 9lcbpOcKJn0h07E2vlRsfTKPohg+G+vufEjjkLsI5aERbic1+CWgeUqIlPfNOinHs2iM sdxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780315537; x=1780920337; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=LWYGhk2F/MyqS6FkLrsC1PXV1OSFLSJSVfJ4W+L2Bjw=; b=Xl8OJZCqbGl2vsWBwcNY0B+zpx19jbFtF5YB1+ryjsTsZsC3vJH9H8WfDm2XTpPGUG mxjgqRs0iV31EKIDX4eM2xfM2b9IeJlJ/3n39JK+h2St0630BIy0xk0tBJbtRMBzCt0j xa+v9agJlvoFktR1L95ItAPTbRC34eo2jILWlhIYZ3kNu1QeZRe+/578hqe5Pr1aw+Z8 uRnh3GdxQCV4nFEO3ztx/M4mn/2EJS6Ilor5RdzVotedotm1ZG+yAPGXcoH4i33hq6JG EqMAtuqdIqkCSp2ceRdBvFxrkMmqzwfH1pBKRBM0+Fa7HHTpw0I4M1P0lAMyBiU+pBrf vmWg== X-Forwarded-Encrypted: i=1; AFNElJ9zIyqJS0fPLf0yiDLs9ChBNQ4OMzqCxcolapqxpxyyk8b6NCvmpk24Fqe6qtXMqN8ne7ZA/OFozbqAvTg=@vger.kernel.org X-Gm-Message-State: AOJu0YxEpAgsY7JBTVkNR07hdokXjUEbD8PtDN6po4YDZSoQg69Cc1Rj PdLX3MmYO870hxcVcwxzSdXaIjnwG2XKoJ+zH6Jya2QFF2lHij7ZZAmM X-Gm-Gg: Acq92OH58BwG2BGKpkeRkOCbgl8XCmUDfqCC6FCDEApLq/1oce3j5Lkc8CD+K+MrVnb GJRReCBEeV90+NpN2WhVDO/P+AvhX9YuCz80mZSAL86sFPw8q9eNX2bZVDGquEZvO97i4RCafl6 ghR9qeeO9b5XKaFwuB4khQYUxfnUBcY+5Z+5tJcdS19GBtq7xQ1kuEaBRUiwdqP1TgR97n/cLXV 7SNhaesd9ChpA70Vq5RQ2kAGMGoGGiy+rW9a2SGeRgJIyLoRPLwUz5qlEYYieAdOF5aZgcRI06N 1FKz5iF27isO/KPQnkLO25UhcrPPgPz0RpOKsyWzJWKijThu+GqJ97VHNlUmKrh+KXjGZiHSTGL 8NwSuTltPYAaJVJ74BaI3taVwcPZzZozvq28m74lz+KDFAIgqe24C2rQo22l0JZXVG2bbGXUMp9 YluJ+yMPaM3jXz3nQ+mojhK+90vqRwCO189Wk+eJaOSw== X-Received: by 2002:a05:600c:4047:b0:490:afd9:93e0 with SMTP id 5b1f17b1804b1-490afd99800mr2527795e9.0.1780315537003; Mon, 01 Jun 2026 05:05:37 -0700 (PDT) Received: from [172.16.188.153] ([213.181.114.83]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4909c152570sm103972805e9.9.2026.06.01.05.05.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 05:05:36 -0700 (PDT) From: Jim Cromie Date: Mon, 01 Jun 2026 12:05:01 +0000 Subject: [PATCH v3 15/24] dyndbg: tighten fn-sig of ddebug_apply_class_bitmap Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260601-dd-maint-2-v3-15-4a15b241bd3c@gmail.com> References: <20260601-dd-maint-2-v3-0-4a15b241bd3c@gmail.com> In-Reply-To: <20260601-dd-maint-2-v3-0-4a15b241bd3c@gmail.com> To: Jonathan Corbet , Shuah Khan , Arnd Bergmann , Jason Baron , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Andrew Morton , Shuah Khan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-modules@vger.kernel.org, linux-kselftest@vger.kernel.org, dri-devel@lists.freedesktop.org, Jim Cromie , Louis Chauvet X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780315495; l=2913; i=jim.cromie@gmail.com; s=20260203; h=from:subject:message-id; bh=qrUOU8qnHGg0JvQozawLRdf39GqEwr6BMsdBUWY+zJs=; b=XmNB1fBFswv081gt/z1FJsg1wqGy9IGRATjjRtwSJGRi+5lebAnhlFPLse3F6qDEwV+zvZ0GH iOECBesKIdkB+6EBhmJin69PnZREkOeg/nCqW3L12Y0nksUfKl9Fqce X-Developer-Key: i=jim.cromie@gmail.com; a=ed25519; pk=C6E5ODlPQo7ZBynATXH9wg7K6HxP0pIXyf4s38Qw0XE= old_bits arg is currently a pointer to the input bits, but this could allow inadvertent changes to the input by the fn. Disallow this. And constify new_bits while here. Signed-off-by: Jim Cromie Reviewed-by: Louis Chauvet --- v2: move RvB after SoB --- lib/dynamic_debug.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 182b84b6f6c5..bb7e16d38f19 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -610,7 +610,8 @@ static int ddebug_exec_queries(char *query, const char *modname) /* apply a new class-param setting */ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp, - unsigned long *new_bits, unsigned long *old_bits, + const unsigned long *new_bits, + const unsigned long old_bits, const char *query_modname) { #define QUERY_SIZE 128 @@ -619,12 +620,12 @@ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp, int matches = 0; int bi, ct; - if (*new_bits != *old_bits) + if (*new_bits != old_bits) v2pr_info("apply bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, - *old_bits, query_modname ?: "'*'"); + old_bits, query_modname ?: "'*'"); for (bi = 0; bi < map->length; bi++) { - if (test_bit(bi, new_bits) == test_bit(bi, old_bits)) + if (test_bit(bi, new_bits) == test_bit(bi, &old_bits)) continue; snprintf(query, QUERY_SIZE, "class %s %c%s", map->class_names[bi], @@ -636,9 +637,9 @@ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp, v2pr_info("bit_%d: %d matches on class: %s -> 0x%lx\n", bi, ct, map->class_names[bi], *new_bits); } - if (*new_bits != *old_bits) + if (*new_bits != old_bits) v2pr_info("applied bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, - *old_bits, query_modname ?: "'*'"); + old_bits, query_modname ?: "'*'"); return matches; } @@ -686,7 +687,7 @@ static int param_set_dyndbg_module_classes(const char *instr, inrep &= CLASSMAP_BITMASK(map->length); } v2pr_info("bits:0x%lx > %s.%s\n", inrep, mod_name ?: "*", KP_NAME(kp)); - totct += ddebug_apply_class_bitmap(dcp, &inrep, dcp->bits, mod_name); + totct += ddebug_apply_class_bitmap(dcp, &inrep, *dcp->bits, mod_name); *dcp->bits = inrep; break; case DD_CLASS_TYPE_LEVEL_NUM: @@ -699,7 +700,7 @@ static int param_set_dyndbg_module_classes(const char *instr, old_bits = CLASSMAP_BITMASK(*dcp->lvl); new_bits = CLASSMAP_BITMASK(inrep); v2pr_info("lvl:%ld bits:0x%lx > %s\n", inrep, new_bits, KP_NAME(kp)); - totct += ddebug_apply_class_bitmap(dcp, &new_bits, &old_bits, mod_name); + totct += ddebug_apply_class_bitmap(dcp, &new_bits, old_bits, mod_name); *dcp->lvl = inrep; break; default: -- 2.54.0