From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3542E376A19 for ; Mon, 1 Jun 2026 12:05:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780315506; cv=none; b=OTeYxJ98pDwdSywxMILi21/0mOFZkl8rr800aNzSc3OX1qPqJC87NDahSpXk9huDExNOItBxFm84wmWgnO+SuyXv8ie3Cxj8HEbkMFwHtW/UMb0+55AqjdG5BD/lQ7HcRqyeOKGimNhBXhTkycQJHLt7iSBo25NCGh5ZGeXQ3YI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780315506; c=relaxed/simple; bh=Ybb0kJKNd2BJDDcZYbhZbCACFsLVAC7m/M+jXCdbe+s=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uKmyK26jXVmtcNBDoptqCb44zqKXUs2I2XgCtSmBULz0bfsqA+5B4kMjq88gR0kpQpUISqfRd/o8nWuyEGt/FnKeGdCACD5uws5TiwYjCxoK+2IMI9mK+WzFChSUzoidz9ivtHewIymQdK6QgNMK/RBjPj4EYfns9f+23RtpwhU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ug+D/UHg; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ug+D/UHg" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-49050bfe053so68927235e9.3 for ; Mon, 01 Jun 2026 05:05:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780315504; x=1780920304; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=T5zD1QygmB8fWogN5M5u4F28IFz6bLgLGYRTXYqao/U=; b=Ug+D/UHgDkpae6UeG1SlmhwEpptQyKc7cGeIbceB0m0EM20CEYKERTMtsSMTn6gbSK RaLM4pUqtgz+45b5FVndHeinOjGur13/IwJGzak8WCKzpTM8a+uoTUPUXp8FHjT4ceho 87k2d+BgD2AaniUye1LTsdwCFjTwHkg1uJ1Y5RbP/tZoSqsT5VAzmrvH0XMuAm6hAoXO tYboE7CnCp+379XMUSg1+7sQewsHRaMNgsbS5xCuK1LQ6uBd2fEmhm3wJPgD05hZmRI/ DaquwYy0MbVz9Kkvh+L9pueOXvVVQ2QDYP3bccsMyrLMenCy967HxbUn3JPH5Et9rgYv OpEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780315504; x=1780920304; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=T5zD1QygmB8fWogN5M5u4F28IFz6bLgLGYRTXYqao/U=; b=L7Btj46rGosD+FgczWLvoFLZsFTDGBnrgLk7/P1QtuHelkzEz+NiQfHMFw723j7ydq VLtz8/dAlbbCx7vq7wNF8d8Phbo1Z8Ses3ksypthu1iCbmi75NzCOgRAihsoSWeyyd1O yFaK/sVVQtr0La4i5+quVHkV/D53m0KWVNf05Xw4ZTkkEwqTLCcoKl4b6/eoQ+3C96wX mtIP5K2+HPP9uw+81esfvpsn/MGrkvuaAW4kHCHc/agft++l34DULAu8r2tq1CpZlRG7 cybDsXFMzS/pFfG5vaujukd1mlxXhbPdfP5zjbKdEFbgK64iFK9IC5hc66M1om5V9tnu Ppsw== X-Forwarded-Encrypted: i=1; AFNElJ+QJA+Wz7VUbssfKMJPeZetGn5c9lxfLRtkEjaMmz6iauR+MMgX3k3QDoNt9p+wEsg+7cT0+zlz4epw2hE=@vger.kernel.org X-Gm-Message-State: AOJu0YyXhuV8btwHk2HTUXi1DvDSptZnOwLK9oAj5afBrKk66TCB5n0/ WvlSrs2iLexGuJjwHUSgf6MKtEI/7mP1Zt22iMszpSY+4fUV5GNVtvZs X-Gm-Gg: Acq92OHAUc1bLgW6IVdNtm5PJhpcDjXJekInV/6NumQGq+3n6Pncv0rHAoT1dtwNtOP 1VhfJ0bOXjmvzu5+RWIxZ9R5XyMK5zjMTLtNIn5QUroMGHSaIblXtFHmZHEwvlpE2sHJAsvEiNi 4JeCG0G394ay45njOSrjDeh5CdhP9LBPrI3/Oce17AQ+LbR3WY1H31+J/g0xkcYTOr0pDZIQ/24 msjRRmUvjlI8W2IjbQHM7ApRR4djNQ/ZK426YrnS4sXm4eMhH+4kfF/T4mR+H0cYYtHBdyJPoLW c6oenhpcIfvHIOD7oAQGkv1pcurhmqI9y/z51ZEYhthOVe/6KGyylYBsfrQiFRwkUfAnDTpAV54 m+BjMphXn8ZYCHFsnDU/3fD4/7ph3BAtMxxD4D0kDXX35Wt8nH8EQI2qiDhDiVMZm4wFNfuJVrw 8crn1n85tVd1ixVOFP3gO4lHwzB+4jqKOt3pxirUFcPQ== X-Received: by 2002:a05:600c:1546:b0:490:50e4:7224 with SMTP id 5b1f17b1804b1-490a290bdf1mr200424025e9.3.1780315503641; Mon, 01 Jun 2026 05:05:03 -0700 (PDT) Received: from [172.16.188.153] ([213.181.114.83]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4909c152570sm103972805e9.9.2026.06.01.05.05.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 05:05:03 -0700 (PDT) From: Jim Cromie Date: Mon, 01 Jun 2026 12:04:48 +0000 Subject: [PATCH v3 02/24] docs/dyndbg: explain flags parse 1st Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260601-dd-maint-2-v3-2-4a15b241bd3c@gmail.com> References: <20260601-dd-maint-2-v3-0-4a15b241bd3c@gmail.com> In-Reply-To: <20260601-dd-maint-2-v3-0-4a15b241bd3c@gmail.com> To: Jonathan Corbet , Shuah Khan , Arnd Bergmann , Jason Baron , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Andrew Morton , Shuah Khan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-modules@vger.kernel.org, linux-kselftest@vger.kernel.org, dri-devel@lists.freedesktop.org, Jim Cromie , Louis Chauvet X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780315495; l=1814; i=jim.cromie@gmail.com; s=20260203; h=from:subject:message-id; bh=Ybb0kJKNd2BJDDcZYbhZbCACFsLVAC7m/M+jXCdbe+s=; b=77QENcw7TwO5sbOCSCb3za5Eh6W1VtMb7ffsLgiJ6qjsY20R6qLFWJ9u0VHPdNWz7TZVh1MSu fXZPCPflAUnCuxlFjQ2BltAWo25IThXGyLGV8vp/+SKUfZSM2Av2QvG X-Developer-Key: i=jim.cromie@gmail.com; a=ed25519; pk=C6E5ODlPQo7ZBynATXH9wg7K6HxP0pIXyf4s38Qw0XE= When writing queries to >control, flags are parsed 1st, since they are the only required field, and they require specific compositions. So if the flags draw an error (on those specifics), then keyword errors aren't reported. This can be mildly confusing/annoying, so explain it instead. cc: linux-doc@vger.kernel.org Reviewed-by: Louis Chauvet Signed-off-by: Jim Cromie --- Documentation/admin-guide/dynamic-debug-howto.rst | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/Documentation/admin-guide/dynamic-debug-howto.rst b/Documentation/admin-guide/dynamic-debug-howto.rst index 4b14d9fd0300..9c2f096ed1d8 100644 --- a/Documentation/admin-guide/dynamic-debug-howto.rst +++ b/Documentation/admin-guide/dynamic-debug-howto.rst @@ -109,10 +109,19 @@ The match-spec's select *prdbgs* from the catalog, upon which to apply the flags-spec, all constraints are ANDed together. An absent keyword is the same as keyword "*". - -A match specification is a keyword, which selects the attribute of -the callsite to be compared, and a value to compare against. Possible -keywords are::: +Note that since the match-spec can be empty, the flags are checked 1st, +then the pairs of keyword and value. Flag errs will hide keyword errs:: + + bash-5.2# ddcmd mod bar +foo + dyndbg: read 13 bytes from userspace + dyndbg: query 0: "mod bar +foo" mod:* + dyndbg: unknown flag 'o' + dyndbg: flags parse failed + dyndbg: processed 1 queries, with 0 matches, 1 errs + +So a match-spec is a keyword, which selects the attribute of the +callsite to be compared, and a value to compare against. Possible +keywords are:: match-spec ::= 'func' string | 'file' string | -- 2.54.0