From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66C0C2C0294 for ; Mon, 1 Jun 2026 16:14:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780330446; cv=none; b=tzp6kICZEFhJ8MwZ4G7Cj8579f+tpnL4E/0lBmnn/njsrehc6wS3YyKZXUxlP4Srtzvlf4njgYBsIxXLBQpUc8eBsVkT56kJ8Vwnk20VbR+c+gyhXs1nnJ0F6YTkeq+g7HPyY0EGkARDDpBJ7xD7hb+dsGFU0o9It+UhDkteSKM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780330446; c=relaxed/simple; bh=sokoSsyWgTcHZSa0ZifzWSPZUKXC898Oh68D+flm33o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rWs960S2goNXZn56yjuv/9f5UE9jFDbmOMEkh6Fg1/5GpGptZxBz5kflnH0P9fHNKbqr1D2RtWGnI0EfFtX2H1msjrTP6KDo0V3s+oB4keLKrARhyNfef8UlwwZ59Iq8OHdI22K2qjU6sBDhWQB2MJcEtbwzo2aGAS1qNOFDvuQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=MNnmM6iM; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="MNnmM6iM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1780330443; bh=sokoSsyWgTcHZSa0ZifzWSPZUKXC898Oh68D+flm33o=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=MNnmM6iM84BXz/e4nyF14i+tXwAgEt2hMDyAlks6zFbKuGBM3Amvn+oKFW3+b1ueB qnh3duYa8i+7iRSP5ijgSJBo00qSMYf18G4oXZEMRNFc3hsPqrOyxfhw1lc9wKoeg8 qljgV9aNXGiMmMoiaB0co7fWG7SntMNPN0VJNGBirH4rCTR//aTqAamGAkrjh3vLOg ltS3WscDp4h+m/j/sld6SKJYuOb75adbgdq6jXKLH5u59Pjvfz7H4ytnuHDJzPzim8 9WL6w5uzLs3+xPYfTRUJ6lUoQ6QxVGcJwBDsr81HWniyC+VapUQHPFaRvcWz9PcUSy FROAbHDIW+Fog== Received: from localhost (unknown [100.64.0.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id AE09E17E05DE; Mon, 1 Jun 2026 18:14:03 +0200 (CEST) From: Cristian Ciocaltea Date: Mon, 01 Jun 2026 19:13:44 +0300 Subject: [PATCH v4 1/3] drm/bridge: synopsys: dw-dp: Support unregistering the AUX channel Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260601-drm-rk-fixes-v4-1-c3f3f123e1da@collabora.com> References: <20260601-drm-rk-fixes-v4-0-c3f3f123e1da@collabora.com> In-Reply-To: <20260601-drm-rk-fixes-v4-0-c3f3f123e1da@collabora.com> To: Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dmitry Baryshkov , Dmitry Baryshkov , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.15.2 The DisplayPort AUX channel gets initialized and registered during dw_dp_bind(), but it is never unregistered, which may lead to resource leaks and/or use-after-free. Add the missing dw_dp_unbind() function to allow the users of the library to handle the required cleanup, i.e. unregister the AUX adapter. Fixes: 86eecc3a9c2e ("drm/bridge: synopsys: Add DW DPTX Controller support library") Reviewed-by: Andy Yan Signed-off-by: Cristian Ciocaltea --- drivers/gpu/drm/bridge/synopsys/dw-dp.c | 6 ++++++ include/drm/bridge/dw_dp.h | 1 + 2 files changed, 7 insertions(+) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/bridge/synopsys/dw-dp.c index 21541be094c4..36ee6e027af5 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c @@ -2093,6 +2093,12 @@ struct dw_dp *dw_dp_bind(struct device *dev, struct drm_encoder *encoder, } EXPORT_SYMBOL_GPL(dw_dp_bind); +void dw_dp_unbind(struct dw_dp *dp) +{ + drm_dp_aux_unregister(&dp->aux); +} +EXPORT_SYMBOL_GPL(dw_dp_unbind); + MODULE_AUTHOR("Andy Yan "); MODULE_DESCRIPTION("DW DP Core Library"); MODULE_LICENSE("GPL"); diff --git a/include/drm/bridge/dw_dp.h b/include/drm/bridge/dw_dp.h index 25363541e69d..22105c3e8e4d 100644 --- a/include/drm/bridge/dw_dp.h +++ b/include/drm/bridge/dw_dp.h @@ -24,4 +24,5 @@ struct dw_dp_plat_data { struct dw_dp *dw_dp_bind(struct device *dev, struct drm_encoder *encoder, const struct dw_dp_plat_data *plat_data); +void dw_dp_unbind(struct dw_dp *dp); #endif /* __DW_DP__ */ -- 2.54.0