From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f202.google.com (mail-dy1-f202.google.com [74.125.82.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B81A363CB for ; Mon, 1 Jun 2026 00:05:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780272358; cv=none; b=dSa9QKXOX1FgV/4sKVPrZhJf0fjahyEr0h+1sg9e8Gnf0c8NvlO0rVHtXbELCkZdGWEG/kFeXpFsTyz9VStLiiKcie9ZwS0u8TFAidGVg9iUQ7bryoQeEjTx4zoL45fM1bBEkArusJmtXBEL3SYcZ4lL1eVcXdTdKXPRUwDJi0I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780272358; c=relaxed/simple; bh=ngJ/Mj8Bcywxu572XnE53uO9hdP/FNucStr177ix1No=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=ThgAUDnlQ081zPTtRg0JJAvab7o8LDX/njVuHwcW0NYhSL1tBO3uC+OIdTwUaqhZSZD+4EDzadT0gN0FNMqz4LBikSPu8pTFjouq6ZHX6WCIf/jw+rqUhwFaKVNXgrmhtwvYsJ7LAkd4HNg5gM7wiRLMdSzu4ftH79l13WSsTaA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=u86RToKg; arc=none smtp.client-ip=74.125.82.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="u86RToKg" Received: by mail-dy1-f202.google.com with SMTP id 5a478bee46e88-304efad654dso618443eec.1 for ; Sun, 31 May 2026 17:05:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1780272356; x=1780877156; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=2jWw8vXsDRW3SEZeKoJSMalSZ2Ddsgdbn7LnqKkFxZ0=; b=u86RToKgDUdsUP/9dwUuSRf5RmYsmCO0luaoIrvSwzVvJdJbaYDVa4jp07wfZT1aeP I4B1L2lFveeMsNL2G00Cmrk3uckRk1tvUAgVHNrNGQOd6QUpBxu+/ecHT0MI7xl9Pw6W FTIxfWJu3m//CoOyvir43wALShfKhHXpccNwSoW8IHggUF84yx+wqUrVjyYh9IgkWXjD ZE+RFpQwSIMO/Uf0Btin4DrJwQH7ROg65M1Joav1Bx9ezCm4/lQqzPiuk33SvlRcZsxX slJipoCkD9r6lFnsLGe1qLSBSQ7vjE73LSvXqdlHnt2ZQdblalWw4MxsGYxGe035E2Gh f1Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780272356; x=1780877156; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2jWw8vXsDRW3SEZeKoJSMalSZ2Ddsgdbn7LnqKkFxZ0=; b=E7125avrMogBsmz4oQo/OHR3R9YeZLAbA3/96rBXHFdcD+6dG7ARXH4KJLe9mBqqKK VXrJNkYIZj4zWq99U7LCUqmXy1ljfXXVOpyRewyApah5QK7OUQ/CMin0SfZRRZaLf4NV Bo2s3X4JT4RNQXeV6F+cUVAH6FwA1Cs4aZCJwGEmSzaBTH9ZLx78UMMHwp0OXEJ0Lcy+ +jTq2mzKXxnPS4+xbgIu2rrsMiC2+JEdsoiOxwP/mfXEdV0GEbsF+WJEoY/ALMuQXmVj tab+lbJq7X/htI/idKdIyrrsUd1422sp/wgzSOVZeFT+Kb9YYJ1Wvr4nLJhQXIu9WE5u xo9A== X-Forwarded-Encrypted: i=1; AFNElJ+ULFgeR1aXxoT9OKOuaxa15xkceCC378MjMSQzlVpL1kYWLn2MCjCMzwOM9zwaIj5L/L34yIBvfR+WxGY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/a+0xF38o6dvem7zrOP52ytbH5mKQnx7HthCjhGjQpguxikLJ 5q3mj+ThIaWk8LyNECB6c9gOnzziF9uTY78zeq6H566Iy1UlibYHvZYxzc8GNOVgNdN4mdwQcY/ o+xyrtZkMzg== X-Received: from dyek28.prod.google.com ([2002:a05:7300:641c:b0:2e6:52c7:6f4f]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7300:e58b:b0:2d9:6373:ad10 with SMTP id 5a478bee46e88-304fa522c2dmr4307064eec.7.1780272355560; Sun, 31 May 2026 17:05:55 -0700 (PDT) Date: Sun, 31 May 2026 17:05:33 -0700 In-Reply-To: <20260531082235.940833-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260531082235.940833-1-irogers@google.com> X-Mailer: git-send-email 2.54.0.823.g6e5bcc1fc9-goog Message-ID: <20260601000548.1195604-1-irogers@google.com> Subject: [PATCH v5 00/15] perf test: Accelerate parallel test harness and add JUnit XML reporting From: Ian Rogers To: irogers@google.com, acme@kernel.org, adrian.hunter@intel.com, namhyung@kernel.org Cc: alexander.shishkin@linux.intel.com, james.clark@linaro.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, mingo@redhat.com, peterz@infradead.org Content-Type: text/plain; charset="UTF-8" Motivation & Key Enhancements 1. **Test Harness Acceleration & Parallel Polling** Previously, when running tests in parallel mode (`perf test -v`), child processes writing massive amounts of logging output to pipes (such as Granite Rapids PMU metric parsing) would saturate the 64KB pipe buffer and block indefinitely. The parent harness only polled the pipe of the "current" sequential test waiting to be printed, causing severe execution bottlenecks. - Refactored the parallel poll loop to drain output pipes from all active children simultaneously into dynamic per-child buffers (`struct strbuf`). Reaping occurs asynchronously out of order, while final console printing remains strictly sequential. - Added explicit pipe draining after child process termination to prevent losing trailing log data. - **Benchmark**: This drops parallel verbose execution time for the PMU events suite from ~35 seconds down to ~5.9 seconds (an ~83% reduction in latency). 2. **Dynamic Test Suites & Granular PMU Subtests** Monolithic test cases (like "Parsing of PMU event table metrics") previously evaluated hundreds of tables in a single sequential run, making failures difficult to isolate. - Added `setup` callbacks and private data pointers (`void *priv`) to `struct test_suite` and `struct test_case`, enabling dynamic runtime testcase generation. - Split the PMU events metric parsing test into individual subtests (one pair of real/fake PMU tests per metric table), allowing them to execute concurrently and report granular results. 3. **Advanced Triaging & Automated Summary Reporting** Triaging failures in highly verbose automated runs previously required scrolling through thousands of lines of console output. - Introduced a smart, configurable failure snippet processor (`--failure-snippet-lines`) that dynamically extracts root-cause context lines matching failure keywords (`error`, `fail`, `segv`, `abort`) while preserving outline markers. - Implemented an automated global execution summary printed at the absolute tail of the test run, presenting clear pass/skip/fail totals alongside an explicit list of failed test cases for effortless cross-referencing. - Fixed subtest status column alignment (`: Ok`) for multi-digit test indexes. - Updated shell script SPDX header parsing to prevent license strings from being incorrectly extracted as test descriptions. 4. **JUnit XML Reporting & CI Integration** Added a `-j`/`--junit` command-line option to generate standard JUnit XML test reports (`test.xml`). - Captures individual test suite and subtest execution latency alongside XML-escaped failure logs and skip reasons. - Guarantees absolute timing precision and immunity to wall-clock jumps by measuring durations using `clock_gettime(CLOCK_MONOTONIC)` and harvesting `end_time` exactly when child processes exit to insulate latencies from out-of-order sequential UI printing delays. - Added a standalone shell test script to validate generated JUnit XML syntax using Python's `ElementTree` parser. 5. **Elimination of External C Compiler Dependencies** The Intel PT shell test (`test_intel_pt.sh`) previously compiled external C workloads at runtime using `/usr/bin/cc`, which frequently breaks in hermetic or minimal CI environments. - Created a built-in self-modifying JIT workload (`perf test -w jitdump`) and switched the script to use built-in workloads. - To guarantee robust multi-architecture compatibility without external C compiler dependencies, the JIT workload immediate instruction arrays dynamically encode `CHK_BYTE` into opcodes across x86, ARM32, ARM64, RISC-V, PowerPC, MIPS, LoongArch, and s390x, with clean `#else` fallbacks for unsupported architectures. Changes from v4 to v5: - Incorporated LKML maintainer feedback for robust process checks, signal safety, leaks, and mixed declarations: - Added ISO C90 platform guards and robust waitpid fallbacks for `/proc//status` queries during active process checks. - Switched parallel poll pipe draining and error strbuf merging to rely on robust memory releases and `strbuf_addstr`. - Corrected multi-digit test status output index padding arithmetic. - Updated JUnit XML summary conditionals to precisely catch execution result failures. - Eliminated ISO mixed declaration warnings in `builtin-test.c` to fully comply with `-Wdeclaration-after-statement`. Ian Rogers (15): perf jevents.py: Make generated C code more kernel style perf pmu-events: Add API to get metric table name and iterate tables perf test: Drain pipe after child finishes to avoid losing output perf test: Support dynamic test suites with setup callback and private data perf test pmu-events: A sub-test per metric table tools subcmd: Robust fallback and existence checks for process reaping perf test: Refactor parallel poll loop to drain all pipes simultaneously perf test: Show snippet failure output for verbose=1 perf test: Add summary reporting perf test: Fix subtest status alignment for multi-digit indexes perf test: Skip shebang and SPDX comments in shell test descriptions perf test: Split monolithic 'util' test suite into sub-tests perf test: Add -j/--junit option for JUnit XML test reports perf test: Add shell test to validate JUnit XML reporting output perf test: Remove /usr/bin/cc dependency from Intel PT shell test tools/lib/subcmd/run-command.c | 51 +- tools/perf/pmu-events/empty-pmu-events.c | 8823 +++++++++++------ tools/perf/pmu-events/jevents.py | 849 +- tools/perf/pmu-events/pmu-events.h | 4 + tools/perf/tests/builtin-test.c | 649 +- tools/perf/tests/pmu-events.c | 156 +- tools/perf/tests/shell/test_intel_pt.sh | 169 +- .../tests/shell/test_test_junit_output.sh | 63 + tools/perf/tests/tests-scripts.c | 81 +- tools/perf/tests/tests.h | 3 + tools/perf/tests/util.c | 20 +- tools/perf/tests/workloads/Build | 1 + tools/perf/tests/workloads/jitdump.c | 188 + tools/perf/util/jitdump.h | 3 +- 14 files changed, 7353 insertions(+), 3707 deletions(-) create mode 100755 tools/perf/tests/shell/test_test_junit_output.sh create mode 100644 tools/perf/tests/workloads/jitdump.c -- 2.54.0.823.g6e5bcc1fc9-goog