From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f74.google.com (mail-dl1-f74.google.com [74.125.82.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87FBD41C6A for ; Mon, 1 Jun 2026 00:06:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780272389; cv=none; b=pm41BcVqELOQ0L2kKkKc48h17VJm3xPYboMUKIICCppA2/kWUfYldIXorG6tbL27ooihxJ4cQEtjBBx4sgiBgaIrE0f55w279J6ocJpMXnJWLTqam+0TAn5oVcFHoj9bOhbw1WTjZyCY1cWaMrVaGdgtXQQI85TAmz7HGu8B3Rg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780272389; c=relaxed/simple; bh=v+uQb482xCIMi9HmoWUGu58IjoDszSuB2IlHYCHiaSE=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=SvEBq4mY6zDhIo/0mv7VXSNsm6fJybtxsSVSkGWZf3Fe0psZh+KxDuSlGamgSvfxuRMlnvWBLfUu6ZX1qd/hkmEt7CgMaTRdfuLrF0ZLOnaJydpcTEshavL1L8ce2V0veNZn+bOshAR4h6lshlfwjCoLdbjOJrWLhDzu4M/phjk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ZIYdgjpl; arc=none smtp.client-ip=74.125.82.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ZIYdgjpl" Received: by mail-dl1-f74.google.com with SMTP id a92af1059eb24-137dd516985so1284388c88.1 for ; Sun, 31 May 2026 17:06:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1780272377; x=1780877177; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=6oWF0bxxyu3W0maVW6LzGoakYua7rlvwmHaeizM/uC8=; b=ZIYdgjplBhXy/lL7fP4LuV78HDU1GUGEGQpiOHwTrPbgs22UFnWyL1ii9X0GAwkeyN G1UpeQMJoLVaisOxmIh+CyLi9XpnYuv/UtmoqSSbnlA1JOTZXswWXYqeSCmgkD9Tm6gp G0mIHd78VbEjgAaopNYpuFYMUQKw4nM2wrjVA6Oa1Jxad21kDWQGNdyhVH0JiV+LjFf1 zvjdqUQ1BcygWdozVp1KQu+RL6FRjG9HggmSA0eMLz8Gpn98M8aujLqIqvM9/JHOru/7 QfAIrjSKnhautdi2d7AHl7WuD1agKNeNdjej6x80WuWJGK3BF93FyYzVgLsAed52Uelq yE9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780272377; x=1780877177; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6oWF0bxxyu3W0maVW6LzGoakYua7rlvwmHaeizM/uC8=; b=FmgeP1QUsTsbC391ec9CYZLPiQkJCBPe5fTVHXfRSy4EGf2kdCS44UoKYwFqaiBzkJ 7l4n12AT+Lzy8fOr9bihuWl59jj7d0lb3uQ12cP7NimicXT3SErUyRs3nL6wvmlxC/x5 l7c9Wb5t5iMaegmXdGaWeddac3qcgZFFEMBKwx7DNcNqxcfLa4UPyKINhElgPFuJyuuM jCnUt7o1wPofZ4YFQxZIBB2GObg1xl7sSRclpKbm+epKgwv9TA4GikuHRo2kVAgfA046 SBmJswRP40VzzrSXJyR+zuNjFUSxmrI5rVeWAC0hU42v1IjJYgFwq4RXwDx2+dkGV0ms Ed7w== X-Forwarded-Encrypted: i=1; AFNElJ+fSkqcUFbt6cw9BiYSDrpcibT6rq+7vven0fThJPf6msg3Pd5Y+CTox204QXmU8Vjaf8UpAEhsdYReaU0=@vger.kernel.org X-Gm-Message-State: AOJu0YxKl29gMiO7+I6AqPDKuTbAPRQ1i8PxlH3coBVTQrJxz7J+OAN3 31thmJl+FrAXscM5vHjM3gyHssHTaPXBz8mLjggv+8T6W/uOw41fJGgeLpAnhTPQzr3BSCsPYB+ KEnMegu+xGw== X-Received: from dlai21.prod.google.com ([2002:a05:701b:2715:b0:135:b432:37dc]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:6ba6:b0:136:6883:c4bc with SMTP id a92af1059eb24-137d3bf701emr3176568c88.9.1780272376558; Sun, 31 May 2026 17:06:16 -0700 (PDT) Date: Sun, 31 May 2026 17:05:43 -0700 In-Reply-To: <20260601000548.1195604-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260531082235.940833-1-irogers@google.com> <20260601000548.1195604-1-irogers@google.com> X-Mailer: git-send-email 2.54.0.823.g6e5bcc1fc9-goog Message-ID: <20260601000548.1195604-11-irogers@google.com> Subject: [PATCH 10/15] perf test: Fix subtest status alignment for multi-digit indexes From: Ian Rogers To: irogers@google.com, acme@kernel.org, adrian.hunter@intel.com, namhyung@kernel.org Cc: alexander.shishkin@linux.intel.com, james.clark@linaro.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, mingo@redhat.com, peterz@infradead.org Content-Type: text/plain; charset="UTF-8" When running perf test, the status column (: Ok) became misaligned when subtest indexes reached 2 or 3 digits (e.g. 9.100 vs 9.9 vs 10.1). This occurred because the subtest description field width (subw) was statically fixed to width - 2, assuming all subtest index prefixes were exactly 7 characters wide. Dynamically calculate subw based on the exact character length of the test suite and subtest index prefix. This ensures the status column is perfectly aligned vertically across all test outputs regardless of subtest index digit count. Assisted-by: Gemini-CLI:Google Gemini 3 Signed-off-by: Ian Rogers --- tools/perf/tests/builtin-test.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c index 336d24105c9f..4c0caa8d0b27 100644 --- a/tools/perf/tests/builtin-test.c +++ b/tools/perf/tests/builtin-test.c @@ -373,10 +373,12 @@ static int print_test_result(struct test_suite *t, int curr_suite, int curr_test int result, int width, int running) { if (test_suite__num_test_cases(t) > 1) { - int subw = width > 2 ? width - 2 : width; + char prefix[32]; + int len = snprintf(prefix, sizeof(prefix), "%3d.%1d:", + curr_suite + 1, curr_test_case + 1); + int subw = len >= 4 ? width + 4 - len : width; - pr_info("%3d.%1d: %-*s:", curr_suite + 1, curr_test_case + 1, subw, - test_description(t, curr_test_case)); + pr_info("%s %-*s:", prefix, subw, test_description(t, curr_test_case)); } else pr_info("%3d: %-*s:", curr_suite + 1, width, test_description(t, curr_test_case)); -- 2.54.0.823.g6e5bcc1fc9-goog