From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E08E7261A for ; Mon, 1 Jun 2026 00:36:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780274173; cv=none; b=sgTia7CGjUZ01Zeyu04oJ3QzvelYIhddUAwH/7hLb+xQ7NyreTVGn6TU04eziR5PZncmwpoa8H6hmh3aSzvBmH1SntFnhT6rMXaQRzluMEzcSDzzIy7Vq8gbOfmfoHuggK1mvG5Vca/UJk8CtyVW54GYlPbBBgcbunejpNzPOTw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780274173; c=relaxed/simple; bh=hx410UHSdlgBtjJ9H09sx+B50T4kbh0WwKJI7BtUBdU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Rlpb/q01UcY3bNaKOmYQfl+OpkInwnl5B+dyQt642FD1R9hwaddZbRHzb0QPd9QXXK3H71ufh4HpYI98A6PCgBsBBOtL+iPpGeTxCUhG7yLXiul6WferAwSagHXq60oi+uoVc5sNncT7RAYMEsopoj7afYXUUih6gBRL3bLUwEU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dNQn7RlP; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dNQn7RlP" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2bf1f074a12so27851015ad.0 for ; Sun, 31 May 2026 17:36:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780274172; x=1780878972; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4Rpz+kGKDCFvWJqFvwgzUCdW4hrGHMFwU4vFb8j+Ivs=; b=dNQn7RlP3PtQEZlRmGSPx/WZo/y8U68kVPvnveuJnSflkfIayFRBa2QoOXPrVDhdnq aa5UCbLqP0Bh+xr1nRur6A7moz/zd1CEqOJjTkjklXu+xHxAFmcnvx08HhL4XhxuIv9K OD7Me1g2RDiW+8r025EovUXGIGwNhIYgoSX0AMrwsXc4gUJM176u0yJKcxsIA1PT/R2X CjpAK84VNVRc/gwuC9ZnfFEuD1H4u+fG9B52LIs8xyRGxNsTdHogztv821ggbl9qd8tb RkqYnNswOZ0Lm+redcdOJR3H73DzqHUTKr+eUaUurVI3f1FLuIIuh0n5VlvHs8spmvDx lN5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780274172; x=1780878972; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4Rpz+kGKDCFvWJqFvwgzUCdW4hrGHMFwU4vFb8j+Ivs=; b=iuSbIsH0b2Tnzss3bo3HW+tKTAVNaN5t1KOJKpu7ezkmnimZCK0k8C+5X1CcSSIqMx sGzCF4bCw/SCaW3QQxH7cOZsPnAtPf0I7dPRK5gkT2r314qrY6fRdwwY3yTwLljBCOoc 6SaZkdya2QTjjNkwqvj0gbPFuf4dxa64h4o1xfIQ2DEx8rgDdB4wpza3JINb+UtvByxP F26SMV0csB4jjiQVIUpLwuJy/E/5Y0VhKFNXLJ075oUHlxyIR6jF6giSRuNoYHnBUquD K2vb19aniqJ0zA/tAM49WuIjBFiIcxPR0EbnSwFoHKb21DXhkZZAxtJeSMWI/rlofib/ oo3A== X-Forwarded-Encrypted: i=1; AFNElJ/KmAeQvP5qZL4XjhdERRD7Fw0s0re+pdRHvEiEDI7UzD0r7NPAvooyqJ4dtBqmMUufKu/EUabReKuBUYY=@vger.kernel.org X-Gm-Message-State: AOJu0YyJbl6Eh2jvPVOYfFGxQ95Q4ZqmOHOahqPn5KViAd+FdJz7AJFZ WprEtrlQ1G5I9LqpP0QZkckc/OSzrya9w09fpLNxX5Ptt3KVcrR87p+L X-Gm-Gg: Acq92OGO6Bkiv5OrMmPwbmyTU6fwegWukXoKOjK2TnSGB1K/2R8ncGQBynkYhiQj3PX T7pxP48g4ql13uo7FlnUq+vNXI9eKn2Ly1J4dcc2e71F4iEsXMbZlbqmDFOgmoLaKFkNgvuqYRE JlWdV2KyCLg9KYtjOErRemt2E21gvYTMkv/n7As3icOcSzTZik6V0u114fGVcZWR8nLV+qtLDv7 cEIPAQC8kVa9aTMENpFEbSDz8Tygi+6xS3X57xbV7PeGEU2OS5vUDK4/SGWZTy5lLCPdoDpSwWR D5h3L9tt6l7qPaCN1cX3x+DEYw3fvSlnDINTSd76l5Gl4338JXNUX5GGgxUAhHaBLmqiIie8LfS QVgi1aoWvEjliGklVdda7eQTfe31BX+ZJlWnQqV7xDCXN9pO028C5Q4CbFxKVr0a2HaVYeaCiQ6 VoHqBOUtT4XKFiV8IP1EKUpnPScBbwd08eGxQZPz3LXgGK39Pc5F2A72yRrGl/kYiP3td4UNRxh O7NuoyAn8EbFkDJRGR1/pdAuVoVmZqjpd8d2a6lhREYxw== X-Received: by 2002:a17:903:244e:b0:2c0:d097:51bb with SMTP id d9443c01a7336-2c0d0975539mr32384195ad.1.1780274171867; Sun, 31 May 2026 17:36:11 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf23b011f7sm111929565ad.41.2026.05.31.17.36.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 31 May 2026 17:36:11 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Peter Ujfalusi , Vinod Koul , Frank Li , Haotian Zhang , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 1/5] dmaengine: ti: omap-dma: fix missing return in probe error path Date: Sun, 31 May 2026 17:35:49 -0700 Message-ID: <20260601003553.72573-2-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260601003553.72573-1-rosenp@gmail.com> References: <20260601003553.72573-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If of_dma_controller_register() fails, the error path omits the return statement, causing probe to continue (and eventually succeed) despite the DMA controller not being registered. Add the missing return rc;. Fixes: 2e1136acf8a8 ("dmaengine: omap-dma: fix dma_pool resource leak in error paths") Cc: stable@vger.kernel.org Assisted-by: Opencode:BigPickle Signed-off-by: Rosen Penev --- drivers/dma/ti/omap-dma.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dma/ti/omap-dma.c b/drivers/dma/ti/omap-dma.c index 55ece7fd0d99..0f6dd6b0a301 100644 --- a/drivers/dma/ti/omap-dma.c +++ b/drivers/dma/ti/omap-dma.c @@ -1828,6 +1828,7 @@ static int omap_dma_probe(struct platform_device *pdev) if (od->ll123_supported) dma_pool_destroy(od->desc_pool); omap_dma_free(od); + return rc; } } -- 2.54.0