From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2CA6360EFC for ; Mon, 1 Jun 2026 08:49:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780303743; cv=none; b=JuiwhS63L9mozV8T3ezahacYygAU7rDyLporeLz8y0WxpYYodNGsBfcB7W+WEL51zwP9PWuRItzNkqgY1U5Zxp5jQxklMUzMnL9QVqF2nFrV77KT8bahhgSaN/oM0cP+lRcdHofqlvE9/kinQHBv395rIJYYlmzx1BjsmFZKY0M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780303743; c=relaxed/simple; bh=QgZxJDmxK15glKgdwvuQXKx4II7jp/jciswRkVewa3M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OGWi5YYWZq3E72AJ0QatCkdUvqUW2N4wwwESSYjt9TIjZjm38yElknJTuS7dwrLhEpppclX/iYS471FbHk5L+/lqnAGbnbzIadod/1RDf1InIK3LBVarZtw6COrCFfsTTpoQQcqv3QUXoVJK2SUc3PZs3/LVsdiCYlA8HRKsLmI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=RrwEJV3t; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="RrwEJV3t" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-8423f420455so361888b3a.3 for ; Mon, 01 Jun 2026 01:49:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1780303741; x=1780908541; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8iZQN+oxehRhbRDFp2Djf7RG6EvHlnyDB08mWf0NvrQ=; b=RrwEJV3tctoHVfOdjruG43UZCeUczbChzvplAurXod4vB6cY/8nvQGPUotGkjzMfP5 JuHKysyZAavyvruxpl4uM9fXthSeTeITN5gplmxJecHdJtwrNx6kwsYRtN2HKL0Ihuss u6wSt749kl4Rk87uRyK4gbPvXUyrfnBIfQf6P9i9RotkJkQ2lXuOur/iAwO6NQpITd0v YmC8+LMehaklomXReoePhb/RSPjnOCY52u/pfS0H/DYeIgW7qN90b+upBNzNlzZBJb53 fXr3lLCXWWV/7W91TrSTMrJkplNxP7n6rF/8oJ0nvUEBRThwi53qvCJqIuz17YmsyEWE rRUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780303741; x=1780908541; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8iZQN+oxehRhbRDFp2Djf7RG6EvHlnyDB08mWf0NvrQ=; b=To/OuX3NVut74P+DvYqgBAke4FtDMSqhEbAEuukk+PG/6gpoWHcoKzsIiTPnLY6gK5 3XlvrlfLpuy1Vbe9OucaR6rniSNcSiLCuMHn4n/gTNl0DIitlJ+/CsOtPzCHTa1MQ/pP 0VCjJnlRYlQizlOVfH1L561CZkKGpXq3hFi22XLvPEjpDtX6aSDQgexGgsBy/XOgiGX0 ciRS1xpb8Q0beY9NLRU3+lULJHZ3ud6zdms3KdOZgjurS1HpRumlIsPLhl6UQZVoJxx/ yKIbpc/n/O1kq5W5BB1sK0ZiDiab8Yz/XAHrd4X0LKI/PTSETDtTBsykGdWkGA9HI3nI sb/Q== X-Forwarded-Encrypted: i=1; AFNElJ/pxUorN0EbSMKI2g6/fmpdohRrrpzFcRcrAmiLTMycaKwhsurv9T7tGLJ/PAbNy/CSuy0h8lYw/spCAZY=@vger.kernel.org X-Gm-Message-State: AOJu0YyOaVrBqSwKXcrw4IHoYqGnUORg8RGjsZs/XhpVX5WkxlIvF0/H 23IE7ivHAR1NEWGl1ybM0q1nMK1Pz89tulryDHMZLa5eefbVCpj9lOAaqTAzpfiI9g8= X-Gm-Gg: Acq92OEza9hdjEsXovtDMSLIEZVS45N3TLZMz59ytr9Dju9HhPGOvvYNnqD+XU7sgIR FkzKFL5gOxFwketa2d36H0xXhsNl4+oMvukZ/xauvVYDiDrLlGWZE+UVXtoefJ06D6rTZxeY/hN ZmkAH08U1teQCaEefS2SgZ7bY48pDVpDqFwmiHbI/n0D5EHiJNcYsOwfsCELqhT4aobsBb/bboD HMxYIFiV/0x2sNx0T4RLa02k2ga7G/Jggbk13cNScVg/MoevrJo1K7pfYhOD3muBHJgaRwSlmnA dK9CxzcEf1F7Z1oFmv7PGFsfYBR+yeKw/N+nUqq/v1BnRQBVVh3/CVzZqJ8RjLnGXxDby5byRJt y6mmKJgFBFY/eqiDwj945MtOthiGJPH2CwNa8upiFrSN/CRGnCLMY0U5mvkyPDA/nU2++UBSSL6 gjppwqrx7vz/8EUeyWQ4/4uR6fwWYe5POwZDOyIllQx7htcyJvZw8j3g== X-Received: by 2002:aa7:9a86:0:b0:83c:928:6e5a with SMTP id d2e1a72fcca58-84225376b00mr9579300b3a.13.1780303741104; Mon, 01 Jun 2026 01:49:01 -0700 (PDT) Received: from n232-176-004.byted.org ([36.110.163.96]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84232ef8172sm6316230b3a.12.2026.06.01.01.48.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 01:49:00 -0700 (PDT) From: Muchun Song To: Andrew Morton , David Hildenbrand , Catalin Marinas , Will Deacon , Palmer Dabbelt , Paul Walmsley , Huacai Chen , Andreas Larsson , "David S. Miller" Cc: Muchun Song , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, Alexandre Ghiti , Albert Ou , WANG Xuerui , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko Subject: [PATCH v3 1/5] mm/sparse-vmemmap: provide generic vmemmap_set_pmd() and vmemmap_check_pmd() Date: Mon, 1 Jun 2026 16:48:40 +0800 Message-ID: <20260601084845.3792171-2-songmuchun@bytedance.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260601084845.3792171-1-songmuchun@bytedance.com> References: <20260601084845.3792171-1-songmuchun@bytedance.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The two weak functions are currently no-ops on every architecture, forcing each platform that needs them to duplicate the same handful of lines. Provide a generic implementation: - vmemmap_set_pmd() simply sets a huge PMD with PAGE_KERNEL protection. - vmemmap_check_pmd() verifies that the PMD is present and leaf, then calls the existing vmemmap_verify() helper. Architectures that need special handling can continue to override the weak symbols; everyone else gets the standard version for free. Signed-off-by: Muchun Song --- v2->v3: - Replace BUG_ON() with WARN_ON_ONCE() in vmemmap_set_pmd() --- mm/sparse-vmemmap.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c index 112ccf9c71ca..99e2be39671b 100644 --- a/mm/sparse-vmemmap.c +++ b/mm/sparse-vmemmap.c @@ -386,12 +386,17 @@ int __meminit vmemmap_populate_hvo(unsigned long addr, unsigned long end, void __weak __meminit vmemmap_set_pmd(pmd_t *pmd, void *p, int node, unsigned long addr, unsigned long next) { + WARN_ON_ONCE(!pmd_set_huge(pmd, virt_to_phys(p), PAGE_KERNEL)); } int __weak __meminit vmemmap_check_pmd(pmd_t *pmd, int node, unsigned long addr, unsigned long next) { - return 0; + if (!pmd_leaf(pmdp_get(pmd))) + return 0; + vmemmap_verify((pte_t *)pmd, node, addr, next); + + return 1; } int __meminit vmemmap_populate_hugepages(unsigned long start, unsigned long end, -- 2.54.0