From: Yi Sun <yi.sun@unisoc.com>
To: <ynorov@nvidia.com>, <yury.norov@gmail.com>
Cc: <yi.sun@unisoc.com>, <mnazarewicz@gmail.com>,
<akpm@linux-foundation.org>, <mina86@mina86.com>,
<akinobu.mita@gmail.com>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v4 1/2] lib: bitmap: reduce the number of goto again in bitmap_find_next_zero_area_off()
Date: Mon, 1 Jun 2026 17:42:33 +0800 [thread overview]
Message-ID: <20260601094234.103863-2-yi.sun@unisoc.com> (raw)
In-Reply-To: <20260601094234.103863-1-yi.sun@unisoc.com>
Finding a contiguous free region in a highly fragmented
bitmap is not easy and may require many repeated attempts.
Therefore, find_next_bit(map, end, index) is not the optimal choice.
This is because there may be multiple scattered free regions
within the range [index, end) and none of them will meet the length
requirement of @nr.
Instead, it's sufficient to directly find the last bit within
the range [index, end), thus reducing unnecessary "goto again" calls.
Signed-off-by: Yi Sun <yi.sun@unisoc.com>
---
lib/bitmap.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/lib/bitmap.c b/lib/bitmap.c
index b9bfa157e095..7d0fbcbe6973 100644
--- a/lib/bitmap.c
+++ b/lib/bitmap.c
@@ -432,7 +432,7 @@ unsigned long bitmap_find_next_zero_area_off(unsigned long *map,
unsigned long align_mask,
unsigned long align_offset)
{
- unsigned long index, end, i;
+ unsigned long index, end, i, index_bits_align, index_idx;
again:
index = find_next_zero_bit(map, size, start);
@@ -442,8 +442,12 @@ unsigned long bitmap_find_next_zero_area_off(unsigned long *map,
end = index + nr;
if (end > size)
return end;
- i = find_next_bit(map, end, index);
- if (i < end) {
+
+ index_bits_align = round_down(index, BITS_PER_LONG);
+ index_idx = index / BITS_PER_LONG;
+
+ i = find_last_bit(map + index_idx, end - index_bits_align) + index_bits_align;
+ if (i > index && i < end) {
start = i + 1;
goto again;
}
--
2.34.1
next prev parent reply other threads:[~2026-06-01 9:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 9:42 [PATCH v4 0/2] Improve the performance of bitmap_find_next_zero_area_off() Yi Sun
2026-06-01 9:42 ` Yi Sun [this message]
2026-06-08 22:15 ` [PATCH v4 1/2] lib: bitmap: reduce the number of goto again in bitmap_find_next_zero_area_off() Yury Norov
2026-06-17 8:55 ` 答复: " 孙毅 (Yi Sun)
2026-06-01 9:42 ` [PATCH v4 2/2] lib/bitmap: add tests for bitmap_find_next_zero_area_off() Yi Sun
2026-06-08 19:14 ` Yury Norov
2026-06-08 19:24 ` Yury Norov
2026-06-08 7:44 ` 答复: [PATCH v4 0/2] Improve the performance of bitmap_find_next_zero_area_off() 孙毅 (Yi Sun)
2026-06-08 21:54 ` Yury Norov
2026-06-09 1:06 ` Yury Norov
2026-06-09 2:09 ` John Stultz
2026-06-17 9:00 ` 答复: " 孙毅 (Yi Sun)
2026-06-11 10:56 ` Michał Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260601094234.103863-2-yi.sun@unisoc.com \
--to=yi.sun@unisoc.com \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mina86@mina86.com \
--cc=mnazarewicz@gmail.com \
--cc=ynorov@nvidia.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®