From: Jonathan Cameron <jic23@kernel.org>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: "Javier Carrasco" <javier.carrasco.cruz@gmail.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Rishi Gupta" <gupt21@gmail.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] iio: light: veml3328: add support for new device
Date: Mon, 1 Jun 2026 10:21:16 +0100 [thread overview]
Message-ID: <20260601102116.3e7dc661@jic23-huawei> (raw)
In-Reply-To: <CALoEA-wtEVO0+GaabshH03FLGBJu0JkyQi_FjSETzcAySAKERQ@mail.gmail.com>
On Mon, 1 Jun 2026 08:56:17 +0200
Joshua Crofts <joshua.crofts1@gmail.com> wrote:
> On Sun, 31 May 2026 at 21:26, Javier Carrasco
> <javier.carrasco.cruz@gmail.com> wrote:
> >
> > Hi Joshua,
> >
> > Just a nitpick I caught on the fly because it was missing in a driver I
> > recently sent as well.
> >
> > At least linux/mod_devicetable.h is missing to include of_device_id.
> > Probably that's the only missing header, and it could be added without
> > sending a new version, but that is not for me to decide :)
>
> Hi Javier,
>
> Good catch, I completely forgot about mod_devicetable!
Tweaked.
Applied to the testing branch of iio.git.
Thanks,
Jonathan
>
> Thanks!
>
prev parent reply other threads:[~2026-06-01 9:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-31 16:56 [PATCH v4 0/2] iio: light: veml3328: add support for new sensor Joshua Crofts
2026-05-31 16:56 ` [PATCH v4 1/2] dt-bindings: iio: light: veml6030: add veml3328 Joshua Crofts
2026-05-31 16:56 ` [PATCH v4 2/2] iio: light: veml3328: add support for new device Joshua Crofts
2026-05-31 19:26 ` Javier Carrasco
2026-06-01 6:56 ` Joshua Crofts
2026-06-01 9:21 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260601102116.3e7dc661@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=gupt21@gmail.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=joshua.crofts1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®