From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB2C43DDDCD for ; Mon, 1 Jun 2026 15:19:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780327164; cv=none; b=eHvMWhNrDkN7D6RwYlOglUPvhIW5kLbSy0czlGmI9o+0/ck8L/AfNYP0FOwRRgZvJpXQUChwCoTkty6CqSmfZgNhKiOWOAJ5tm+A5+Ur4ZVPIQLEGxKPDdhgpNekIJnDS4zb27NSqBgJyfIh67uEAm4K57vB7lWQ5OlgW1hs0Gc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780327164; c=relaxed/simple; bh=+XJVhU2zPkpnCe5OFCObMG1j3Sj/CGVdrvJ521UPM9U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VUS/atTWZyF2EuqnqOji5S4TcScGIQMPSc9n2yglzZT8aad4nwKNSmbUaUtVUxDLZbFFwzU/oUhto9STzeLr3HwFamWoqdSQOcgCfDan94sKbkj1rvR6JNFhPiUUQZayQUHj48USHejBoiZ9rRHaewVQ5ez7W1YQ+agsN5kUXTU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V/pp/l99; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V/pp/l99" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4905529b933so78613195e9.0 for ; Mon, 01 Jun 2026 08:19:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780327150; x=1780931950; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MeSJxuqtwsz6jGt+YVFicWB8+6LnFt3NUvnbNkDL/mA=; b=V/pp/l9948g7rakEOQUQ390K7N9kJ7sXVs2zB9cQnAKPZYPQ6sZ1YrD4Koy1xcdl84 HC4gfDOvOdMpPzk/qeXJLABpNiGwsBwt5ITlcPpK3PzkE6z8hJlsRgki1V1byJy0VWld 4SEsVODptC2xv8sv58A4/pQq4icscBd+TTnMfcbhYPLvyxdRtRqOU1C3T5cmPbSdrrXh azI4KW6a9DXfUyqgjRHlh15vBYBpRG+o/nGy30xa8l22ZjenhGeCEleWIyPfDLdnmklB Dc1T8b3lly7M0KBDW58x0yNaIBxrPdIfIIzzIOefLFzWsn17usNDYX46ATubZGo/QMMn pGsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780327150; x=1780931950; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MeSJxuqtwsz6jGt+YVFicWB8+6LnFt3NUvnbNkDL/mA=; b=MlvzT1odqWRRXVwHqIjGePDoHAboIjZFDxNIfJF1e1McaPyvD+Q260FYG3kX6Xqob+ A55ywRzlRlnoAFr4ZwKUgvOyTyrfGZLhU43Hz65Ypd/cVuqD+z0HesQPQok1gkOY62Xa EIU5NY8z0aONvzfkuF5QUBZ2TSy9TgxyIfiWX4mguUmP9EV3BvhLrI2MO7NpWoa3ADc2 sDqsI1UypPLVXrrZCDZ/thQZWmNnJRUJ1mfB1USYr32+sR7b3A7z5yEiniQ+JEEAj2UD 0CkohjE07AauGjGa6EpsisThRbOvdNqOywPMsbG8fj/IRhts7EDDUSL+F22FOI0NWwZI 8crw== X-Forwarded-Encrypted: i=1; AFNElJ8QyFj94MH//vj3UjC7hR2YvZs889iVmCOCwl02mUzf0fhooT/JW2XRDGDVmvlPif6/4Ywya7HBRQcOvOo=@vger.kernel.org X-Gm-Message-State: AOJu0YzvGPFgqxUThPlQmmtyzc+wo8R0erMp938IvMS9uLBUUGxxP3bh MsiHZP6D2iqVF5RUUozGZhQam5vx7LX1uzW5RdEIzu96+OAaXIuE2h5r X-Gm-Gg: Acq92OHLXmxS6IWH7bbsGmsxTF8nvW7fBA60qbQOp1XJ+zX8a/M/q37Vs758ImtCz2Z UP1BxrYgF/fIbuTTCmh7BMG7i8xU8sT+JCJhyT4qyeEEvlNVH1vLyP4zXsN/h8uSU2HuGEeUZHk mKbdc4Oz4toG4EshXHE3aup9rzr8MDa/5E5AQczf8pmjv2pc0CzVIZ191gNbHkPdgYfsgQ6x5Gq Rnh9BeunfpUIDji5KBuHsz3hTnDn9Maj6aO2Ik1owEBdr9veLw95AMk54sOQbIeXM8HgRJNjOkl TqflIncxvEDWPYnwSazDEMH+ZIIcnLilUHr0uapZyPkRX3ZRjbeEeHPc5QkFBgydLMy5ApA3YBP 9RaMPoPs1hf5j0D+ietsnkQK37INQ8MGvkaqLjzcUYl4lwbH5MyIA0mmJ1m2j5l8fr+JRvTnEOD wgA1KmNL9GHm1lJZXO+kExMzM= X-Received: by 2002:a05:600c:4715:b0:490:7136:ad05 with SMTP id 5b1f17b1804b1-490a29748dcmr205098165e9.31.1780327149765; Mon, 01 Jun 2026 08:19:09 -0700 (PDT) Received: from xeon ([188.163.112.61]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45ef354cd7csm25753103f8f.18.2026.06.01.08.19.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 08:19:09 -0700 (PDT) From: Svyatoslav Ryhel To: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Helge Deller , Svyatoslav Ryhel Cc: Johan Hovold , dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: [PATCH v3 08/11] video: backlight: lm3533_bl: Improve linear sysfs logic Date: Mon, 1 Jun 2026 18:18:28 +0300 Message-ID: <20260601151831.76350-9-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260601151831.76350-1-clamor95@gmail.com> References: <20260601151831.76350-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Simplify the sysfs logic of the linear property by switching to a macro and a ternary operator. Signed-off-by: Svyatoslav Ryhel --- drivers/video/backlight/lm3533_bl.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/video/backlight/lm3533_bl.c b/drivers/video/backlight/lm3533_bl.c index c70b8a3bb301..36e6f027613a 100644 --- a/drivers/video/backlight/lm3533_bl.c +++ b/drivers/video/backlight/lm3533_bl.c @@ -23,6 +23,7 @@ #define LM3533_BL_MAX_BRIGHTNESS 255 #define LM3533_REG_CTRLBANK_AB_BCONF 0x1a +#define CTRLBANK_AB_BCONF_MODE(n) BIT(2 * (n) + 1) struct lm3533_bl { @@ -136,8 +137,9 @@ static ssize_t show_linear(struct device *dev, struct device_attribute *attr, char *buf) { struct lm3533_bl *bl = dev_get_drvdata(dev); + int id = lm3533_bl_get_ctrlbank_id(bl); + u8 mask = CTRLBANK_AB_BCONF_MODE(id); u32 val; - u8 mask; int linear; int ret; @@ -145,8 +147,6 @@ static ssize_t show_linear(struct device *dev, if (ret) return ret; - mask = 1 << (2 * lm3533_bl_get_ctrlbank_id(bl) + 1); - if (val & mask) linear = 1; else @@ -160,23 +160,16 @@ static ssize_t store_linear(struct device *dev, const char *buf, size_t len) { struct lm3533_bl *bl = dev_get_drvdata(dev); + int id = lm3533_bl_get_ctrlbank_id(bl); unsigned long linear; - u8 mask; - u8 val; int ret; if (kstrtoul(buf, 0, &linear)) return -EINVAL; - mask = 1 << (2 * lm3533_bl_get_ctrlbank_id(bl) + 1); - - if (linear) - val = mask; - else - val = 0; - ret = regmap_update_bits(bl->lm3533->regmap, LM3533_REG_CTRLBANK_AB_BCONF, - mask, val); + CTRLBANK_AB_BCONF_MODE(id), + linear ? CTRLBANK_AB_BCONF_MODE(id) : 0); if (ret) return ret; -- 2.51.0