From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28F0F184540 for ; Tue, 2 Jun 2026 00:55:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780361751; cv=none; b=CCkbhNuUSTwMj7+0k64rPGxH5dXi1DPvq0Ey7jG/lr1LuayT1Ji1rkhM9Yn2/kkoxzmkZ1mTEGUBOum166JXVrXw2nT7TxiesDe7dkn5+rJKM0tYU3P20YCmjcfHnVn1wxl8SpqLMbYc2rdtmp0szh92QiKjx0QPJxPUG5lvfsg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780361751; c=relaxed/simple; bh=wQX/fTA/Ud9aOmXH6q2r6QmRFHvCo8TCR08O0o2tx5U=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=uqu1B0EMsIrEDfh12Whax6jWCidznsOsnymHgcU0S5yAuoRlzQjHhxm1lSeqZsJMghqsDhTndqmb22gD+RaCcPIOACnrL9mPhtwm4uy77+eBoLhPpkthYTEfg2V6DfZUN4wnY6bqsq0Mq2nq9uZyNs84LXkoITZNfPJ66nlnM/4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=D0ylS6ho; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="D0ylS6ho" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DD811F00893; Tue, 2 Jun 2026 00:55:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=korg; t=1780361749; bh=X+k9ObpFP5t6bQtlEdnHyGzS2lQzbsu1L2tFoCMZWSU=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=D0ylS6hoqjdSIaxAZ7ZeRVhshH/uWSx4f2O8kIIU8Ia7SXnJXq59ARxvRJC7Hj6vO aZJ7MBXXDoQ1E3cByhAOJSeNUMgJdzkDJbuErNon+bx86UWus9vDJXVJ06IRjOXX+K rCXKhf14I4cu16CbimGBZlKeElJNq/XPHHEnT8GM= Date: Mon, 1 Jun 2026 17:55:49 -0700 From: Andrew Morton To: Charles Pellegrini Cc: egorenar-dev@posteo.net, robert.jarzmik@free.fr, t-pratham@ti.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] lib: scatterlist: fix sg_split() partial-coverage geometry + add KUnit tests Message-Id: <20260601175549.b4a10c07dd9e3b867f66da0c@linux-foundation.org> In-Reply-To: <178027099087.72481.1976843064458686851@gmail.com> References: <178027099087.72481.1976843064458686851@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 31 May 2026 16:42:20 -0700 (PDT) Charles Pellegrini wrote: > sg_calculate_split() can decrement its nb_splits counter once too often > and miss the loop-termination check, corrupting the last output split's > geometry. This series fixes that and adds a KUnit suite. Thanks. Has this been observed in real life, or was the patch motivated by code review? AI review (https://sashiko.dev/#/patchset/178027099087.72481.1976843064458686851@gmail.com) might have found a pre-existing issue, which you may choose to reject, fix, add to todo list or ignore. Also a possible issue in the kunit test changes. Please take a look, let us know?