From: Manjunath Patil <manjunath.b.patil@oracle.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
Manjunath Patil <manjunath.b.patil@oracle.com>
Subject: [PATCH] tracing/events: Expand ring buffer for in-kernel event enables
Date: Mon, 1 Jun 2026 16:24:43 -0700 [thread overview]
Message-ID: <20260601233716.2517987-1-manjunath.b.patil@oracle.com> (raw)
Ftrace keeps trace arrays at a boot-minimum ring-buffer size until
tracing is used. Tracefs event-enable paths already call
tracing_update_buffers() before enabling events, but the exported
in-kernel helpers trace_set_clr_event() and trace_array_set_clr_event()
directly enable events through __ftrace_set_clr_event().
This can leave events enabled by in-kernel users recording into the tiny
boot-minimum buffer instead of the configured default-sized buffer. Any
caller that enables events through these exported helpers observes
different buffer-expansion behavior than a userspace tracefs event enable.
Expand the relevant trace array before enabling events through the
exported in-kernel helpers, matching the tracefs event-enable behavior.
Disabling events remains unchanged.
Assisted-by: Codex:gpt-5
Signed-off-by: Manjunath Patil <manjunath.b.patil@oracle.com>
---
kernel/trace/trace_events.c | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index c46e623e7e0d..3ce5b0121c5c 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -1479,10 +1479,22 @@ int ftrace_set_clr_event(struct trace_array *tr, char *buf, int set)
int trace_set_clr_event(const char *system, const char *event, int set)
{
struct trace_array *tr = top_trace_array();
+ int ret;
if (!tr)
return -ENODEV;
+ /*
+ * Keep in-kernel event enabling consistent with tracefs event
+ * enabling: once an event is being enabled, expand the boot-minimum
+ * ring buffer to the configured default size before records arrive.
+ */
+ if (set) {
+ ret = tracing_update_buffers(tr);
+ if (ret < 0)
+ return ret;
+ }
+
return __ftrace_set_clr_event(tr, NULL, system, event, set, NULL);
}
EXPORT_SYMBOL_GPL(trace_set_clr_event);
@@ -1504,11 +1516,24 @@ int trace_array_set_clr_event(struct trace_array *tr, const char *system,
const char *event, bool enable)
{
int set;
+ int ret;
if (!tr)
return -ENOENT;
set = (enable == true) ? 1 : 0;
+
+ /*
+ * Keep in-kernel event enabling consistent with tracefs event
+ * enabling: once an event is being enabled, expand the boot-minimum
+ * ring buffer to the configured default size before records arrive.
+ */
+ if (set) {
+ ret = tracing_update_buffers(tr);
+ if (ret < 0)
+ return ret;
+ }
+
return __ftrace_set_clr_event(tr, NULL, system, event, set, NULL);
}
EXPORT_SYMBOL_GPL(trace_array_set_clr_event);
base-commit: e43ffb69e0438cddd72aaa30898b4dc446f664f8
--
2.47.3
next reply other threads:[~2026-06-01 23:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 23:24 Manjunath Patil [this message]
2026-06-02 13:00 ` Steven Rostedt
2026-06-02 23:53 ` manjunath.b.patil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260601233716.2517987-1-manjunath.b.patil@oracle.com \
--to=manjunath.b.patil@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®