From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7ABC13D6465 for ; Tue, 2 Jun 2026 09:12:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780391545; cv=none; b=j19pUiGoL31Lw3pi62WXXDNjqzrr+W7R3nYGkI3bLU0PHIU17qogdKQhP0ELb3nCDv+/dLmNHQwQhyAVKskjzXBStwoS0NfGTGRsmJc9ZAjNCJbeR6CW3wQ9GkWBCbB0J3n0iplwdixgxEnvlaVHYW8T+83BVmZI+e+uGRsHLiY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780391545; c=relaxed/simple; bh=4TJKG8RTz4R+dv3UNXgRl/mjeEf45SUuZJzked/IkbU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kzL6v1iZMLDEQIlTlAhbBhIKAhAcyRMdwBgG6UhTsUR3Kh3ESmHF3BZh0MeU6+XK+xkmgMP5X7kx2AkPPq9KkgrTC83qwCj/fdKO7Hz5pVDAcierEqEgmJ5mrorEEWAU7D5gCR6M4wtPZdnQqwiZBclLkDR17gdN9CYf67+bY3U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hohob0sA; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hdqCW9jJ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hohob0sA"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hdqCW9jJ" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6528QnYc3430226 for ; Tue, 2 Jun 2026 09:12:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sRjgMQtRt4M0KMMF63fnqZRXOOmmbwogwYrfMYQ8brA=; b=hohob0sAycBvqqdr cpqG86dXz2IaSY+iEs6Fq9x3tkF8+NOvcQuM/5nPzi+lQY3Uiy/JVmBR4uvuLowP hyT75i07ImJtfhKJ7W2xOHEQITteMr72bs6QYvQbWxvxY5PjvQ0t87Gql+9n1Vvh MvF9dijyx66cC42mwVHXfviM44ZLijS1nGnFBYd3WVmFEf7jEYCaxFAGhPXVQzE+ 0SLEM/wQMg9eDB4MoLOjEr1XNlZfo3Kn3fDZiuPgAGu1TMr7v1utOU17ztDdEIxP BecNJPXC7JiKiqaFHBbsa1dDhL/MblZCozL3+iUea+MdOU0tI3GIFu6uGW/R11h3 D9oFzg== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ehn8mhq55-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 02 Jun 2026 09:12:21 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51771d41426so4631991cf.2 for ; Tue, 02 Jun 2026 02:12:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780391540; x=1780996340; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=sRjgMQtRt4M0KMMF63fnqZRXOOmmbwogwYrfMYQ8brA=; b=hdqCW9jJSmRrCezIhE+1P2qSDosgT1uOHCrilm3ztj1SB0t0N5+w/hzu5SA1xYAb6H doFg9rcS9h1SzVaabWvfpRZuLsxNDCzToB62zv5wxamSKXk+zLoodkxVQeD52RCvBgvJ +40oymd0RJHStgxWOTdTmaIVqXB/LbQNfAdjZBweknQvVYGwckuxKvKkhPSGeW4HabKM xAhiPH/hLEvS/wtMYc3sJojJ+n6cdFElFR8fQ/H2eebdls6TvfWWuTA1E5sDBi+YX+WD 8vDu61+A774OsAdJQfk+Yc/3IuZ9uWgFgDJWS+ibwuCIN84b9FDlxiIScDPmak9j1mH0 XV8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780391540; x=1780996340; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=sRjgMQtRt4M0KMMF63fnqZRXOOmmbwogwYrfMYQ8brA=; b=cbghNH/jnaq8jGe9mEpacAExlrRXBieeZbF2pYmDlIdK78cHtdtk2SLry4AZKXTU1B BJa5uJfqbfC3aBGUJkUzaceMobe6LStm1kTdw+625pfAYvWxZs3+wnfeWmSoYIA5eMjo VShbVnBL17QCshE2XrTUvFsuyGq1YJ99ndP7bh0eGqmzshXHjQrLDcJxDSslJy1PipZI 8RWnpmeCgGYabXa0DZEN8tEHgNimU5oniUK9wkwbm8jnXuemThn7JGb5H8BVgRow39bZ ZpSD0TU7PnlKiQFX2k/nYNC56eVtJFW++xGPzTlzyz2igoqAZ3TmMimKRKHEpkqKNbKg txSw== X-Forwarded-Encrypted: i=1; AFNElJ9ZgbxdscwhYpoQgaDD67p19a/E1XnUZmKK2UPQXbya1Xz6tM8IsGkb4RWXz3Y5ixKjlb4jrDwgqGY6PKU=@vger.kernel.org X-Gm-Message-State: AOJu0YzrY0Ws5EeJOwu+ShI8hzvd+f1Ffdy9ZNqPZUCEBYd0jOV+oKNQ 2+UozwKcHnACaFVZjNwy09Zmtr/deixHuKHq/lvierUzKTGdcMWFPIHLacnQi2R+HAy1TvJC0y+ IpdhXxSdgbSAAP/tI/FVoQ+P6Y/Fp8JTZ+sYAgic8s6Xp3y4sD7yXyapnFAoiDR/ohK4= X-Gm-Gg: Acq92OEPJH3JPcmgL4G1nP5Lf+V/sJOVgz+C5Jf+1Nv7SM54mM1bK4d/b0/TdDQw+1g G/7FLBsFF1YBT+ZW0W79jsfxLS5OlORoHGE7EiB0VPR1HcD/xYL8r1wfM629CNHQdpuBcE+ieKE xGQB2rpMLKDzEvWhK7fMMcPo2x+H/3uPfLZon8EgMG/5YOxaLm/Alp09NROzF6q47Vn4ZoYhYUt 1Z0QvgypYfutgi5kJW0f1Uc0aLo3OqRL4QaliR2Hi+iAZ96IGiWFuIBsqlBIiOnSXtPEMGRISoq t0DeGIkx2stnUeCKViJC6SYrjS1qFMAgOZ8bpjFSD1EY+zgIxdZIOjgqKAle34Q6RrvtUsvYvvx dY95LbuszLYAf0N9eN+wsbOKYS+B5kgOO++/yJb3V1F/DL1sJf5R1uuSH/7+5Y2qvyXyiviGuMV /MYfdukRa+wkr1rUwlOw== X-Received: by 2002:a05:622a:5588:b0:516:d4b1:48cc with SMTP id d75a77b69052e-5173a5b4efbmr215705171cf.8.1780391540620; Tue, 02 Jun 2026 02:12:20 -0700 (PDT) X-Received: by 2002:a05:622a:5588:b0:516:d4b1:48cc with SMTP id d75a77b69052e-5173a5b4efbmr215704941cf.8.1780391540253; Tue, 02 Jun 2026 02:12:20 -0700 (PDT) Received: from yongmou2.ap.qualcomm.com (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51768c76e53sm12480851cf.4.2026.06.02.02.12.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 02:12:19 -0700 (PDT) From: Yongxing Mou Date: Tue, 02 Jun 2026 17:11:24 +0800 Subject: [PATCH v6 12/15] drm/msm/dp: simplify link and clock disable sequence Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260602-dp_mstclean-v6-12-2c17ff40a9b2@oss.qualcomm.com> References: <20260602-dp_mstclean-v6-0-2c17ff40a9b2@oss.qualcomm.com> In-Reply-To: <20260602-dp_mstclean-v6-0-2c17ff40a9b2@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou , Dmitry Baryshkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780391476; l=1745; i=yongxing.mou@oss.qualcomm.com; s=20250910; h=from:subject:message-id; bh=4TJKG8RTz4R+dv3UNXgRl/mjeEf45SUuZJzked/IkbU=; b=ox1G7nychJ7oiBzA35Qma6lzidQKD+nkk6+TZgyPQArcq3cOd+PwVMakMQT4j5LHOjZb+smiV 9CGT1edwi8UCq2Zn53qsPUrVFxLMT3ox/KsmqBNE7QmpzHyHPCKA4pc X-Developer-Key: i=yongxing.mou@oss.qualcomm.com; a=ed25519; pk=rAy5J1eP+V7OXqH5FJ7ngMCtUrnHhut30ZTldOj52UM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAyMDA4NiBTYWx0ZWRfX7jVU1ceXFjwl WwzpyVKYSXdaZTYw3QLzkKtxRaa9HVAHai4UUH78MNYwuJoJ09T+BpyTiFpI1FZs+a7evT7oRk+ AuqynWQQ9QH9Oswt2G0y3ZEpwn52ipz/BmBjUYnhnm3x6ruCowerugvSkWlMYcFNcjUVqUffqi+ bEKeuAFRUutbQkQcc38ikWishmB4Lk+fU8ja6lw9G8KR56xEhMQGoToNKLKSXR5xU/YYd6W6HSa indWGqZA+B3XhSe15R9dEZx5t0nB33SJelxxA9ZDOCG25YLDkuwL6g1QTD+wnEroxokRcwXp6ZG ++H/flV0oNSagk7wSiowkhoAq27xjVoCnUhaDHpcEClnCMVqbYaqGv54+fyPKFAmUxLcaYh5/cN 6ZegnVysmWRclXP7qPgORqWXi/gINZwIQEfv4yXw5iVdAXiMJUg2f/t7xFVHLbEWQvvdghgdZUw NABjeNhQfq1gMGneQsA== X-Authority-Analysis: v=2.4 cv=d5nFDxjE c=1 sm=1 tr=0 ts=6a1e9e75 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=W1j8KJVysGQzs9t885kA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-ORIG-GUID: 28fyyF6h85XRg1Rly_VIqBbXjc9i170u X-Proofpoint-GUID: 28fyyF6h85XRg1Rly_VIqBbXjc9i170u X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-01_07,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 malwarescore=0 clxscore=1015 adultscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606020086 Move the common disable steps out of the sink_count check to make the flow easier to follow. No functional change intended. Signed-off-by: Yongxing Mou Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_display.c | 26 +++++++++----------------- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 8f472633da82..63e5b191f95c 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -716,27 +716,19 @@ static int msm_dp_display_disable(struct msm_dp_display_private *dp) msm_dp_panel_disable_vsc_sdp(dp->panel); - /* dongle is still connected but sinks are disconnected */ - if (dp->link->sink_count == 0) { - /* - * irq_hpd with sink_count = 0 - * hdmi unplugged out of dongle - */ + msm_dp_ctrl_off_pixel_clk(dp->ctrl); - /* set dongle to D3 (power off) mode */ + /* dongle is still connected but sinks are disconnected */ + if (dp->link->sink_count == 0) msm_dp_link_psm_config(dp->link, &dp->panel->link_info, true); - msm_dp_ctrl_off_pixel_clk(dp->ctrl); - msm_dp_ctrl_off_link(dp->ctrl, dp->panel); + + msm_dp_ctrl_off_link(dp->ctrl, dp->panel); + + if (dp->link->sink_count == 0) + /* re-init the PHY so that we can listen to Dongle disconnect */ msm_dp_ctrl_reinit_phy(dp->ctrl); - } else { - /* - * unplugged interrupt - * dongle unplugged out of DUT - */ - msm_dp_ctrl_off_pixel_clk(dp->ctrl); - msm_dp_ctrl_off_link(dp->ctrl, dp->panel); + else msm_dp_display_host_phy_exit(dp); - } msm_dp_display->power_on = false; -- 2.43.0