From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B21003D3D0E for ; Tue, 2 Jun 2026 09:11:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780391498; cv=none; b=VMER5lNs42JMQu95jyhpGBwsHYszlePOI9M1voiwfslKoLPmnm2mW0wn/qV9BjGD4aaL6fzrRbmwsV/HGq+05GyR5PzY66m/axpGG2ueSo2B1LohAnmaAdWGazPBdzt/xZ2XOKDpqeqjFkdB/fJ4zaCZDqN+LFxjC7fYmucnPQI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780391498; c=relaxed/simple; bh=utX2rWcnEK7sp26OqAqarcDBJ0uE50FzNeV/RPRB27I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HAjtvTptcAmDdwqT18ws0jYozT7GfP+isr6c5q1HRSYTyBcKXCMGuQuYD1abddPEzfvVgOOwOYKpqXzlaI4tk7zLDnHY5RaDqaTElthbTPIjMYQ0iowfDpkFPk00XIU8zeR6VkR09f9rNz2VkX1XbK9PdYQzIyPuQ+c9Aj2f+nU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NhQ+nnwF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=N+ocnsdk; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NhQ+nnwF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="N+ocnsdk" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65245gHF2691969 for ; Tue, 2 Jun 2026 09:11:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gsb2m0YYMxi0oazQhslfYqgxjuHbp4QxtyHnC/SdYhY=; b=NhQ+nnwFQIqLvsxK usM8NbLj3GXXjVo4WCpjg0VtXp6DyrpbRjRjtqzFR5HD0J0TiCOiyr1LjeS4tK+n g/Ia/ZNvBh4qkVaYkgfU+nzH72IDBZZ7FwCZh74q0cvyL4rN5xLYb3B6Z1FytBK3 hRwCQGtoQjD2NLeV6i8dmg/5uOOkaxEXSaE0yJk2bJxnBfFyalolAbFFvATM4u+7 LP2sq846VdAkUYYme4Xc+Y8xrJIWoAXorNuu6yj5plyWkT5qSB8PYTYzQH4U3LVP gwAOE1EeUw3dFHHkhZvqz/ClPvjDx00ccsOa0UFZoZ/v3SRyAiFxQ8NPdWlMbVsm JzkZCQ== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ehqumh6e5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 02 Jun 2026 09:11:37 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-516d13328dcso225032351cf.1 for ; Tue, 02 Jun 2026 02:11:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780391496; x=1780996296; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=gsb2m0YYMxi0oazQhslfYqgxjuHbp4QxtyHnC/SdYhY=; b=N+ocnsdkedZvhwMsYMfvKk1gIeaVgVp/o+LM7Ijp0qZQEoCNwekEiU7eLiwL0HhRMS CKEgChT8A11+MXe7PY+jrXgx/iDQyUirfjkw6pYSjYerMKVdkp/Mqp+kw2Plp3s+WsBk bGHBvTHfLvcj5ZI4ajeF8GQHz1rETC2h33nycLSvjwiP//UDErxlByqUfK661zgAlmKQ 4StqH30nzcWjB6w8T7s8CzFOSBox267bTUvf0ggXna8u6IUZH/g8hlwGeW3gn154Urpu UuE+Da1Dj9KbWUE92ZCl320ytXczieo7LuhE2mRrAplzSY95fQebLFN7IvFaImLGqpyB 0cbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780391496; x=1780996296; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=gsb2m0YYMxi0oazQhslfYqgxjuHbp4QxtyHnC/SdYhY=; b=o2ztxzosxRHeJCT9ALXK7H2LH7ZjNbkQu/msUcFpdaPO1TVMnAnd3scTiMTI40VTfi i8XZ6GMkLSqkRRS/1o1EdK9ZefP68zYDix9/O1uhrtolobPj6mSwf1TylKPxvnXTIlqb GeCBCcRHsQ7kUt/ZrcLgLMcXWZfbhXs0b0g0ZoxNJMYx5dAEt5pBlXQCljQ2LMSYuz8r bPMIbo9QMZ2HjKo9PSbqvEEPb9lmQtcIgNWzk7X1IR1M91LdMN1CqK3Vud57CTlVk0aw yjhHzYM2uZr6Vvw94ik++pRyoMsS0LJipULuXW4UsItZE/hIjGelpTvCivyg7wdXhBmh 80tw== X-Forwarded-Encrypted: i=1; AFNElJ8j8okyKRKtuIpCxHdcB5twxQcLl417vxzYRRVS8YIE4Jhfmoz1cRdp0rTBtVbQFAP1o3AGnnsAE7QMfqk=@vger.kernel.org X-Gm-Message-State: AOJu0YyeQZIndgojodzfW7kxEaqx/YlPHtxb8C6dmSfvyjO7b2hRrN7c o5QizpHHWqOTITENQosGsxO7Pvv61tSvybQ9uktI3aDawXg+zb21r/tJ48wmNmyyNHve+xDGMIz J9SBg88e9iBgrWe2ItNHaOPBWynK4Y0Y3xhuezJn3uHqRdW5EdcC5+ar5fd/jnNc4P7okJCGxLv hv6Q== X-Gm-Gg: Acq92OGfWZB2C+dorCt457IKOKX7Y7G0IOLVe2w0wjpOFx8GoMX1ELCX3oIWXJzClBz YPC6mWV6x8TF7WVbIKLGG2osbg9lJOqFYRJ0pA2z6buB6cfGr55KJ4WRghJfVbb+3vKHWt4TVAl dsImy6vvgkjUheVDDcVgZPdAkEfY/E38XumRQgeem/lT50eohx/bbQT5Jb8FhwjrOaZeDsTfX6i yagxhUqPJl/sjvmi+R30ynhMIoFhDZB70uuziBH3f792I68zcpkX1Ru7nBQKnxSOr+RQoXtJQv2 EyQvEGjqVYq8qwq7yrFRp/y6IhWZBYHtMkFyg8OB/2V7caTxv59uQcD/++fVILBRXyXLe8Eis2a qZVdfk0XJE/cuUCsaBWFsCBMNS/Eo6nMYps2ei05Q8xaDewwLx9MWhIqVOCAdB+3DhT8nWspXZb 4ecF8i7mWBquLkwDqUrQ== X-Received: by 2002:a05:622a:1802:b0:516:d84a:9f54 with SMTP id d75a77b69052e-5173a92542dmr191551891cf.38.1780391495870; Tue, 02 Jun 2026 02:11:35 -0700 (PDT) X-Received: by 2002:a05:622a:1802:b0:516:d84a:9f54 with SMTP id d75a77b69052e-5173a92542dmr191551491cf.38.1780391495356; Tue, 02 Jun 2026 02:11:35 -0700 (PDT) Received: from yongmou2.ap.qualcomm.com (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51768c76e53sm12480851cf.4.2026.06.02.02.11.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 02:11:35 -0700 (PDT) From: Yongxing Mou Date: Tue, 02 Jun 2026 17:11:15 +0800 Subject: [PATCH v6 03/15] drm/msm/dp: move mode setup into msm_dp_panel_init_panel_info() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260602-dp_mstclean-v6-3-2c17ff40a9b2@oss.qualcomm.com> References: <20260602-dp_mstclean-v6-0-2c17ff40a9b2@oss.qualcomm.com> In-Reply-To: <20260602-dp_mstclean-v6-0-2c17ff40a9b2@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou , Dmitry Baryshkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780391476; l=4086; i=yongxing.mou@oss.qualcomm.com; s=20250910; h=from:subject:message-id; bh=utX2rWcnEK7sp26OqAqarcDBJ0uE50FzNeV/RPRB27I=; b=ag5SVemMbeu4yqDiCnBBxzstPdazchSBZyEVVnFxjr7GQDKrJBa+ZSo/vkMKzp4XCF+WVC/Es 9Onj1rVceKHA+PvOr+gcCfs9ZoABWs6BqlU59zD+QW9fHZGn0M09lev X-Developer-Key: i=yongxing.mou@oss.qualcomm.com; a=ed25519; pk=rAy5J1eP+V7OXqH5FJ7ngMCtUrnHhut30ZTldOj52UM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAyMDA4NiBTYWx0ZWRfX9K2tDKCCshYW mgTcjuNGJWzWx3/Fk9UFV0B8Cp2q53JApeXBVeB5jwQ+eZjKbNpDeaRRL90Fi1UIqM2jmFdg3YI 0tZgJF1LT1QYnCI+xH4L0m66Y08FP8/RZzBFyZsHv/KzGTNXeu7qahmXqidEwLnzRUq0reAu10h AV+a56TlDsmwdQIP+8LOYZG711BKR/HBVZ13hkJIfERVoC5GUSy8Xlcq/xRK5DGCU2s7foySDnP CZCiU/xfvCoUWzQiy5Mp1ZCUNLz8Fu/AOHYkGjHMMlY02lEiZVE3u3le27d+C37Akc4Ho3JcrGs oSJEojZ8Cj/7TJJxSvB1iH+ULmEQewV5Ow69eB2caYpt/JjhUU7gym5WWkLxov6m0do5ScwQ5El oxvvICVh3vR5yLFggDtGHezjM/rng/sf1AxuQdB2zsD/DLu/7rc4FDxwwYMpnwwgmdN64yO37Rz y0nEDUOANRKQgl6fxlA== X-Proofpoint-ORIG-GUID: rv24SAMZo2mmojKOpayRsgYa_9Jy675C X-Proofpoint-GUID: rv24SAMZo2mmojKOpayRsgYa_9Jy675C X-Authority-Analysis: v=2.4 cv=Rrv16imK c=1 sm=1 tr=0 ts=6a1e9e49 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=RRF978PcF5p4qF5CYGQA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-01_07,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 suspectscore=0 impostorscore=0 phishscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606020086 The display layer directly assigns msm_dp_panel mode fields (bpp, sync polarity, yuv420 flag) instead of letting the panel manage its own state. Pass adjusted_mode and bpp as parameters to msm_dp_panel_init_panel_info() and move the assignments inside it. Suggested-by: Dmitry Baryshkov Signed-off-by: Yongxing Mou Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_display.c | 11 +---------- drivers/gpu/drm/msm/dp/dp_panel.c | 18 +++++++++++++++--- drivers/gpu/drm/msm/dp/dp_panel.h | 4 +++- 3 files changed, 19 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 181d238addfc..f33c754b83c3 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -604,21 +604,12 @@ static int msm_dp_display_set_mode(struct msm_dp *msm_dp_display, dp = container_of(msm_dp_display, struct msm_dp_display_private, msm_dp_display); - drm_mode_copy(&msm_dp_panel->msm_dp_mode.drm_mode, adjusted_mode); if (msm_dp_display_check_video_test(msm_dp_display)) bpp = msm_dp_display_get_test_bpp(msm_dp_display); else bpp = msm_dp_panel->connector->display_info.bpc * 3; - msm_dp_panel->msm_dp_mode.bpp = bpp ? bpp : 24; /* Default bpp */ - msm_dp_panel->msm_dp_mode.v_active_low = - !!(adjusted_mode->flags & DRM_MODE_FLAG_NVSYNC); - msm_dp_panel->msm_dp_mode.h_active_low = - !!(adjusted_mode->flags & DRM_MODE_FLAG_NHSYNC); - msm_dp_panel->msm_dp_mode.out_fmt_is_yuv_420 = - drm_mode_is_420_only(&msm_dp_panel->connector->display_info, adjusted_mode) && - msm_dp_panel->vsc_sdp_supported; - msm_dp_panel_init_panel_info(msm_dp_panel); + msm_dp_panel_init_panel_info(msm_dp_panel, adjusted_mode, bpp ? bpp : 24); /* populate wide_bus_support to different layers */ dp->ctrl->wide_bus_en = diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c index bde4a772d22c..e76dad0f6663 100644 --- a/drivers/gpu/drm/msm/dp/dp_panel.c +++ b/drivers/gpu/drm/msm/dp/dp_panel.c @@ -647,15 +647,27 @@ int msm_dp_panel_timing_cfg(struct msm_dp_panel *msm_dp_panel, bool wide_bus_en) return 0; } -int msm_dp_panel_init_panel_info(struct msm_dp_panel *msm_dp_panel) +int msm_dp_panel_init_panel_info(struct msm_dp_panel *msm_dp_panel, + const struct drm_display_mode *adjusted_mode, + u32 bpp) { struct drm_display_mode *drm_mode; struct msm_dp_panel_private *panel; - drm_mode = &msm_dp_panel->msm_dp_mode.drm_mode; - panel = container_of(msm_dp_panel, struct msm_dp_panel_private, msm_dp_panel); + drm_mode_copy(&msm_dp_panel->msm_dp_mode.drm_mode, adjusted_mode); + msm_dp_panel->msm_dp_mode.bpp = bpp; + msm_dp_panel->msm_dp_mode.v_active_low = + !!(adjusted_mode->flags & DRM_MODE_FLAG_NVSYNC); + msm_dp_panel->msm_dp_mode.h_active_low = + !!(adjusted_mode->flags & DRM_MODE_FLAG_NHSYNC); + msm_dp_panel->msm_dp_mode.out_fmt_is_yuv_420 = + drm_mode_is_420_only(&msm_dp_panel->connector->display_info, adjusted_mode) && + msm_dp_panel->vsc_sdp_supported; + + drm_mode = &msm_dp_panel->msm_dp_mode.drm_mode; + /* * print resolution info as this is a result * of user initiated action of cable connection diff --git a/drivers/gpu/drm/msm/dp/dp_panel.h b/drivers/gpu/drm/msm/dp/dp_panel.h index 53b7b4463551..4519ac374220 100644 --- a/drivers/gpu/drm/msm/dp/dp_panel.h +++ b/drivers/gpu/drm/msm/dp/dp_panel.h @@ -43,7 +43,9 @@ struct msm_dp_panel { u32 max_bw_code; }; -int msm_dp_panel_init_panel_info(struct msm_dp_panel *msm_dp_panel); +int msm_dp_panel_init_panel_info(struct msm_dp_panel *msm_dp_panel, + const struct drm_display_mode *adjusted_mode, + u32 bpp); int msm_dp_panel_deinit(struct msm_dp_panel *msm_dp_panel); int msm_dp_panel_timing_cfg(struct msm_dp_panel *msm_dp_panel, bool wide_bus_en); int msm_dp_panel_read_link_caps(struct msm_dp_panel *msm_dp_panel, -- 2.43.0