From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16EFA3CBE73 for ; Tue, 2 Jun 2026 09:11:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780391508; cv=none; b=IOYz2qW/YprthjIFhwZFRfeZ1FiDfn0Z43fYzoPHaSIV33RT/DO9vqjKNeqIh8oaljamsXJ4+fdD1mDg9ZC6NIkHOi+Eya9wcb50YFCEI/cdVE1QqUIFueeudlTTmFx4OdkUVvL5ALFGonxeI13I4FOjXamsKuBw8nHFgBt7cac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780391508; c=relaxed/simple; bh=k2Fff3upCougTurRhx1qk32jaQDI5eLSE+rUossKmgQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=T8i8omwMlu3VKSPXBzLoLIv5FIDybxHgpg758NT7W2x4wfExv1UYAJKcTUmObsx3Vd6t6pl4hpkR0MWg922kch1ulxKNybHeLL/P28DejIccJThri8aw5LyDTrLi2IapvPWwAkRnQmhUbJRBDSh1ovg4bKJNEtlR/k5IiFuFDJY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JUufF27A; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=inWsgx1V; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JUufF27A"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="inWsgx1V" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6525tokT1855124 for ; Tue, 2 Jun 2026 09:11:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= w64aJR4GsiijIIC+qw1V7Ljp4DhfTK7YqGC8ys2CQuk=; b=JUufF27AjkSwlUqw Insnk7c+Z+YHrWCvAUts5brdKPfLi7qWo9keD74aDxhLFgg7sOpsIO+qKHt5WYhd 5J2P4W2IJpiR98MjtgazuuHkCCoY8dg9p5y8Rfq/Qye6D1H1OzO8JJKOloRAI9wO rvaCZnnGLtV+8wOJm5sksgEmMeZz1B4B7pbU04cCLGKv1CbPcSFugsUcylk+u603 4TwhqbUQooCWlT2zH8iC/6Of6dpWIVLGx57+uwQEBkl7bBPlRW7LYZN5q8WCerlm VCMDqh7IVNrO7Wq2RHklDgIzGwBKzZ+r+gMl8akkwX8aEAd/QPltqaOxfIkygtk7 Rwnk3A== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ehsf78svg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 02 Jun 2026 09:11:46 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-5175842d1abso38453151cf.1 for ; Tue, 02 Jun 2026 02:11:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780391505; x=1780996305; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=w64aJR4GsiijIIC+qw1V7Ljp4DhfTK7YqGC8ys2CQuk=; b=inWsgx1VHk2ZAHZ+x9EhHUD65EDzcRHsi6EEfrq4+JhtvWUB4Yk0jeaVBzPyAy9B0W t3A1Zduf1sdyLIwSocKPBo6KorV0qgmt+q7c45UfyceR1JR1yTOyoR3Gbc7Xct8ruL4w MuPO6zeqsCNl9R6O00mtdtEryI5tLqMhvcKaGupymTl7pM9LC/u0EYdQdX7mAHLGbZ7Z gTDTXmlClR8i7Xcdw+Q/VwD07zvr5xD194gDWJ9xWwGJtOfnHdKQN0CNkN6k4Tnpo2YT s8J11mywr0yzYywoejXKxMSKWSd2m1hovZ8zoKK3oZ+TWqBqQTKNFgbI6TQurPorVdqC yIMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780391505; x=1780996305; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=w64aJR4GsiijIIC+qw1V7Ljp4DhfTK7YqGC8ys2CQuk=; b=n827vmRJLqbFltkNSypHHiewhFahYl/tSJoMTm7CSdFDEXiZPdEjZvLk5vGbsi3s95 F4E5ym1mxZtd31qvVJmHrhDDcpfzKHTUaj0A3SKGwYsfbq/rzT+zqD7DN8196uqW1GMr v4U3fWWMOpnHw6Dt0+deuT/Jgq/fu78GHYdxI8IUgfofZ98DuJhQPJ0eNYBybMGEewPU 6xWRnXx0q4gJh9PG6Ytj9yt4iBmhGeH7XZ7ytoLqj/wh69oMr02QavDZPWbHYSkvOUix +BJsfQOSA2f+IhUUzIScphB56JZev554p8PyFz7tM22mh68c6EQ137ngON8qPRqSiQt2 +c/g== X-Forwarded-Encrypted: i=1; AFNElJ9OmNZUuzAExWS6fZK2LtbkdKfXtvtfPaFhOU07W7OUcNt0iQynTO4U0bJkmxjKJPLSEpAOquw5zB9lUT8=@vger.kernel.org X-Gm-Message-State: AOJu0Ywg2CJuYOz2Fesmvxbr+rUXGK3FoJC5hvS2SDTguKkIa8QDD0bf WIbiqwTS+I51djOJNakAnuNT1OsCHCN/RTTSt/rU0ldF+kDTW2M1oAAeSecWy4+/kgoEPcCvA4T PTa4RHEG0Aorlz/pcoCa/Swx46oTsF+iD26fcE6VYPFtdfikboypgl186+XEndNsU+QY= X-Gm-Gg: Acq92OF+hyWbOejhejhfGVMyypVrJFuYBKn0ocUzKx9f0Pd9vMfJ15DnTPqrXze4XdN KjPdVwCluKIE4CFFEYVS7HcilbV9ZfXMXeLGPG8Kgn3itehPxEPx+Yy+RbynqCwjv1OuuuZVLSd GwreVuoZYPRh7fbQeo4VClbu+U4bE0baBeCT1i0SSUe8YZgdffbRuQ6PSR8il1Fr79EDyxkcDsZ HTF6HcIl7xsoegpGF5MG3J7P09OkxH4U3Cj8hrmKbHQy1PvikqRY7CPSl8cm8lZnc14gp4Lf6lA yjjD26mcHJ9jfJsKGh5vAW3t+FdjxmxUQCSY79w2F5RbI8qsFHmMKGQpXOxbh32S95OmrKcoWpV QykJHTPlaI0MZc0mmTIcftAJB2W7kV1KKdI9gK4TGh/9bp3SRyBGGiP4m9Xpuo82c2A21D0Hyuw hHwN3Bacjk3Dv2E8C/LQ== X-Received: by 2002:a05:622a:1812:b0:50f:c9a2:1643 with SMTP id d75a77b69052e-517662835efmr36172971cf.11.1780391505063; Tue, 02 Jun 2026 02:11:45 -0700 (PDT) X-Received: by 2002:a05:622a:1812:b0:50f:c9a2:1643 with SMTP id d75a77b69052e-517662835efmr36172701cf.11.1780391504654; Tue, 02 Jun 2026 02:11:44 -0700 (PDT) Received: from yongmou2.ap.qualcomm.com (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51768c76e53sm12480851cf.4.2026.06.02.02.11.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 02:11:44 -0700 (PDT) From: Yongxing Mou Date: Tue, 02 Jun 2026 17:11:17 +0800 Subject: [PATCH v6 05/15] drm/msm/dp: extract MISC1_MISC0 configuration into a separate function Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260602-dp_mstclean-v6-5-2c17ff40a9b2@oss.qualcomm.com> References: <20260602-dp_mstclean-v6-0-2c17ff40a9b2@oss.qualcomm.com> In-Reply-To: <20260602-dp_mstclean-v6-0-2c17ff40a9b2@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou , Dmitry Baryshkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780391476; l=2097; i=yongxing.mou@oss.qualcomm.com; s=20250910; h=from:subject:message-id; bh=k2Fff3upCougTurRhx1qk32jaQDI5eLSE+rUossKmgQ=; b=i05DXxqApSBHDn24Y/faO64tUx0fwhQhNrJN23hr3yxu0q6ThLoselo9pXKhvx2pg3MCF6Xpc uOM/uL5oVQKBuNBbQTbinDYz8cOaqbhcNVc6RquNhHROUM7d9+u9qWU X-Developer-Key: i=yongxing.mou@oss.qualcomm.com; a=ed25519; pk=rAy5J1eP+V7OXqH5FJ7ngMCtUrnHhut30ZTldOj52UM= X-Authority-Analysis: v=2.4 cv=WKRPmHsR c=1 sm=1 tr=0 ts=6a1e9e52 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=TC1OlXllJ9dbkp4NpB8A:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: EE6ccH6bBGDRkS3Hu-JYTk2g_P1H_ULl X-Proofpoint-ORIG-GUID: EE6ccH6bBGDRkS3Hu-JYTk2g_P1H_ULl X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAyMDA4NiBTYWx0ZWRfX8BpZRRkx8p1d YcD3gt1BNvLclA/kCgm1vJ3H0NrZfevVO3sj2sscQZTATp1vVkUtweHlLnK4D/pI0r79KYUQoXC qjcAI5VbvBDwNAiJcnf2Bsrv3DzKp99eY+jSN/pcywP03y7VIp24W0CQECNRKWhfEKTWwBBXW9S R+B3vMixaC93XFJnsQjjB1KmSRBzNFG+eK//j+vKXac2sdgbPFAxL2tlR8a1mg3lpieCacdoQYh bk7EAz/8298Yp2Kk5XDL5h26gisYluCaYiMzEaZwASoMDjxippOt93pPoZ3bdleL/aOb9J2RiW8 x28zWIzHvnWXkgXgjFotvOSfDPOUlSRg+M3eHvAofq3O3QEsZ4HTSByMzJU4omNdWZLlSWhRdfJ j4i+WFT4+BUqeiEoJLYaLSvpn4y4oQqRnMCPu+t/+THUbexbp5q9FTeLzhxQHpTGmYhe5FwjIl+ cw1juZzi4bNnAW4RpnA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-01_07,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 phishscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606020086 Refactor the MISC1_MISC0 register configuration into a standalone helper function to support MST. Signed-off-by: Yongxing Mou Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c index ed2ba47881fd..71d45b2c4daf 100644 --- a/drivers/gpu/drm/msm/dp/dp_ctrl.c +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c @@ -458,17 +458,13 @@ static void msm_dp_ctrl_lane_mapping(struct msm_dp_ctrl_private *ctrl) ln_mapping); } -static void msm_dp_ctrl_configure_source_params(struct msm_dp_ctrl_private *ctrl) +static void msm_dp_ctrl_config_misc1_misc0(struct msm_dp_ctrl_private *ctrl, + struct msm_dp_panel *msm_dp_panel) { u32 colorimetry_cfg, test_bits_depth, misc_val; - msm_dp_ctrl_lane_mapping(ctrl); - msm_dp_setup_peripheral_flush(ctrl); - - msm_dp_ctrl_config_ctrl_link(ctrl); - msm_dp_ctrl_config_ctrl_streams(ctrl, ctrl->panel); - - test_bits_depth = msm_dp_link_get_test_bits_depth(ctrl->link, ctrl->panel->msm_dp_mode.bpp); + test_bits_depth = msm_dp_link_get_test_bits_depth(ctrl->link, + msm_dp_panel->msm_dp_mode.bpp); colorimetry_cfg = msm_dp_link_get_colorimetry_config(ctrl->link); misc_val = msm_dp_read_link(ctrl, REG_DP_MISC1_MISC0); @@ -482,6 +478,17 @@ static void msm_dp_ctrl_configure_source_params(struct msm_dp_ctrl_private *ctrl drm_dbg_dp(ctrl->drm_dev, "misc settings = 0x%x\n", misc_val); msm_dp_write_link(ctrl, REG_DP_MISC1_MISC0, misc_val); +} + +static void msm_dp_ctrl_configure_source_params(struct msm_dp_ctrl_private *ctrl) +{ + msm_dp_ctrl_lane_mapping(ctrl); + msm_dp_setup_peripheral_flush(ctrl); + + msm_dp_ctrl_config_ctrl_link(ctrl); + msm_dp_ctrl_config_ctrl_streams(ctrl, ctrl->panel); + + msm_dp_ctrl_config_misc1_misc0(ctrl, ctrl->panel); msm_dp_panel_timing_cfg(ctrl->panel, ctrl->msm_dp_ctrl.wide_bus_en); } -- 2.43.0