From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73BD73D47A1 for ; Tue, 2 Jun 2026 09:11:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780391513; cv=none; b=KI+12cuDgxZt5/QZcuRU3Fo4/k5HlOhfef2MVT07SGJyAPahg6oDppElcSyObafV5ORFbpfF3Dugs2dBIbPriQ9XlKBGMcGNhgMraR1EuYDloeyqKo4afgekAi+/VGcSVWRVY4FMQoBju4JkrOWKbGD8QigWR/Qa8eX8H3InIOs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780391513; c=relaxed/simple; bh=ixgmYJIVCgIesw8IPUX+/UcnW6cdOBjM+XPZmes1+Eo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YHd17TEEDOqlZQFU30NTbjiAwGVPRP7/J8VS7u1elbtIs4/wWfK/HLqkh2qI5ml6uDh9URRooBeHowvDU7l+DRv0L2HihSY1AkjS1hxUGC6jc2IWTG9ivAeEQZHdLt+g2sjyPLNoxTsy5IsHwWkc3nZpOc5CcWxzgaqkqOIZc58= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nRB5h+VL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JFUlGSPt; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nRB5h+VL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JFUlGSPt" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6528WprO3430318 for ; Tue, 2 Jun 2026 09:11:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IovUpKpDFwGWZaF4DLWER239PrNpT7oEBKFqXm1bx5A=; b=nRB5h+VLOnyb7b5H MzBxDkXq2aDo6Ver+IH7SW1QClrIB3SACFd4T9J+1+TZtZasYhREa4K7kS8OXacF /JiRFxZUq35P3Q/xIiEw5JQjAsZo/lyW28OL4eU0kxYyYfJMVQZOb3pgyEMAMuPu nK5NzkXQPz2SjTPsnZGXRrJSfrXFAx2F7VE5O6SLYd/r6Lnbk8caXOws+JYOH8ze x/H8u7QvIUWGcNDxXqnfzLqLf5v4S2JK+7FFImBMsMV3afIzbGbQTFlZTVts+m7l 7oc/6bxsubZ6Nw9d/3JGxxPrt7GyRT1hL2Yl5clhtIKAdx561giMHGbIZAb3i5/K FW5xLA== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ehn8mhq2u-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 02 Jun 2026 09:11:50 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51771d41426so4623941cf.2 for ; Tue, 02 Jun 2026 02:11:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780391510; x=1780996310; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IovUpKpDFwGWZaF4DLWER239PrNpT7oEBKFqXm1bx5A=; b=JFUlGSPtLDYE3RmjVCtEqRUNo+GNA/PkhlGFI47t+JIfmVHcRPp3jtm/c+XZB8wX5Q HFXxBqA+y3jpghNcjOgcI0Dw083JAl3QExdZIUrl4ESOnyR3JpExZpQDvCYXlmMMBhHt Du8J7yZJRMR5tJ6Wq5ShPfKSsJQZG/Noj9Bm7l9+6ki2aSAmlib61x6Vd4EVAuvbOKet yBxPx2QKk8UWpKRfzJvN2C0PplBiUulq+rAtiaxEztW5JFe8KiWbEhuwXYpw+b9kay7v QJXn4eR1Be03zff1Kt68hBx/NeQ++qF5aCp93tImifrTHR6M+f1DCjS6Ll6xLFfU9rCM vU4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780391510; x=1780996310; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=IovUpKpDFwGWZaF4DLWER239PrNpT7oEBKFqXm1bx5A=; b=Xlv4e8XgB25pnumbHIvgZEVc4OG3BPYpnNUaAiM2aFjURRvu77IISpc9xQAG9plx91 /TuCKl4QeMwrvl0w4z1FBr1q/pqAqND1TUzSnT4e+D0k2LNHptuoOay/Xj0FRBq81wI+ B9tAvXCrd2jS/bEFzA3iIsurHnjiQt+Wy5dCPdn6fSn/0Q4mJrEAi2/jj8JbEmYKhOFL 2nDy4W5Egoc3TdH0uXUH17Y2DuV0VEMywlgIGZQ+i9fRGhcGGiQzt6ijR+l/xXVHKm1V msQO62FDVJ2EMlQhP3sq+/EeRH4sUqMwf4H0GEVqulLKmEcGCN5VKsupgKGUup/GAWgd p/nw== X-Forwarded-Encrypted: i=1; AFNElJ+GX5tfxtDpga18Oa7h1xDUQIAbyeB24GGcE5kAzdcAsW5KI9Gu5ed7guDve83RsTAwUQrQgAUedWb5IdE=@vger.kernel.org X-Gm-Message-State: AOJu0YzlnPEHYCMUrMiAXkAqLrsbqHw8Q4zzcsjObauI7dmOtl7YVA+I jJlpRU1W2hR3DqsutUZpHdG+muUHzfY1L1rj9TqM5v3r7cRVgB7fHoMikv1il9ChuHatvmKuVYC 4g7DQG0p7EWApAhPiq7QWOHhtcdhT9HqDHXEjb4Vc9rEbNPxt70i1qBy7fnHSJuyewtg= X-Gm-Gg: Acq92OFjabepKbolfVJqA3ltBImMj6fvxah9mRJVSwb910nftBH2M7l4IQZdffA8Boy jIeEB2QGgin4U8KFszxw/wVIJoZgpGTHH3e338mKclpBYX5gdbRoMFAu8Smru2MZHH6cdwd9W7x zbrGQmW+nG1DGSBZxKjlrAdLAshoqgHlOUIvIwed3rZDHuOaxAmNZWsm3OR/sze/r4VZdNT4IOM mqIjDpeM8YLNQxhcbANaxW37RN7v2EQZekwXXvaXxPJmviqzUQ0VU+i7llAEpr3amEeTfeVhlP9 C6k9deE50hIHsmKvldTGr/pscdWTr9FueU1E2aKsLZ1DYHzW0fAeWhJGN0EfJ6rlujUE2nild6+ OuMNnJ1BR9pvzmyfjNc95+BavKb6P7T+fph6447WfBMZUx3z0U3bhj04rSchtgS7JMskInCDr/g VH/HFlzv6am7qG7eD3nw== X-Received: by 2002:a05:622a:5588:b0:516:d4b1:48cc with SMTP id d75a77b69052e-5173a5b4efbmr215685781cf.8.1780391509712; Tue, 02 Jun 2026 02:11:49 -0700 (PDT) X-Received: by 2002:a05:622a:5588:b0:516:d4b1:48cc with SMTP id d75a77b69052e-5173a5b4efbmr215685341cf.8.1780391509319; Tue, 02 Jun 2026 02:11:49 -0700 (PDT) Received: from yongmou2.ap.qualcomm.com (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51768c76e53sm12480851cf.4.2026.06.02.02.11.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 02:11:49 -0700 (PDT) From: Yongxing Mou Date: Tue, 02 Jun 2026 17:11:18 +0800 Subject: [PATCH v6 06/15] drm/msm/dp: split link setup from source params Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260602-dp_mstclean-v6-6-2c17ff40a9b2@oss.qualcomm.com> References: <20260602-dp_mstclean-v6-0-2c17ff40a9b2@oss.qualcomm.com> In-Reply-To: <20260602-dp_mstclean-v6-0-2c17ff40a9b2@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou , Dmitry Baryshkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780391476; l=1402; i=yongxing.mou@oss.qualcomm.com; s=20250910; h=from:subject:message-id; bh=ixgmYJIVCgIesw8IPUX+/UcnW6cdOBjM+XPZmes1+Eo=; b=wQzA1NrqLbrqIbng1TSRR2q9hmwp+iEZEBvdcs8FrTVsSEdAZMPKBB4tatmzXucFn4wiG3Qc6 4279BVHj7IKCpFz2/1YLNZLLtl56qWVDUllMS4Cim1r5nPqnBWg2OO6 X-Developer-Key: i=yongxing.mou@oss.qualcomm.com; a=ed25519; pk=rAy5J1eP+V7OXqH5FJ7ngMCtUrnHhut30ZTldOj52UM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAyMDA4NiBTYWx0ZWRfX9bqwuMWXir+t UJWGxvQHviI8M9RKCTyAFAvw6JNlPkC6rWHsmE3KOwBpe1zKxS1Zlvlly5lybYLVkw8U3oVtolA Y1d90l3QOiCa6l6+MWw4JE7Di6Dm6PTVfnkpfnKkuX+wG8euvaK96ahlHY7WfO7SnM2LwC5NF+c 7a7LBYDUcazTCaqt70hMTu/P6orAnxNynRZ3ozUYMJ2/n4ylXKpdeTF2sR+i0UKy8o2gUMKiyli JH0CHgi4t04C55ETNC1Ld9RKwR1+UQrbbOIrfJCmk6ui88SisnCO9sCB9AwMsW8Ube3s7ZYwu7k Ddk3yAMV15PmBoB5ZOAYFOoQRXaoUrVgw7387PzHkgl8IFstv3keySvn8NBL4cHPV4S6aatEO1p mW6FAcNO5YrIz5JA5YUipK6fFinIPMepZPVbpd7YZ+QNrfaO++WVdQcoz6M3gQJgTQDjG4TrM4q JYC+gQj8ioWpneTPyQg== X-Authority-Analysis: v=2.4 cv=d5nFDxjE c=1 sm=1 tr=0 ts=6a1e9e56 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=saXSvH3Ee-fMY4W8qR0A:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-ORIG-GUID: C-hzCGktyI3448MqhGOjgYMChaTLr0bC X-Proofpoint-GUID: C-hzCGktyI3448MqhGOjgYMChaTLr0bC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-01_07,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 malwarescore=0 clxscore=1015 adultscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606020086 msm_dp_ctrl_configure_source_params() should only handle stream-related configuration. Move the link setup out of it so MST can program link and stream settings separately. Signed-off-by: Yongxing Mou Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c index 71d45b2c4daf..1c2eccec6ec6 100644 --- a/drivers/gpu/drm/msm/dp/dp_ctrl.c +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c @@ -482,10 +482,6 @@ static void msm_dp_ctrl_config_misc1_misc0(struct msm_dp_ctrl_private *ctrl, static void msm_dp_ctrl_configure_source_params(struct msm_dp_ctrl_private *ctrl) { - msm_dp_ctrl_lane_mapping(ctrl); - msm_dp_setup_peripheral_flush(ctrl); - - msm_dp_ctrl_config_ctrl_link(ctrl); msm_dp_ctrl_config_ctrl_streams(ctrl, ctrl->panel); msm_dp_ctrl_config_misc1_misc0(ctrl, ctrl->panel); @@ -2551,6 +2547,10 @@ int msm_dp_ctrl_on_stream(struct msm_dp_ctrl *msm_dp_ctrl, bool force_link_train */ reinit_completion(&ctrl->video_comp); + msm_dp_ctrl_lane_mapping(ctrl); + msm_dp_setup_peripheral_flush(ctrl); + msm_dp_ctrl_config_ctrl_link(ctrl); + msm_dp_ctrl_configure_source_params(ctrl); msm_dp_ctrl_config_msa(ctrl, -- 2.43.0