mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: Mateusz Guzik <mjguzik@gmail.com>
Cc: viro@zeniv.linux.org.uk, jack@suse.cz,
	linux-kernel@vger.kernel.org,  linux-fsdevel@vger.kernel.org,
	adobriyan@gmail.com
Subject: Re: [PATCH v4 0/3] revamp fs/filesystems.c
Date: Tue, 2 Jun 2026 15:19:19 +0200	[thread overview]
Message-ID: <20260602-eiskalt-kaputt-baubeginn-739632ab746b@brauner> (raw)
In-Reply-To: <20260529171840.2576445-1-mjguzik@gmail.com>

On Fri, May 29, 2026 at 07:18:37PM +0200, Mateusz Guzik wrote:
> The file is a mess with a hand-rolled linked list in a desperate need of
> a clean up.
> 
> The code to emit /proc/filesystems is used frequently because libselinux
> reads the file, which in turn is linked into numerous frequently used
> programs (even ones you would not suspect, like sed!). In order to
> combat that pre-gen the string instead of pointer-chasing and printfing
> one by-one.
> 
> open+read+close cycle single-threaded (ops/s):
> before: 442732
> after:  1063462 (+140%)
> 
> Additionally scalability is also improved thanks to bypassing ref
> maintenance on open/close.
> 
> open+read+close cycle with 20 processes (ops/s):
> before: 606177
> after:	3300576 (+444%)
> 
> The main bottleneck afterwards is the spurious lockref trip on open.

There's a bunch of work in vfs-7.2.procfs on top of what's currently in
there. So please any changes should be a diff on there otherwise we have
to rebase that whole branch when it's already -rc6.

      parent reply	other threads:[~2026-06-02 13:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-29 17:18 Mateusz Guzik
2026-05-29 17:18 ` [PATCH v4 1/3] proc: allow to mark /proc files permanent outside of fs/proc/ Mateusz Guzik
2026-05-29 17:18 ` [PATCH v4 2/3] fs: RCU-ify filesystems list Mateusz Guzik
2026-05-29 17:18 ` [PATCH v4 3/3] fs: cache the string generated by reading /proc/filesystems Mateusz Guzik
2026-06-09 11:30   ` [External] " yunhui cui
2026-06-10 14:34     ` Mateusz Guzik
2026-06-02 13:19 ` Christian Brauner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260602-eiskalt-kaputt-baubeginn-739632ab746b@brauner \
    --to=brauner@kernel.org \
    --cc=adobriyan@gmail.com \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjguzik@gmail.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®