From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 846B337BE73 for ; Wed, 3 Jun 2026 01:37:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780450675; cv=none; b=YAboz97hSWCD9cJ8xoR9e+NpypxTB+4eKxgkXmP3FHaWXs75DDhqMtTrGtY79qibc7eGI0DDYhmIhG7YQT2kKe+hRgA8fffSksc6H8GZy3afVGMbM8INHIBQO83Qa/oUKgcCmRqdsYYKvAs9iixobokNT7acrHm3nQKBOFGBtRM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780450675; c=relaxed/simple; bh=rkHcjsPkRR9nNSHxR46h2y9fTpo1dvARrrbdvhIHj/M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=phgtZaES9ZxR7oUNKEdHLyXPj73MHLP32nWiT5AtFHizHhcNf+XbAMYqyWN6EwIUe0A7EZu6a0DDjEyCTNJsU/GTgUx/AIXWS/vfME//zcXrHHZgSp+x9xngM1S4kWeyMpiuQ1D6kSovUD+69COEnVgjh6q20k+LkoVL5fDVFVI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Yh2xw/Ap; arc=none smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Yh2xw/Ap" Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-c85c531d4a9so947223a12.2 for ; Tue, 02 Jun 2026 18:37:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780450674; x=1781055474; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=p8Jk1ivLmwr3VP3ike29F6VRWUYvoG1CiSF1zOqSE6U=; b=Yh2xw/ApLaK4resB94WFblQ/eikImAqAuEOp587sPYEjBTK4UnO2fyTABGxs9vVMVa YlO5fNbOjoOzB8HVXiXp4i9oJy6lJGQC0TALrfM6YF7pdsM51eVafuBoJ99u5ftiDUSo dMumZFMS/lxO1XQym3Fqp0C4JXTOWB2/4FUHaOLEnZTJBURSYp2UurXGdiHVwS7l9l2n MEmwJNMR4wKEHDIZdv1h6+EYcDH+X9rcw85hfW/4M8h+j19JZDDWoKE5VvTVlfpvv6kE NSIqD3ndYoGxbaYRDTXz9iiXTiRW/JruO9A3QE6Vo+48QhAVmIYEvLjxM2jd7f1SCRxA MpDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780450674; x=1781055474; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=p8Jk1ivLmwr3VP3ike29F6VRWUYvoG1CiSF1zOqSE6U=; b=ViPMsatX7FnXt1/PJOyVNQpB57DZRrBZPOPDbO5ERVvs6iiz9QvTvB+5ciOYeliFEg 6oBkBplNYd8Adpaj5OMH977xXyi7mr5QCe81elGP+VvZ4Dpk/N5dKXZ4XzQunU35ImWT dqTOapOTyyoUqPrRi3GoMyjbF1QMYu7eML6S7XFUjPEMbHemk2Pzt5BzdrTYXNa0PpjK ujcrcqQL6Os1W+kHwq5J2bKl/1Kg8JkUBY7KSoMfH9FgRYZatP7nMV906SeyP9nOvdC6 VjroGhPqDnEOItqMNWdg2MeppUqEjc1NKroj2rBA4KeRYeIvDhmchPioO9rYunFwPwxk y3eA== X-Forwarded-Encrypted: i=1; AFNElJ/rD5qO4IEuRPhk15oN53CRs1d5L9VULChy5SYlicssHd5DU5Ng3AZv7Yp9Pl/qqd211ci9tcgtONcrR7w=@vger.kernel.org X-Gm-Message-State: AOJu0YzltwAa96BO5ND7RzX7CUFUbEek9BZow6wkZVvvRvKZNbmKbuDf 9MPN+UUqVGW//B2sdFsTLcLOHmU5BnfQxKnpow1c8i1lxz8goIgZAwps X-Gm-Gg: Acq92OEfyq6vcnfRgiSkCwkUcLT3lhymTwR4dVwnEqlnGaiX/VCeuU8xAHQfk03Pnk/ QrEo0OWJ4J98jcgaMqMfB+kHGav7huh5zPPo3f8SuuUU10vPQWZg+CWn1cUJ+DB5yCh95UKxjzt 0PHBMQDUnVHOSrMoi9na7jScaOwDnPlNlzO8vYlTGqmkx1xi9XwiAOSZVb2itvPIrWi2uxexTju c5iqUVD9xY3uRLgzobeBuXJ+NecH06FGegrREp92A6T9MLiY+Wqc4TGPAhcfsakuiWjSUraH01z blIExHWdoAxXM4qgEOGO6uFcwzyl5/7aOqlUf4qzRLRYdhJPjhgbGqR42tq3k94vr6q5dlmZ6ej Ub7dNm0ic+hBJBk2Fpf/FHwqkgl/dSlghceNz3oUm2t7bFUa78HtEWHiSQH72ARUHe+FQ6VBR48 jnKZCPgpHllHlGn8/muJddfmGh/SwhXAZwm3RuD58b X-Received: by 2002:a05:6a20:c79a:b0:38d:fad1:cf2a with SMTP id adf61e73a8af0-3b4973af276mr1426953637.13.1780450673809; Tue, 02 Jun 2026 18:37:53 -0700 (PDT) Received: from localhost ([2a03:2880:ff:50::]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c85df043216sm525522a12.10.2026.06.02.18.37.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 18:37:53 -0700 (PDT) From: Bobby Eshleman Date: Tue, 02 Jun 2026 18:37:31 -0700 Subject: [PATCH net-next v2 1/2] net: devmem: allow bind-rx from non-init user namespaces Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260602-nl-prov-v2-1-ad721142c641@meta.com> References: <20260602-nl-prov-v2-0-ad721142c641@meta.com> In-Reply-To: <20260602-nl-prov-v2-0-ad721142c641@meta.com> To: Donald Hunter , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Andrew Lunn , Shuah Khan Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Stanislav Fomichev , Mina Almasry , daniel@iogearbox.net, matttbe@kernel.org, petrm@nvidia.com, dw@davidwei.uk, Bobby Eshleman X-Mailer: b4 0.14.3 From: Bobby Eshleman NETDEV_CMD_BIND_RX is currently GENL_ADMIN_PERM, which checks CAP_NET_ADMIN against init userns. With recent container/netkit/ns support for devmem, other userns/netns use cases come online and require bind-rx to allow CAP_NET_ADMIN in non-init user ns as well. Switch the flag to GENL_UNS_ADMIN_PERM to allow bind-rx for CAP_NET_ADMIN in the netns's owning userns as well. Signed-off-by: Bobby Eshleman --- Documentation/netlink/specs/netdev.yaml | 2 +- net/core/netdev-genl-gen.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/netlink/specs/netdev.yaml b/Documentation/netlink/specs/netdev.yaml index a1f4c5a561e9..49862b666d7d 100644 --- a/Documentation/netlink/specs/netdev.yaml +++ b/Documentation/netlink/specs/netdev.yaml @@ -798,7 +798,7 @@ operations: name: bind-rx doc: Bind dmabuf to netdev attribute-set: dmabuf - flags: [admin-perm] + flags: [uns-admin-perm] do: request: attributes: diff --git a/net/core/netdev-genl-gen.c b/net/core/netdev-genl-gen.c index c7e138bfe345..d18c89b5a6c7 100644 --- a/net/core/netdev-genl-gen.c +++ b/net/core/netdev-genl-gen.c @@ -220,7 +220,7 @@ static const struct genl_split_ops netdev_nl_ops[] = { .doit = netdev_nl_bind_rx_doit, .policy = netdev_bind_rx_nl_policy, .maxattr = NETDEV_A_DMABUF_FD, - .flags = GENL_ADMIN_PERM | GENL_CMD_CAP_DO, + .flags = GENL_UNS_ADMIN_PERM | GENL_CMD_CAP_DO, }, { .cmd = NETDEV_CMD_NAPI_SET, -- 2.53.0-Meta