From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FEB831F9A3 for ; Tue, 2 Jun 2026 03:44:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780371896; cv=none; b=FEf4z2uq2Vsd0lvoYzCibMxffZdMWvVR67/aUF8XGMt6eaIega8AFLVsgHewbhf1b8/lV/TFKUnNFEFyuVapeNRxN8yqq7zdlCj0Q60cxg4qhZ9Vgacw0bo1R38bHcUwnHgh794Wt0qP5T8iiYK2+IFBIzX89kaww2V7CaLzGys= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780371896; c=relaxed/simple; bh=mRYJ7PxOrFtv65CLLZ54456b0DWYC5nxECBKHwzvqXA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pVo6bwjArk0x4EEGIZZLL+b+e6i4UbKKYcAsCYuBTPnX4RA7D6vGsqZSlwZmXLdsX6rCShCzm7HBOL95xEWcSEsFUFR0LaPrb3hh9SOgPy1Z+3wg+t86YXS9KKzC1Mrsa3n4Lntak1y48kiVjJisuMQAZ0/gZbU2czoge93aXlY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=j56VatWv; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j56VatWv" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-490b2903757so411515e9.1 for ; Mon, 01 Jun 2026 20:44:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780371893; x=1780976693; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mRYJ7PxOrFtv65CLLZ54456b0DWYC5nxECBKHwzvqXA=; b=j56VatWvGaz3veX5e2UPEkNGoQMxNYEVcdmYM/PmAY2eOZNnC1fBrD+uccJOEpZbNO 68yi8IttcWmqpvX8mHUuJs5Noahm7w3/z9zLSuYXpihOGXvfUM5K4tklFixKjCD1+ju/ daYVRKvofGTfk06qaqxXSGbJJH4R+8hn5BizMs57o/AKgQTuRBeKiwCv9PX2ZEFfKSzf WwM4XR7eRV9XkraEgzOkucn9wygcxaAYaAoeREHTgo0hDo+/TW/r4kg1bsTa124ijoXR U9OK0fwjHuprh4wwsCuA3vysM6s3j2wgmB5LwE3P+22b5F1js/dgIOP51SWVAdKu8qau NC2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780371893; x=1780976693; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mRYJ7PxOrFtv65CLLZ54456b0DWYC5nxECBKHwzvqXA=; b=BltDM+P4OsN9xj+hcHBEjmQI8X/WZs0pl5Cm6BAa4qQ/dsb0JqPRZQJQVaspHjKLbe Da1n7YlbbSWvXQHftXJjRGAaSZVt2PPZSf5IZNNzjqALASHoyKW3TzoSsFbMh+I3Sjiq KRxg+N544aLRC9sE8XnSTR7pGS8Nl5COYv4CSXafRsFX3uTn7UacqP6CVGSvxruAYIbI L9INUG2kpIYK2nCfXE3oPBpzlk3Wm9cvN97GNyG6mO5dPfWv/0EpjIK5Lob1UZvziVyg dpIf7VhevTre+0UMwPswl5nRrvrRL0847PL+JdvgCUJj0J1kGgYiECQJRCmMEDAfxkgh GC5g== X-Forwarded-Encrypted: i=1; AFNElJ/MgtJrMYuJ054VN6YMOAc3nX3N8rBtxoauX41/xrF9+5/XrEUsY/ujPHDAUl9RCnkukQtB9jtj2coRr7c=@vger.kernel.org X-Gm-Message-State: AOJu0YzDcoIU9zJ9zxtPW6BH/nP01o1fO0PUpZwnmvzM25rKcL9A4YwF JOmH98orgoinzj7aNxxm1C5UzFqEkgat3HUtqPecCmHiCARYrvDBRhg= X-Gm-Gg: Acq92OEstnQ6FSZXvEXhtco7Hyt9GnlVV/i7j6qEJEpcb7l2nkh8+N24Mnu7xqipP16 RSQ/lHqQqPzKbUk6UoHvnBKuQev+v1o/0sP+EkjA4W+VNzdsnjTDg8szPLFrdxt7ja7RyOn9+ta nOk21cfsEA2ZEaq8vxwa8d387W6I8bsYPmKKy6GbxjNwS52h89jyIRDCcjITa3bRI2IdDVBaUA8 Q6L6flTAAOqAEdLJhuJ7j8QvMWvgF6g/dcL46sbiPxRpjg3+T7zlHb3cKtKIHPs0HXO+S8OSdCr MUPsvelvraqkBfr7IAAoWeRC1ExwGE7I1W6MgJpHq7aryf/MRoIiIof4+q40EPkgSX5ZvqrhIhR KlFK+ympBgYB+rK/9ckjOH3OyKW0RZBCLRUmDu/EsNJIsl2fpDaIPhYI1iYvAYJQo9YDLENspEu KDWmFGxj35Br9MtZbpsJA2YOX/NkPCOyxnhlFHD0mqZTdF0y80OUF18/UntTFKXo/Kvd6sbLg// JOVFydvnLjZ7YeLrMYcJ36cjSpUb5MwHny1OWJ+LSkty8VaLKqTKpS2coga15K7Oxv7ga9jWffv a2CmcS0BT91g0N01LuOlUytHmAJNyHdzcXKd7pR+d1PwnuBuJHCByw== X-Received: by 2002:a05:600d:6405:10b0:48f:e230:29f4 with SMTP id 5b1f17b1804b1-490b0ea300dmr21500185e9.15.1780371893353; Mon, 01 Jun 2026 20:44:53 -0700 (PDT) Received: from dev-debian.lzampier.com (brnt-07-b2-v4wan-169550-cust456.vm7.cable.virginm.net. [82.14.129.201]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490b0daefbbsm59794995e9.0.2026.06.01.20.44.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 20:44:52 -0700 (PDT) From: Lucas Zampieri To: Rafael Passos Cc: linux-input@vger.kernel.org, Benjamin Tissoires , Jiri Kosina , Sebastian Reichel , Bastien Nocera , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, kernel@lists.ime.usp.br Subject: Re: [PATCH v2] HID: Input: Add battery list cleanup with devm action Date: Tue, 2 Jun 2026 00:44:51 -0300 Message-ID: <20260602034451.398835-1-lcasmz54@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260602030519.3097058-1-rafael@rcpassos.me> References: <20260602030519.3097058-1-rafael@rcpassos.me> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Rafael, Thanks for catching this and the quick fix. Turns out this is the hidinput_cleanup_battery() hunk we dropped in the devm conversion (patch 1/3), figuring devm would handle the cleanup. It frees the hid_battery structs fine, but never unlinks them from hdev->batteries, which outlives the devm scope, so the list dangles into freed memory on the next probe. My bad. Acked-by: Lucas Zampieri