From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E6BF33B6FB for ; Tue, 2 Jun 2026 06:24:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780381442; cv=none; b=QXdwPq2DVOy1b2L39DqJYAg2L8AWEcQGerOhcqKG4pA5n72YjLll0ViStEqBrvNLnCKi+K1lDUWIz63U3ipj/qIvQM5x/vR3Jqv243ZUImWK2JwANoyAV/u3M8gs9hic4AxXVKECezhBqG66ym2aa1C+JbSbWGmYQJLkRpsPhRE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780381442; c=relaxed/simple; bh=+yL4q3mvCOIkoU9eWpUC3/7X6hFeWmh+WekwoFARR54=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EQ6pDoasCrQst5ZcGKO0Vr4R0imweMd95XXKAYFMaUSBUm+q6sTE5nc/VuFyEEBuaY6+WoidQhJHJg6fn7q+rikzKmh2qiOMsKuTw1sXhy6RkO+uiK7sJOJj5JnvEcLwGVG4JWmz2IEzvQC+GFj0vJixA4Foo/K5e1esImI3JBE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ezGaOfsj; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ezGaOfsj" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2bf237e1433so39946675ad.1 for ; Mon, 01 Jun 2026 23:24:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780381441; x=1780986241; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+yL4q3mvCOIkoU9eWpUC3/7X6hFeWmh+WekwoFARR54=; b=ezGaOfsj7Nii9wsA1c6NUHMQHms3t3AQ4cN4Ezp/6rmr2YmmXEDIsE+jB7zmqUrhG4 FydzIzzXEO+bqdUxKoMx0XDTmDR78MmlX5aheJcCbEAUoAeiQyqUx2jrqw3YhRWkupdg c0ASdf6g044as9TcShIgnM0SisZ1TEKDfDX6PMvg88RC+8NMwj5yJd/Ubsu0eAyLBPV3 7chrZfLEsKbWWUimSxgNi9i992CBk3bgruOdjwmYbRGbw2EG9lhGdACC3AGes+ftFkrk UjctEi0GyymIdJk3e50HryTjnL5QDuvQk61VnjvssiEKBcKDfI9PXXy9WMjAv5ydxnLY KqmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780381441; x=1780986241; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+yL4q3mvCOIkoU9eWpUC3/7X6hFeWmh+WekwoFARR54=; b=BbvnqnOLzZet94YqPNqRU6KUUhD3gr0dQ72+6BUAqAaEhY+p27PH8r8DvO2MGnpuSD jWdo28cdYcwahpkLqCBdCoHUA5mgNBQp2IXEFhUrNXKuPMHtYNR046DdlmiyWei/FOF1 fUbt35un88Mgb1WcA7ic+bE6SAJTU6jpmUdKGThHH/BGpiWMBO7gCQzERIJimk72wnJh fjeLNZxcfUSUmuhZJ3Op3w0fLrSWzsFivJ7fboBi2mdXiinECtL6ttkR+AXtisvJbbhi hrBZUGaZVcC8+cPHUtces0BqnpCKn5teanDX5JapsgJtFzH4eE5b7p2QYrwSWmmfyKbT F7Yw== X-Forwarded-Encrypted: i=1; AFNElJ8VQWD+1BAlnhuidKqMGHgStcAAIwjpDQF6277/BL3kib9sAyUfxz8XP+PSSkkbS4PUC0WcrUJEwsFBBWs=@vger.kernel.org X-Gm-Message-State: AOJu0YzTZa4frtwoyLWNwm6/YWb4upPmU9MWsqbOE4ACluHFggwEYvq+ X1+GiSVgjH2mhkRHb/Yq1KqaWO2rIpeoffkw12oWikuPkAjB9dK7xyWI X-Gm-Gg: Acq92OEodeIcC3Cc7V3qoBmCQ0ywpIwWdOZ79kx7gK12QT60PTxtdsVSBJQBErf0ovl MdqH8QUwBIzR8//rLwODKWeJgDx5MhEc/BPWYH27EYU86joQAAmrHIaTUdEHmFMOXDj2aSvhYxO rN4BhOzjSfvhBe1hhR/ZI+z+nATyPoOc4WWDE82SLJxgqn0LeiE32UykEwG1rXy9llN1ROqaS4I OG+pCq4e3m8Epbiwr79w2AiOWcFLyvp9m9cWL8pzsn/ynwBeJGsX/PvZHIjBZ0dOEM0PGSpns4i /hGdT8CpFFxNQOhjv09u/fACM8hSd3Y4uyPPCQU8s0sVvhcD3jPqi0jmZZZSFm2teF0zDEO6cB4 c3/jWhVOx6TGelBcdb2NVBD1Ch3Be4Z2M5IMILj/AwT06ysPGD0y3sT38J6JzlW/yDLKxk0ootH frzYposMf1pNFUrKs/pLs10tj2PMHaDGBUsO2K4ZjK3TgHlnUMQFVgfacXKwrMSC082k/qgBJex cedllPH9g6WX91I93o5s78moQ== X-Received: by 2002:a17:903:b0f:b0:2c0:e158:1dfa with SMTP id d9443c01a7336-2c0e1581e3amr83091605ad.21.1780381440653; Mon, 01 Jun 2026 23:24:00 -0700 (PDT) Received: from secrnd-cstp.tailb7f510.ts.net ([125.131.91.97]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf239fdf0asm121313555ad.26.2026.06.01.23.23.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 23:23:59 -0700 (PDT) From: Sanghyun Park To: fw@strlen.de Cc: Sanghyun Park , steffen.klassert@secunet.com, herbert@gondor.apana.org.au, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] xfrm: policy: Fix use-after-free on inexact bin in xfrm_policy_bysel_ctx() Date: Tue, 2 Jun 2026 15:23:46 +0900 Message-ID: <20260602062348.1995083-1-sanghyun.park.cnu@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Thank you for the review. I apologize for the several mistakes I've made. > There is no such commit, neither ID nor subject. You are right, I apologize. The correct one is: Fixes: 6be3b0db6db8 ("xfrm: policy: add inexact policy search tree infrastructure") > Looks like this patch is whitespace-damaged. Will use git send-email for v2. > Could you also say in changelog why you added the 3rd criterion? > Became (bin && ret && delete). The extra ret check was only meant to avoid pruning the inexact bin when the lookup did not actually find and unlink a policy. Pruning in that case is harmless but unnecessary. It is sort of an optimization fix rather than security-related one. After looking at it again, I will drop the extra ret check in v2 and keep the original condition as bin && delete to make the patch minimal. I will send a v2 with these fixes in a concise version. Thank you, Sanghyun