From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B6C53793CE for ; Tue, 2 Jun 2026 07:18:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780384697; cv=none; b=f56QntvC5tAzW7EL/yjICl4W8WLUEiSyaqkH87eEqblfApXxjJSsFx3SfDd1lHersXfE0uVUi+dAr3/UJvVM8pQ18s5UE/o8fNvfmBm7/NUMAsxNdM7DCXj+Mu+/INybB/b/KSKO45b0H5wEwLz+c4N01ScyizfuM6mxqSqlwpo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780384697; c=relaxed/simple; bh=JPVQANRPzIydaU0WcpkAVORq1mGKEPTOEIUcCS0y0vU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ozPDoVzLSjdiL/e8tVL9vOALPwOfVMPMaRxKb+tYBtVLfyliSx8U53CySgo5Nn0XfRoPnmlGrDKHB2d8Eq84L+IdyXAPIT52Wzi+xQcQ1FkluMCEg10mHFgctNEb9RXq7ihRV+7XSswMV+dAzz32Ofh1W7kEC2Iko0KO/6FmErI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZZ5KSwYM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UoMqVuPw; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZZ5KSwYM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UoMqVuPw" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6525tioc1855018 for ; Tue, 2 Jun 2026 07:18:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=GExpfkrACNf d8AgKb7pzoxx6CS0kiv0JrtZqZXX3hVQ=; b=ZZ5KSwYMKZBdV2J7rA+BKaZVSuY kJFouZjz6jCJZi/iK3YsFL+fbQ+DTKEfBqyDlULM8aLXhwfih66W2eYPiYHm8+Nn I9ZXzC6UncyYH3dH4pvWoMjOAZa7ORpPsuj5RnKVxO770UnmGOtgwYogZH6nnIUv vyl69sWA+GjmvwmgLrsLootw3pvSvJsgwYdyqSDP7HDNMQVbwkdTIkE1obBs99p9 o0y+yfRFEf3+EmlswYIA0WYi5G90IeGvD60iNE+nnKgRIR5qlhCoS9lNDbB1RWMH TewUoF3xx6+URUz/Tvx/kAE81KU+sRfnFjnfOh67Mmjt0UntQ5ZVrJbwaOg== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ehsf78ab1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 02 Jun 2026 07:18:15 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-36b7c55406bso3981431a91.2 for ; Tue, 02 Jun 2026 00:18:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780384695; x=1780989495; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GExpfkrACNfd8AgKb7pzoxx6CS0kiv0JrtZqZXX3hVQ=; b=UoMqVuPwE9u/qzrZ0EOWwHRULgDap4fSLoVpxHgjyqV5VoZ9V0Dam2aTPL+7m4cX8+ OHtDAK3eRcaNYYorJqBYGZfF1bDbmRfXmoq+C0LBGBqRTAkAujMrVqojjJahYtUR8FxI RTXesmvyWHYqIPKZ2jTwcUnO0EnmXfSG8nJaCBUYd+m8C32Iyr8l3XBeCMBRhdl9ahHR 7Zz1P1aAlCI6lupN1KwWHKHMHq8hNB9J/FMdEAL2gByL98hq2tqTSuep0N9zcjSieVHi fSvOctSK4v/p40NvzKmZNjr0RWVn/2dLCXa8nv1KuAMCkUWNlHzl9cNDywYzwmLjSjzH hHxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780384695; x=1780989495; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GExpfkrACNfd8AgKb7pzoxx6CS0kiv0JrtZqZXX3hVQ=; b=q+xj3x3qcLQMjc71SdlIMSaJFMndTpP4tdTs+obZRtzvz5BTVzZXDsFiCO2YWEg4kS BhWbQMOMWuDpJlJbC+ltQ6eanFLcbdb8b9VRlUJ/dEnUGwD19gpvLe0C8Yf3KtweNtIb PmIbdPHeEp7gM0YWpWP7U3zJErIrgh11Si/Bz22dvq2rpsqz3XP2GCsU4jNiZwbNF4Ak kZ/+YWpqapDm3AnGB+k9Rv4zUvpjNvV4kvkq9g3Cc1Wq52Ov8i02nOpD396uphvqSC3E Ed0SWJci0aHcjo9dIru3pR1u0u81KhaHALDhskCEgb0TwnKW9FHRwftq4hSqDpykjCge oa7A== X-Forwarded-Encrypted: i=1; AFNElJ+dH4Bme588S9FmBG31ALgBivFydPlNfGwWp3Uh6l3C5m3cYnk7tL8n7+ixn4DpwDn4ZOh7nDiVU24eHGQ=@vger.kernel.org X-Gm-Message-State: AOJu0YylvDIDNAWp5xVgaHRTJqMBO6z7kQoipMIyrg337B+TwMNvahG5 oZJ8ZKOpq0dzT+wNkXbqlESCw8m5iFu37IATKZFnkBAYtB2ghFB2EaONS4v8TeDbUgDHdwtJzkq U+CTBg7kgzST/al1mTbYU2et0jQUve2p35Fieg9iOhwVuoHMctq2umVlfokFi4U0ve8E= X-Gm-Gg: Acq92OERN8ux3n/AWv9rmZ/jT6+of7DQqbmccNr2ZGUtjc5bZXc1Nito8b0kMs6USO5 3oTF5MHZooYBo8Ov+pYG4P7cuiqHOg9dYTovdtQvu8FiB5+Fi52/J/oPT2PmWK/JaP7YRjJZnVz skzZCJXGXbLFIdAtsoQNnlVxZfGHBtV79D/Gc3cNzPDmcHUQYBd+rlWMEIRBNNkb0OBJBTjStXw Nr/2MIaCm3V/iOLZ7FTwnt4ki0h3/sHd0Wywx+8O40hmp0z49dbdoTbZjDhrMe556g9tjAHfDAq ohOHISTC/5udwxy3904+u1KXzYqotbckhECHRsBGJVXP73f1exFD+Aq3RV8xUauWxD+gPD2h5g4 2qWbt8B5QdIuLLyKv2YxjfjscsNf/BI7j3endTi7SKcIo84ZmTgTv8tArKCDqDAyq94XuF7mIze HV4mAkWsyyg9wjatz9hIInA3yO8p5jMQ== X-Received: by 2002:a17:90b:4a4d:b0:36d:dd4a:1e59 with SMTP id 98e67ed59e1d1-36ddd4a24e2mr2251909a91.23.1780384695123; Tue, 02 Jun 2026 00:18:15 -0700 (PDT) X-Received: by 2002:a17:90b:4a4d:b0:36d:dd4a:1e59 with SMTP id 98e67ed59e1d1-36ddd4a24e2mr2251844a91.23.1780384694470; Tue, 02 Jun 2026 00:18:14 -0700 (PDT) Received: from QCOM-SocCW5bzXR.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36dd91c9991sm1766279a91.7.2026.06.02.00.18.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 00:18:14 -0700 (PDT) From: Jianping Li To: srini@kernel.org, amahesh@qti.qualcomm.com, arnd@arndb.de, gregkh@linuxfoundation.org, abelvesa@kernel.org, jorge.ramirez@oss.qualcomm.com Cc: Jianping Li , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, ekansh.gupta@oss.qualcomm.com, quic_chennak@quicinc.com, stable@kernel.org Subject: [PATCH v7 3/5] misc: fastrpc: Fail Audio PD init when reserved memory is missing Date: Tue, 2 Jun 2026 15:17:48 +0800 Message-Id: <20260602071750.526-4-jianping.li@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260602071750.526-1-jianping.li@oss.qualcomm.com> References: <20260602071750.526-1-jianping.li@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=WKRPmHsR c=1 sm=1 tr=0 ts=6a1e83b7 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=cwMOb1EeFLyGxYfGK4oA:9 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-GUID: 6K8upSBYWXZAg7nMDvsgJ3INi3SlLFFQ X-Proofpoint-ORIG-GUID: 6K8upSBYWXZAg7nMDvsgJ3INi3SlLFFQ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAyMDA2NiBTYWx0ZWRfX8bpF862RBH/U hQqPhUFNIV3ezJ0aHnDBV1EZUadmEu/g0ivFvnViUJEQ8Mpyz7+ayTN3paSEfhOY9HSOzLO7A02 7yh3cFLkk4Jjk4qwpoG27pBDrC5KOGX7NuDvMfvRMTMZ0jYjV5sFGMUJtR7EF8lhPQn1X08ZGcx q4qnhjan2ZlWgqHxc9pUcAgPy04lqiKJT0Y/+S04DMW6qevO37VU58AelyTVYVe9I6LuXC6FrdW D9ktBULkHUNRr0UuEWU8uIDUSbEuUiUvMxABiqr1bEbzJH7b2+8r5H/UQ4NWQrmkQEyOun5ZqP/ cZcCjlDd18S8FobGJt1yoETo+EUqcg3h5zE9OdX6gbkG+1YxQ++J3fPtcvjSv4B0adMC+Q95m53 AnEBfy0wj29uJVn+hdphuAjJZGfarR9yav3TBkW5pSE8q5sQu3ftteCsvmgGe5obJnhX9Ome4i6 hwJVvyJdHIIeUJL9pDw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-01_07,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 phishscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606020066 Audio PD static process creation assumes that a reserved-memory region is defined in DT and exposed via cctx->remote_heap. If reserved-memory is missing or incomplete, the driver may pass invalid address/size information to the DSP, leading to undefined behavior or crashes. Add explicit validation for remote_heap presence and size before sending the memory to DSP, and fail early if the configuration is invalid. Fixes: 0871561055e66 ("misc: fastrpc: Add support for audiopd") Cc: stable@kernel.org Signed-off-by: Jianping Li --- drivers/misc/fastrpc.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index a8a58f889d07..f46a8f53970d 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -1354,6 +1354,13 @@ static int fastrpc_init_create_static_process(struct fastrpc_user *fl, } inbuf; u32 sc; + if (!fl->cctx->remote_heap || + !fl->cctx->remote_heap->dma_addr || + !fl->cctx->remote_heap->size) { + err = -ENOMEM; + dev_dbg(fl->sctx->dev, "remote heap memory region is not added\n"); + return err; + } args = kzalloc_objs(*args, FASTRPC_CREATE_STATIC_PROCESS_NARGS); if (!args) return -ENOMEM; -- 2.43.0