From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 376503C5857 for ; Tue, 2 Jun 2026 08:32:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.92.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780389173; cv=none; b=lSAXKzp3J5TGPPme+gLM+kCN10l8Tc2c4dA3KzufIMBIV0ePvOP9V25yYPy7IQ5HZMmE/0il8hKOD4u5yu5tFni5gJ9ErgkzsBn8ho8RsR4zxqSNMRTfIgI50tlfXrtqjd1TC0s4r14HsOEWPjRWlXby5ak2cgxsNrQt0AU5u20= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780389173; c=relaxed/simple; bh=jliaCqv867XubrbkMEXHccWMZ9FwEpHqtFQ/PQz36vM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BJFWArJ9TZpjuFbLYW1MRj0Udbkes58YDvjjBPXAaI3R4A4X2zbrKtz1M5BqN/sXrZqSyKIE3yRXLMfOLFEhkoiK3fvvDBVhe9KLD1hmDzbKjcPJwVI+XjcPHfuwz0bc1/p6FnAxdZu5TLTjUfDRNPAlq64U89C71YxMQorSA5U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=pass smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=c7unQtiy; arc=none smtp.client-ip=90.155.92.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="c7unQtiy" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=edXNoYKpVpEgPWVgTypSQPOo7Y6+xVY1Lu7YfoMw2zI=; b=c7unQtiy/62SLpd/MRLzAfzeaM 6e7J3FdAJHQ2ilDkVI0qzQlo6l51PmQN90OxoVpVQYlE7QeI3Tt7CQXbdf+Rl1a0wZGT0LDZ/zARn iAmxij4GDXVmkkKuJZjAvCbHidA6NALS0u7ZnqznQDw5DStuFXg1vAvrV3jvTnLOIUUs3F2lwSec2 kG0dMlrCAwr63MncwoMh6pZtmtrE3rdLbAqQDiWH6vYb48KFYueob/2iP056Tj+CBGq/HMjLTkUab Rzr3CMB0V/zEUtPfaMSiHSzFIZslN81qpE1jyfZVCSgd6JFT8SWl+KMKzOr2tjUHE0KdReyp8HhlT 1I87tiQQ==; Received: from 2001-1c00-8d85-4b00-266e-96ff-fe07-7dcc.cable.dynamic.v6.ziggo.nl ([2001:1c00:8d85:4b00:266e:96ff:fe07:7dcc] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wUKYC-00000008krj-2Aj2; Tue, 02 Jun 2026 08:32:40 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 5589B301123; Tue, 02 Jun 2026 10:32:39 +0200 (CEST) Date: Tue, 2 Jun 2026 10:32:39 +0200 From: Peter Zijlstra To: K Prateek Nayak Cc: Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Aaron Lu , Josh Don , linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] sched/fair: Unify cfs_rq throttling via account_cfs_rq_runtime() Message-ID: <20260602083239.GU3493090@noisy.programming.kicks-ass.net> References: <20260528094830.13291-1-kprateek.nayak@amd.com> <20260528094830.13291-6-kprateek.nayak@amd.com> <20260601134842.GP343181@noisy.programming.kicks-ass.net> <20cc9820-35b2-4d97-bbc2-84af56802dfd@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20cc9820-35b2-4d97-bbc2-84af56802dfd@amd.com> On Tue, Jun 02, 2026 at 12:31:36PM +0530, K Prateek Nayak wrote: > My mind is taking a while to grasp the ->pick_next_task() removal. > > [1] https://lore.kernel.org/lkml/20260602050005.11160-1-kprateek.nayak@amd.com/ Yes, I'm familiar with that struggle. If you can manage to write a comment that clarifies it somewhat that would be awesome. I've tried, but every time I read it back after a few days, I'm just left more confused that I was at the beginning :-(