From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D94F3BE620 for ; Tue, 2 Jun 2026 08:54:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780390479; cv=none; b=JIQKDMnCBDttcrLJCScgT1wReF+EiAJYYNcNbs5LYWDMnhs0CPKcUnpqXESblDKwJ4yG4XgzODcZxfx2r/TmkxeacOBL5itw1q0h2+wawzLN53vFahzY3OMFJRxoOWsC5ip6BEtZz3bNsxrESvEjEhc2vVMhOIGnjBzozUeugrY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780390479; c=relaxed/simple; bh=ZaT+/7I10sjNAE33VAam3Fr1U5ow7W6JonB5Vz+sqe0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YgPu9KSqUgdQ4A2j1qbVDZlfESiBJJtvrqceRzsOcLYm7yq0G4VHvrUI3JZDie+7klIJfTLdCfVe+vFZK+lDT185oI/YvIEcc1Qk42Xqq5mw9B9dwnN7dadTl7Pb2A/Qj5vAyOeYDSaXHMna7Pg4evC4v4L6oG+s/vgHslWT4+I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=eKgG316/; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="eKgG316/" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-490af320e2aso11280155e9.2 for ; Tue, 02 Jun 2026 01:54:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1780390470; x=1780995270; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=myNFao4QCXHlYEfG8LUTprsTeobP90lLd7U+QggG78M=; b=eKgG316/KBjytg+fN2GNxNJ1p3YDxyhsc2jNUsCJMYcBoIVJJckjirJ1mBmfar/xFD Tbfw5VjZ0bepbHOY9yGiUhgBuPP+B30TaLuTh3FN9FPBMa6HGaskpiTQNkrcacJ32TOv BuwFTbG/zJP335PoBSalUR6U5Cy5aORr1Ip7tVkpWEKlNYtui05B66aCNJaCBpBQXEv1 Syzpu9/ubjaHNUL/ngmLvDUewTbciHFWXZYm0adEMo6ujUr9DuUSIFmIdPeKzplu78nW v1/VuqkJaRf0u+xagl2Jyos/NJ7lKU6VWw2IF7vbMb5PLvYlqxd4EQt2wDRBFTXMQfRr op7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780390470; x=1780995270; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=myNFao4QCXHlYEfG8LUTprsTeobP90lLd7U+QggG78M=; b=VDtKCNtNfnrRleS99VUgS+7nED23duBcdjXUGYxCnPWGiA7AangokQHRdR4q9xaGt0 2IbrAs1bdsATFEsJIm2ZupuWgdcdyD7g47SC7v2DhyIOLQRDNXn9e8IfkjILxzn/t+Yx ZIUMMhp07NQ4X6zoBI+GWO4lyTTHn0VFahR2qy9UOMFYbj4DbAJ9glFUAXiFnprcjoEa cSgbulstaaRQ3g63DN+rV3JzkBAGPyL5hAgHz1QFAN5deMveN6D/gY6VYrfC4TiSp8nJ fzjDCkRB9+jgr0wCxZruKkk/1ZWUIU8I4MU5oS2VWySxNWBOauCoRDDd9kw8qFbBZTHz otSw== X-Forwarded-Encrypted: i=1; AFNElJ/NpHUKjKlWShirNTSCJ7PbsdIVymW9RFLEbcL993GKn0yOAJGq66dpguepFT+uhp7CrYji6/fEtrhcCdc=@vger.kernel.org X-Gm-Message-State: AOJu0YyOErIPWxXzMB+ZxTaKIIoMuwmx1Tycdn1sbaSU0lJSCxDUnBN7 Utw1EWG+at/Ng+o/qe3iqSpqSFQ+UKpikZOIU9oDDywixKckuCWCX7R5tbulJel0B4M= X-Gm-Gg: Acq92OFD+lzM8RbESzdzxB0zV86wfwE6oOvo4y3HIAgvSkJ/SwIGkiHyIlhJnW7XzFH YDfIQj0Ob33eiV3GNQRWR6U2wQc7NPfWNn+9ZT4llUAqSOzpKMWoCsZRzdYXOYK6es3Chm/XR8m D/Wib7R1a7ACWhQ0Qncz1WCk3Obd3bqrYHrl+tib+fI46HLh+sRwxXnu84GEuLfPO/TDolB875c ecjDC6mpDL1SwJBcRae7tK4C/gPA8PSUnaKqWcdGG6ahE/Tr5YdGi6fq8fTmeKNrdBeygl40DaN 7uravgc1m+SJ6QW1JOAognDnrAjn/9n3/VJ3TT+Sc0UOC7QCdrTg8Zkfk/KRCtfCCPyKi/jsFXF /x5t59RKHFEFTLtL8GjG2JIWBYhtzbpG9k8cRikD3e1uRogZLdoC6EwnLn97YdMrZZi9ZMDpo3A xwcV+dvjDfTJq+U5u2aOvJHKwxgiiX5E5KJO6i X-Received: by 2002:a05:600c:190b:b0:48f:f64c:c2fe with SMTP id 5b1f17b1804b1-490a298f29bmr64680585e9.22.1780390470661; Tue, 02 Jun 2026 01:54:30 -0700 (PDT) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4909c1035ebsm148114195e9.5.2026.06.02.01.54.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 01:54:30 -0700 (PDT) From: Petr Mladek To: John Ogness Cc: Sergey Senozhatsky , Steven Rostedt , Marcos Paulo de Souza , Chris Down , linux-kernel@vger.kernel.org, Petr Mladek , Sashiko Subject: [PATCH v3 05/11] console/braille: Lock console->setup() call during the registration Date: Tue, 2 Jun 2026 10:53:06 +0200 Message-ID: <20260602085312.228251-6-pmladek@suse.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260602085312.228251-1-pmladek@suse.com> References: <20260602085312.228251-1-pmladek@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In braille_register_console(), the console->setup() callback must be called while holding the console_lock. This prevents a race condition with a possible active boot console that might be using the same hardware registers. This applies the same protection to the braille console registration that was introduced for regular console registration in commit 801410b26a0e ("serial: Lock console when calling into driver before registration"). Reported-by: Sashiko Closes: https://sashiko.dev/#/patchset/20260423130015.85175-1-pmladek%40suse.com Assisted-by: Gemini:gemini-3 Signed-off-by: Petr Mladek --- drivers/accessibility/braille/braille_console.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/accessibility/braille/braille_console.c b/drivers/accessibility/braille/braille_console.c index 7b324329882f..9ed3abffb687 100644 --- a/drivers/accessibility/braille/braille_console.c +++ b/drivers/accessibility/braille/braille_console.c @@ -356,7 +356,9 @@ int braille_register_console(struct console *console, int index, if (braille_co) return -ENODEV; if (console->setup) { + console_lock(); ret = console->setup(console, console_options); + console_unlock(); if (ret != 0) return ret; } -- 2.54.0