From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4393F3E95BD for ; Tue, 2 Jun 2026 13:29:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780406946; cv=none; b=RalJR3llSoKkHQVBf+R6JdivdMYAwWOMsUWQ6bQ8t+h2VeVRH4ZMD41QtHCq0wsW2bCIuEvDVTXSwRd3alM3u7FLoTRGhmrLQ1z9S9sedJff33RwpFHz0oGxVdz4HNIEeL8TnlCIZ017ni36eKb/gDbt2TehbdLxoErH2TRdUXA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780406946; c=relaxed/simple; bh=z4jo9wQK7BCuf2T6lxZzO0pH7gJx/4HknMx2a5pllMk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MBgFGPouFHDTlqqERAsmz2hcB62MqZiOikNGl/WW53w6HjcqLzprlichTeGVrwIOUZsHOiPU57X/xHIEmx6TlxLFXp1DQUpE19wCqiXrcELfO0qJQZ1ylW2m35/XCEZkhXoCE+Uf217FX7QEu5IYnN8fnpqp3FcUIyIzGLBbIME= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=T8uYQsmb; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="T8uYQsmb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE0AF1F00898; Tue, 2 Jun 2026 13:29:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780406944; bh=IfCVbZ5MNhLZ2k/mZZ6dMFMSJ/4ShA27RA4/y6hlIj8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=T8uYQsmb6a7hO5aBvyb/cEV+CKbuBff/eck/zWre1njfXZhiraKMedE8LTeNzdiLe 1a7FAa9baq9oiLv2379T9i3VpteMeqs57brn9PndPr9RZDPhgli9V/XtLzlAQmgt2E W5XDARPRmLy/y3q3HTAD5CfYLsM56S4HXTXYyn5Uv8X80BjeKNIo+VkORZfAhETiyV 81VNLTni5ZnUkoA608E3OhDb/WZuu3f220ZJ+t6du19mXhD+CrFTARtu0Sr2SjgZaJ lSnO7Xy0KDk4z+oszjjXwV8o9b6S0qQILGOuWbkxBesxPH408pp1AdC2SivDweLjbO jNLFJWSqzggCA== From: Claudiu Beznea To: wsa+renesas@sang-engineering.com, tommaso.merciai.xr@bp.renesas.com, alexandre.belloni@bootlin.com, Frank.Li@nxp.com, p.zabel@pengutronix.de Cc: claudiu.beznea@kernel.org, claudiu.beznea@tuxon.dev, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, Claudiu Beznea Subject: [PATCH v2 09/17] i3c: renesas: Use reset_control_bulk_{assert, deassert}() Date: Tue, 2 Jun 2026 16:28:16 +0300 Message-ID: <20260602132824.3541151-10-claudiu.beznea@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260602132824.3541151-1-claudiu.beznea@kernel.org> References: <20260602132824.3541151-1-claudiu.beznea@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Claudiu Beznea Use reset_control_bulk_assert() and reset_control_bulk_deassert() in the suspend and resume paths to simplify the code. Signed-off-by: Claudiu Beznea --- Changes in v2: - none drivers/i3c/master/renesas-i3c.c | 30 +++++++++++++----------------- 1 file changed, 13 insertions(+), 17 deletions(-) diff --git a/drivers/i3c/master/renesas-i3c.c b/drivers/i3c/master/renesas-i3c.c index 7167ca12a328..860c9f2f17de 100644 --- a/drivers/i3c/master/renesas-i3c.c +++ b/drivers/i3c/master/renesas-i3c.c @@ -1485,6 +1485,10 @@ static void renesas_i3c_remove(struct platform_device *pdev) static int renesas_i3c_suspend(struct device *dev) { struct renesas_i3c *i3c = dev_get_drvdata(dev); + struct reset_control_bulk_data resets[] = { + { .rstc = i3c->presetn }, + { .rstc = i3c->tresetn }, + }; int i, ret; i2c_mark_adapter_suspended(&i3c->base.i2c); @@ -1493,20 +1497,14 @@ static int renesas_i3c_suspend(struct device *dev) for (i = 0; i < i3c->maxdevs; i++) i3c->DATBASn[i] = renesas_readl(i3c->regs, DATBAS(i)); - ret = reset_control_assert(i3c->presetn); + ret = reset_control_bulk_assert(ARRAY_SIZE(resets), resets); if (ret) goto err_mark_resumed; - ret = reset_control_assert(i3c->tresetn); - if (ret) - goto err_presetn; - clk_bulk_disable(i3c->num_clks, i3c->clks); return 0; -err_presetn: - reset_control_deassert(i3c->presetn); err_mark_resumed: i2c_mark_adapter_resumed(&i3c->base.i2c); @@ -1516,19 +1514,19 @@ static int renesas_i3c_suspend(struct device *dev) static int renesas_i3c_resume(struct device *dev) { struct renesas_i3c *i3c = dev_get_drvdata(dev); + struct reset_control_bulk_data resets[] = { + { .rstc = i3c->presetn }, + { .rstc = i3c->tresetn }, + }; int ret; - ret = reset_control_deassert(i3c->tresetn); + ret = reset_control_bulk_deassert(ARRAY_SIZE(resets), resets); if (ret) return ret; - ret = reset_control_deassert(i3c->presetn); - if (ret) - goto err_tresetn; - ret = clk_bulk_enable(i3c->num_clks, i3c->clks); if (ret) - goto err_presetn; + goto err_resets_asserted; ret = renesas_i3c_reset(i3c); if (ret) @@ -1563,10 +1561,8 @@ static int renesas_i3c_resume(struct device *dev) err_clks_disable: clk_bulk_disable(i3c->num_clks, i3c->clks); -err_presetn: - reset_control_assert(i3c->presetn); -err_tresetn: - reset_control_assert(i3c->tresetn); +err_resets_asserted: + reset_control_bulk_assert(ARRAY_SIZE(resets), resets); return ret; } -- 2.43.0